summaryrefslogtreecommitdiff
path: root/CONTRIBUTING.md
Commit message (Collapse)AuthorAgeFilesLines
* Remove "official merge window" from CONTRIBUTING.md [ci skip] Adam Niedzielski2017-01-261-8/+0
| | | | | We should not discourage contributors from submitting merge requests anytime they want. Our process for reviewing community contributions no longer depends on the release schedule.
* Update CONTRIBUTING.md after merging "up-for-grabs" and "Accepting Merge ↵contributing-md-accepting-merge-requestsAdam Niedzielski2017-01-261-14/+14
| | | | Requests" [ci skip]
* Link to k8s contributing doc.Sytse Sijbrandij2016-12-271-2/+3
|
* Update CONTRIBUTING.md - Adding info about issues within a milestoneTaurie Davis2016-11-161-1/+4
|
* [ci skip] Fix UX Guide link on Contributing.mdux-guide-link-update-contributingawhildy2016-11-151-4/+2
|
* Merge branch 'rs-bin-changelog' into 'master' Rémy Coutable2016-11-021-7/+2
|\ | | | | | | | | Add a bin/changelog script and changelog documentation See merge request !7098
| * Add changelog documentationRobert Speicher2016-10-311-7/+2
| |
* | Replace MR Description Format links Daniel Axelrod2016-11-021-3/+5
|/ | | | | | | | Replace links to the `Merge request description format` section with up-to-date instructions on using the MR template built into the UI. The `Merge request description format` section was removed in 2f7e28d1, but links were left in the table of contents and in the MR description instructions.
* Convert CHANGELOG to MarkdownRobert Speicher2016-10-161-1/+1
| | | | | | | | | All this does is convert the version sections into headers. The list items shouldn't really be indented by two spaces, but it makes no difference to the rendering and this way we retain authorship history for the actual changes. Related to https://gitlab.com/gitlab-org/release-tools/merge_requests/29
* Improve the contribution and MR review guideRémy Coutable2016-10-071-28/+21
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Merge branch 'sh-add-link-to-reliable-capybara-specs' into 'master' Achilleas Pipinellis2016-09-161-0/+2
|\ | | | | | | | | | | | | Add link to article on how to write reliable, asynchronous tests with Capybara This article has been incredibly useful for all developers. Adding a link to it so more people can refer to it. See merge request !6312
| * Add link to article on how to write reliable, asynchronous tests with Capybarash-add-link-to-reliable-capybara-specsStan Hu2016-09-121-0/+2
| | | | | | | | [ci skip]
* | Simplify the 'Implement design & UI elements' section in CONTRIBUTINGupdate-implement-design-ui-elements-in-CONTRIBUTINGRémy Coutable2016-09-071-16/+2
|/ | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Merge branch 'mr-performance-guides' into 'master' Achilleas Pipinellis2016-08-311-0/+2
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added performance guidelines for new MRs ## What does this MR do? This MR adds a set of guides that should be followed by merge request authors. ## Are there points in the code the reviewer needs to double check? Spelling, grammar, etc ## Why was this MR needed? There is no set of guidelines one should follow when submitting merge requests. This leads to developers at times disregarding performance. This in turn results in performance specialists having to clean up the mess, or production engineers being woken up in the middle of the night because the database is on fire. ## Does this MR meet the acceptance criteria? - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - Tests - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) cc @DouweM @rspeicher @pcarranza @dzaporozhets See merge request !5905
| * Added performance guidelines for new MRsmr-performance-guidesYorick Peterse2016-08-221-0/+2
| | | | | | | | | | | | | | These guidelines cover the performance requirement for newly submitted merge requests. These guidelines are put in to place to prevent merge requests from negatively impacting GitLab performance as much as possible.
* | Link to the issue templates in Contributing guideMark Fletcher2016-08-251-2/+2
| | | | | | | | | | | | | | | | Change to use a better title style Add backticks to code segments Spelling and Grammar
* | Reflect template addition in the contributing guideMark Fletcher2016-08-241-56/+3
| | | | | | | | | | | | | | | | | | | | | | | | Adjust bug template to adhere to standard bug report format * https://developer.mozilla.org/en-US/docs/Mozilla/QA/Bug_writing_guidelines * Guidelines use the following format - Summary - Steps to Reproduce - Expected Behaviour - Actual Behaviour
* | Update contribution acceptance criteria with tests requirementsdz-test-requiredDmitriy Zaporozhets2016-08-191-3/+2
| |
* | Add test requirement for new filesDmitriy Zaporozhets2016-08-151-1/+3
|/
* Merge branch 'dz-newlines-styleguide' into 'master' Robert Speicher2016-08-081-0/+2
|\ | | | | | | | | Add newlines styleguide for Ruby code See merge request !5636
| * Add newlines styleguide for Ruby codedz-newlines-styleguideDmitriy Zaporozhets2016-08-051-0/+2
| |
* | Add migration-related tips to the "Merge Request Guidelines" docadd-mr-migration-guidelinesTimothy Andrew2016-08-081-0/+4
| | | | | | | | [ci-skip]
* | Merge branch 'coffescript_docs_migration' into 'master' Rémy Coutable2016-08-041-1/+2
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update docs for CoffeeScript -> JavaScript. ## What does this MR do? Removes some CoffeeScript docs and adds more JS ones ## Are there points in the code the reviewer needs to double check? No ## Why was this MR needed? To migrate some docs ## What are the relevant issue numbers? #20098 ## Screenshots (if relevant) None ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !5433
| * | Update docs for CoffeeScript -> JavaScript.Jacob Schatz2016-07-221-1/+2
| |/
* | link the engineering workflow document from process and contributingjob/update-workflow-linksJob van der Voort2016-08-021-0/+2
|/
* Cleanup feature proposal templatecleanup-feature-proposalMark Pundsack2016-07-131-1/+2
|
* Add License Finder information to contribution acceptance criteria.Connor Shea2016-06-071-0/+2
|
* Merge branch 'fix-design-link-in-contributing' into 'master' Achilleas Pipinellis2016-06-041-2/+2
|\ | | | | | | | | | | | | | | | | Fix link to current design reference in the CONTRIBUTING guide ## What does this MR do? It fixes an outdated link by replacing it with the up-to-date one. See merge request !4439
| * Fix link to current design reference in the CONTRIBUTING guidefix-design-link-in-contributingRémy Coutable2016-06-021-2/+2
| | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | Let contributors know where to start Zeger-Jan van de Weg2016-06-031-1/+1
|/ | | gitlab-org/gitlab-ce/issues/14905#note_12235996
* Don't advertise the use of "ci skip" in the CONTRIBUTING guidedont-advertise-ci-skipRémy Coutable2016-06-011-4/+2
| | | | | | | | Now that we autoscale runner, we don't need to optimize for their usage anymore. Abusing of "ci skip", for instance for view changes can lead to broken specs, so let's just not use it! Signed-off-by: Rémy Coutable <remy@rymai.me>
* Merge branch 'feature-proposal-contribution-guidelines' into 'master' Douwe Maan2016-05-041-0/+10
|\ | | | | | | | | | | | | | | | | | | | | feature proposal issue template in contributing guide This adds a feature proposal template to the contribution guidelines for internal and external use. Fixes #15448 cc @markpundsack @stanhu @dzaporozhets See merge request !3967
| * feature proposal issue template in contributing guidefeature-proposal-contribution-guidelinesJob van der Voort2016-04-281-0/+10
| |
* | Merge branch 'link-to-code-review-guide' into 'master' Robert Speicher2016-05-031-2/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | Link to GitLab code review guide in contributing guidelines I noticed that the contributing guidelines still link to the thoughtbot code review guidelines even though we already have our own. [ci skip] See merge request !4018
| * | Link to gitlab code review guide in contributing guidelinesKarlo Soriano2016-05-031-2/+1
| |/ | | | | | | | | | | | | I noticed that the contributing guidelines still link to the thoughtbot code review guidelines even though we already have our own. [ci skip]
* | Fix links to core team pageAchilleas Pipinellis2016-04-281-5/+4
| | | | | | | | [ci skip]
* | Users can use the feature proposal label inside the issuelabel_feature_proposalAchilleas Pipinellis2016-04-281-2/+3
|/ | | | [ci skip]
* Articles on proper commit messagescommit-message-contributionJacob Schatz2016-04-201-0/+1
|
* First pass at a Testing styleguideRobert Speicher2016-04-011-1/+1
| | | | [ci skip]
* Change capitalizationdoc/technical-debt-labelDouwe Maan2016-03-181-4/+4
|
* Fix typos and add a paragraph to urge people to mention the relevant MRAchilleas Pipinellis2016-03-181-10/+13
| | | | [ci skip]
* Add description of technical debt label in docsGrzegorz Bizon2016-03-171-0/+20
| | | | [ci skip]
* Add SCSS Lint, CSSComb config file, run SCSS Lint in GitLab CI, add ↵connorshea2016-03-141-0/+2
| | | | | | documentation for SCSS Style Guide. See !3069 for more information.
* No options please.Sytse Sijbrandij2016-03-041-1/+2
|
* Add a paragraph on "Implementing design & UI elements" in CONTRIBUTING.mdRémy Coutable2016-03-011-22/+46
| | | | | | | Also, link to this new paragraph in PROCESS.md and improved a bit this document. [ci skip]
* fix some linksnozo2016-02-141-13/+13
|
* Add notice about MR target for stable fixesSytse Sijbrandij2016-02-101-0/+1
|
* Rearrange some sections in CONTRIBUTING.mdAchilleas Pipinellis2016-02-081-45/+59
| | | | [ci skip]
* Add table of contents in CONTRIBUTING.mdAchilleas Pipinellis2016-02-081-0/+26
|
* Merge branch 'contributing-labels-stable-releases' into 'master' Robert Speicher2016-02-021-0/+12
|\ | | | | | | | | | | | | Updated contributing guide for stable releases [ci skip] See merge request !2638
View Lorry Controller Status