| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
| |
All this does is convert the version sections into headers. The list
items shouldn't really be indented by two spaces, but it makes no
difference to the rendering and this way we retain authorship history
for the actual changes.
Related to https://gitlab.com/gitlab-org/release-tools/merge_requests/29
|
| |
|
|
| |
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
| |\
| |
| |
| |
| |
| |
| | |
Add link to article on how to write reliable, asynchronous tests with Capybara
This article has been incredibly useful for all developers. Adding a link to it so more people can refer to it.
See merge request !6312
|
| | |
| |
| |
| | |
[ci skip]
|
| |/
|
|
| |
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
| |\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Added performance guidelines for new MRs
## What does this MR do?
This MR adds a set of guides that should be followed by merge request authors.
## Are there points in the code the reviewer needs to double check?
Spelling, grammar, etc
## Why was this MR needed?
There is no set of guidelines one should follow when submitting merge requests. This leads to developers at times disregarding performance. This in turn results in performance specialists having to clean up the mess, or production engineers being woken up in the middle of the night because the database is on fire.
## Does this MR meet the acceptance criteria?
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- Tests
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
cc @DouweM @rspeicher @pcarranza @dzaporozhets
See merge request !5905
|
| | |
| |
| |
| |
| |
| |
| | |
These guidelines cover the performance requirement for newly submitted
merge requests. These guidelines are put in to place to prevent merge
requests from negatively impacting GitLab performance as much as
possible.
|
| | |
| |
| |
| |
| |
| |
| |
| | |
Change to use a better title style
Add backticks to code segments
Spelling and Grammar
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Adjust bug template to adhere to standard bug report format
* https://developer.mozilla.org/en-US/docs/Mozilla/QA/Bug_writing_guidelines
* Guidelines use the following format
- Summary
- Steps to Reproduce
- Expected Behaviour
- Actual Behaviour
|
| | | |
|
| |/ |
|
| |\
| |
| |
| |
| | |
Add newlines styleguide for Ruby code
See merge request !5636
|
| | | |
|
| | |
| |
| |
| | |
[ci-skip]
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Update docs for CoffeeScript -> JavaScript.
## What does this MR do?
Removes some CoffeeScript docs and adds more JS ones
## Are there points in the code the reviewer needs to double check?
No
## Why was this MR needed?
To migrate some docs
## What are the relevant issue numbers?
#20098
## Screenshots (if relevant)
None
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !5433
|
| | |/ |
|
| |/ |
|
| | |
|
| | |
|
| |\
| |
| |
| |
| |
| |
| |
| |
| | |
Fix link to current design reference in the CONTRIBUTING guide
## What does this MR do?
It fixes an outdated link by replacing it with the up-to-date one.
See merge request !4439
|
| | |
| |
| |
| | |
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
| |/
|
| |
gitlab-org/gitlab-ce/issues/14905#note_12235996
|
| |
|
|
|
|
|
|
| |
Now that we autoscale runner, we don't need to optimize for their usage
anymore. Abusing of "ci skip", for instance for view changes can lead to
broken specs, so let's just not use it!
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
| |\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
feature proposal issue template in contributing guide
This adds a feature proposal template to the contribution guidelines for internal and external use.
Fixes #15448
cc @markpundsack @stanhu @dzaporozhets
See merge request !3967
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Link to GitLab code review guide in contributing guidelines
I noticed that the contributing guidelines still link to the thoughtbot
code review guidelines even though we already have our own.
[ci skip]
See merge request !4018
|
| | |/
| |
| |
| |
| |
| |
| | |
I noticed that the contributing guidelines still link to the thoughtbot
code review guidelines even though we already have our own.
[ci skip]
|
| | |
| |
| |
| | |
[ci skip]
|
| |/
|
|
| |
[ci skip]
|
| | |
|
| |
|
|
| |
[ci skip]
|
| | |
|
| |
|
|
| |
[ci skip]
|
| |
|
|
| |
[ci skip]
|
| |
|
|
|
|
| |
documentation for SCSS Style Guide.
See !3069 for more information.
|
| | |
|
| |
|
|
|
|
|
| |
Also, link to this new paragraph in PROCESS.md and improved a bit this
document.
[ci skip]
|
| | |
|
| | |
|
| |
|
|
| |
[ci skip]
|
| | |
|
| |\
| |
| |
| |
| |
| |
| | |
Updated contributing guide for stable releases
[ci skip]
See merge request !2638
|
| | |
| |
| |
| | |
Fixes #12784
|
| |\ \
| |/
|/|
| |
| |
| |
| | |
Add notes about the regression issues to CONTRIBUTING.md
[ci skip]
See merge request !2661
|
| | |
| |
| |
| | |
[ci skip]
|
| |/ |
|
| | |
|
| |
|
|
| |
[ci skip]
|
| | |
|
| | |
|
