summaryrefslogtreecommitdiff
path: root/app/assets/javascripts/gl_dropdown.js
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'master' into go-go-gadget-webpackMike Greiling2017-01-271-23/+19
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (389 commits) Document "No gems fetched from git repositories" policy [ci skip] Typos Small gramatical tweaks Typos Added PHP & NPM doc Use `:empty_project` where possible in request specs Add caching of droplab ajax requests Use `:empty_project` where possible in model specs Revert 3f17f29a Remove unused js response from refs controller Add MR id to changelog entry fixed small mini pipeline graph line glitch Prevent form to be submitted twice Fix Error 500 when repositories contain annotated tags pointing to blobs Fix /explore sorting (trending) Simplify wording in "adding an image" docs Remove "official merge window" from CONTRIBUTING.md [ci skip] Update repository check documentation Fixed flexbox and wrap issues Update two_factor_authentication.md ...
| * Merge branch '25312-search-input-cmd-click-issue' into 'master' Fatih Acet2017-01-251-7/+7
| |\ | | | | | | | | | | | | | | | | | | Prevent removal of input that is the parent dropdown element Closes #25312 See merge request !8397
| | * Prevent removing fields from dropdowns on input elementsSam Rose2017-01-251-7/+7
| | |
| * | resolve all x-spacing and no-spaced-x eslint violationsMike Greiling2017-01-181-3/+3
| | |
| * | resolve all padded-blocks eslint violationsMike Greiling2017-01-181-5/+1
| | |
| * | resolve all semi and no-extra-semi eslint violationsMike Greiling2017-01-181-8/+8
| | |
| * | resolve all no-plusplus eslint violationsMike Greiling2017-01-181-3/+3
| | |
* | | Merge branch 'master' into go-go-gadget-webpackPhil Hughes2017-01-171-1/+1
|\ \ \ | |/ /
| * | Fix dropdown filter input value after blur26616-fix-search-group-project-filtersEric Eastwood2017-01-161-1/+1
| |/
* | fix failing testsMike Greiling2017-01-101-1/+1
|/
* Check if selected object is valid before passing to calbackgl-dropdown-fixAlfredo Sumaran2016-12-191-3/+5
|
* Merge branch '24877-bulk-edit-only-keeps-common-labels-when-searching' into ↵Fatih Acet2016-12-151-17/+9
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'master' Improve bulk assignment This MR improves current implementation of Label dropdown when used for bulk assignment on issuable pages (/:namespace/:project/issues, /:namespace/:project/merge_requests) Previously this dropdown relied on `<input>` tags to get its active items and also to calculate items with indeterminate state. Relying on `<input>` tags is not enough when we want to set/get multiple states on a dropdown. For this case we want to get/set: - Marked items - Unmarked items that were initially marked - Unmarked items that were initially indeterminate - Items with indeterminate state. This MR makes the Label dropdown to save its own state as `data` so it will be easy to get and set whatever state we want no matter if the dropdown is filtering which is the issue that I initially wanted to solve as you can see in the following gif. **Before** ![2016-12-07_11.44.48](/uploads/cb697161b8b39cdee72fdbb95a531100/2016-12-07_11.44.48.gif) **After** ![2016-12-07_11.32.43](/uploads/338255a302de0dd1367474f33232d2a3/2016-12-07_11.32.43.gif) As you can see in the first gif the `bug` label is removed from the selected issues but the `enhancement` label should set but the `critical` should be kept. This is fixed on the next gif. Fixes #24877 See merge request !7765
| * Address feedback24877-bulk-edit-only-keeps-common-labels-when-searchingAlfredo Sumaran2016-12-141-1/+1
| |
| * Improve issuable's bulk assignment implementationAlfredo Sumaran2016-12-141-17/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the case when the user wants to add a label. The user has to use the dropdown’s filter input to look for a label and click it in order to see the bug. Step to reproduce - Select at least two issues, one label should be present in all issues, other label should be present in at least one. - On the label dropdown: Deselect label that is present in all issues, look for another issue using the filter input and click it. - Click on `Update issues` Before: Unmarked label were kept on selected issues. Now: Unmarked label is removed from selected issues
* | resolve all instances of no-undef eslint rule violationsclean-no-undefMike Greiling2016-12-141-2/+5
|/
* Updated members dropdownsPhil Hughes2016-12-071-0/+5
| | | | This ports some code over from EE to reduce conflicts
* Merge branch 'explicitly-disable-eslint-inline' into 'master' Alfredo Sumaran2016-11-161-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | explicitly disable eslint inline ## What does this MR do? Explicitly disables eslint inline. I.E. `/* eslint-disable */` => `/* eslint-disable max-len, no-new, ... */` I used the script from https://gitlab.com/lbennett/eslint-dsblr. ## Are there points in the code the reviewer needs to double check? ## Why was this MR needed? It will help refactor out eslint issues for older files. ## Screenshots (if relevant) ## Does this MR meet the acceptance criteria? - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? See merge request !7229
| * explicitly disable eslint inlineexplicitly-disable-eslint-inlineLuke "Jared" Bennett2016-11-151-1/+1
| |
* | Stopped multiple requests with dropdownsuser-dropdown-multiple-requests-fixPhil Hughes2016-11-161-1/+1
|/ | | | | | Opening the user dropdown currently sends 2 requests. This has been changed so only one is sent Closes #24131
* Do not allow text input in dropdown while loadingIdo Leibovich2016-10-281-3/+8
| | | | While loading, the entire dropdown is greyed out. However, The focus is on the text input, so user can input text. Move the focus event to after loading finished to fix this.
* Merge branch 'eslint' into 'master' Fatih Acet2016-10-261-0/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add ESLint ## What does this MR do? - create `package.json` - add ESLint dependencies to `package.json` - add JavaScript linting to CI - add Rake task `lint:javascript`as alias for `eslint` (which itself is an alias for `npm run eslint`) ## Are there points in the code the reviewer needs to double check? Probably not. ## Why was this MR needed? My hovercraft was full of eels. ## What are the relevant issue numbers? - https://gitlab.com/gitlab-org/gitlab-ce/issues/13224#note_12537431 - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5006#note_13255658 See merge request !5445
| * disable ESLint for all JavaScript fileswinniehell2016-10-261-0/+1
| |
* | Refactored less readable existance checksJack Davison2016-10-261-4/+12
| | | | | | | | | | | | CoffeeScript generated JavaScript contains some unreadable expressions. This refactoring addresses complex uses of the exestential operator that produced unreadable Javascript.
* | Merge branch 'issue-board-sidebar' into 'master' Fatih Acet2016-10-261-0/+11
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Issue board sidebar ## What does this MR do? Adds a sidebar when clicking an issue in the issue boards lists. This allows user to easily update other parts of the issue details without having to visit the issue itself. Same functionality as on issue page. When creating a new issue the sidebar automatically opens. ## Screenshots (if relevant) ![Screen_Shot_2016-10-07_at_13.10.16](/uploads/ad08785f407d8ac3fe9cb078868a7839/Screen_Shot_2016-10-07_at_13.10.16.png) ## What are the relevant issue numbers? Closes #21219 See merge request !6690
| * \ Merge branch 'master' into issue-board-sidebarPhil Hughes2016-10-191-44/+45
| |\ \ | | |/
| * | Fixed sidebar dropdowns to work with VuePhil Hughes2016-10-071-0/+11
| | |
* | | Escape quotes in gl_dropdown values to prevent exceptionsAirat Shigapov2016-10-261-0/+2
| |/ |/|
* | Fixed undefined keycode build errorgl-dropdown-render-perfPhil Hughes2016-10-141-3/+0
| |
* | Fixed keycode undefinedPhil Hughes2016-10-131-5/+1
| |
* | Changed trigger keyup to inputPhil Hughes2016-10-131-5/+3
| |
* | Fixed appending jQuery elementsPhil Hughes2016-10-131-0/+4
| |
* | Fixed rendering of HTML stringsPhil Hughes2016-10-131-1/+7
| |
* | Increased performance of GL dropdown renderItemPhil Hughes2016-10-131-32/+31
| | | | | | | | | | | | | | | | - Fixes an issue where `renderItem` is called several times even when not required - Increased performance when rendering dropdown items Closes #21110
* | Prevent conflict b/w search field and its dropdownBrennan Roberts2016-10-101-0/+1
|/ | | | | | | | | Stop the global search form's default "action" from fighting with dropdown items when using the keyboard to navigate the dropdown. `e.preventDefault()` is now called on the enter key when a dropdown item is already selected. Signed-off-by: Rémy Coutable <remy@rymai.me>
* Add position menu above ability to glDropdown.Fatih Acet2016-10-041-0/+13
|
* Added checks for field before field.length and removed unneeded fieldNamehotfix-gl-dropdown-field-undefinedLuke Bennett2016-09-201-12/+13
|
* Merge branch 'master' into ↵21961-issues-filtering-issue-with-labels-that-contain-spacesLuke "Jared" Bennett2016-09-191-11/+10
|\ | | | | | | | | | | '21961-issues-filtering-issue-with-labels-that-contain-spaces' # Conflicts: # app/assets/javascripts/gl_dropdown.js
| * Merge branch 'ee-919-backport-changes' into 'master' Jacob Schatz2016-09-151-11/+9
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Restore gl_dropdown.js changes Restores `fieldName` to allow only string values. `fieldName` was changed to accept function as a value in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/581 Since the approach changed in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/687 there's no need to accept function as value. Backport changes from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/687 EE Issue: https://gitlab.com/gitlab-org/gitlab-ee/issues/919 See merge request !6234
| | * fieldName can’t be a functionee-919-backport-changesAlfredo Sumaran2016-09-061-5/+2
| | | | | | | | | | | | Restore changes introduced in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/581
| | * Ensure we update dropdown label after selecting an optionAlfredo Sumaran2016-09-061-6/+7
| | |
* | | Replace single quotes with escaped single quotes and write spec to test ↵Luke Bennett2016-09-141-6/+7
|/ / | | | | | | | | | | | | | | multiple lable selection over a page load Added spec for removing label with space and single quote Fixed removing label with single quote
* | Restore comments lost when converting CoffeeScript to JavaScriptJared Deckard2016-09-081-0/+64
|/
* Fixed escaping issue with labels filterlabel-dropdown-encodePhil Hughes2016-08-311-1/+1
| | | | Closes #15552
* Merge branch '919-protected-branch-dropdown-all-users' into 'master' Fatih Acet2016-08-301-9/+7
|\ | | | | | | | | | | | | Ensure we update dropdown label after input has been added Backport changes from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/687 See merge request !5999
| * Ensure we update the label after input is added919-protected-branch-dropdown-all-usersAlfredo Sumaran2016-08-241-9/+7
| |
* | Moved `.option-hidden` to exist only in `SELECTABLE_CLASSES` as ↵21285-new-merge-request-source-and-target-branch-fields-filters-both-source-and-target-listLuke Bennett2016-08-241-3/+3
|/ | | | `NON_SELECTABLE_CLASSES` is used to re-show previously hidden elements
* Allow passing an index to selectRowAtIndexAlfredo Sumaran2016-08-231-2/+7
|
* Fixed enter key in search input not workingPhil Hughes2016-08-231-10/+18
| | | | Closes #20627
* Merge branch '581-ee-backport-branch-permissions' into 'master' Douwe Maan2016-08-201-8/+11
|\ | | | | | | | | | | | | Backport changes from gitlab-org/gitlab-ee!581 See merge request !5884
| * Use typeof instead of Underscore methodAlfredo Sumaran2016-08-191-2/+2
| |
View Lorry Controller Status