Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Exported JS classes as modulesph-even-more-es-modules | Phil Hughes | 2017-12-15 | 1 | -218/+220 |
| | |||||
* | Rename page-with-sidebar to layout-pagenew-nav-tech-debt | Annabel Dunstone Gray | 2017-12-08 | 1 | -4/+4 |
| | |||||
* | Backport changes from refactor sidebar weight block Vue and move to Issue Boardsce-1379-update-sidebar-weight-to-vue-and-add-to-boards | Eric Eastwood | 2017-12-04 | 1 | -3/+3 |
| | | | | See https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/3566 | ||||
* | Only trigger loadCheck on open toggle, not close. Update specs and add ↵ | Luke "Jared" Bennett | 2017-09-28 | 1 | -20/+23 |
| | | | | right_sidebar_spec test for additions | ||||
* | Conditionally call loadCheck if lazyLoader is present | Luke "Jared" Bennett | 2017-09-28 | 1 | -2/+1 |
| | |||||
* | Trigger load of lazy images when opening sidebar, or clicking 'more ↵ | Luke "Jared" Bennett | 2017-09-28 | 1 | -1/+3 |
| | | | | participants' | ||||
* | Clean up new navigation templates | Phil Hughes | 2017-09-06 | 1 | -2/+0 |
| | |||||
* | Move "Move to different project" to sidebar34261-move-move-to-sidebar | Eric Eastwood | 2017-09-03 | 1 | -2/+7 |
| | | | | Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/34261 | ||||
* | Resolve "Specific Async Script Loading by using a Page Variable" | Tim Zallmann | 2017-08-03 | 1 | -0/+1 |
| | |||||
* | Make setSidebarHeight more efficient with SidebarHeightManager.set-sidebar-height | Bryce Johnson | 2017-06-30 | 1 | -22/+3 |
| | |||||
* | Fix scroll flicker34407-flickering-scroll-v1 | Eric Eastwood | 2017-06-28 | 1 | -3/+5 |
| | | | | | | | | See https://gitlab.com/gitlab-org/gitlab-ce/issues/34407 - Revert https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12399 - Update https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12299 throttle/debounce to happen immediately and cleanup | ||||
* | Remove layout nav from scroll calculationfix-sidebar-scroll-jump | Annabel Dunstone Gray | 2017-06-22 | 1 | -3/+1 |
| | |||||
* | Fixes scrolling + improves Performance through assigning found $ elements to ↵ | Tim Zallmann | 2017-06-20 | 1 | -6/+15 |
| | | | | variables | ||||
* | remove bind polyfill from right_sidebar.js | Mike Greiling | 2017-05-08 | 1 | -3/+1 |
| | |||||
* | Merge branch '30063-builds-sidebar-stutter' into 'master' | Filipa Lacerda | 2017-03-30 | 1 | -1/+1 |
|\ | | | | | | | | | | | | | Add subnav height to sidebar scroll calculation Closes #30063 See merge request !10262 | ||||
| * | Add subnav height to sidebar scroll calculation | Annabel Dunstone Gray | 2017-03-28 | 1 | -1/+1 |
| | | |||||
* | | Added specs for collapsed sidebar | Phil Hughes | 2017-03-27 | 1 | -9/+9 |
| | | |||||
* | | Updated todos sidebar icon | Phil Hughes | 2017-03-24 | 1 | -19/+30 |
| | | | | | | | | | | Refactored slightly so that the same logic is shared between both the expanded & the collapsed. | ||||
* | | adds todo functionality to closed issuable sidebar and changes todo bell ↵ | dimitrieh | 2017-03-24 | 1 | -2/+2 |
|/ | | | | icon to check-square | ||||
* | Switch to check scrollTop of window | Annabel Dunstone Gray | 2017-03-23 | 1 | -1/+1 |
| | |||||
* | remove Cookies class from global space | Mike Greiling | 2017-03-22 | 1 | -1/+2 |
| | |||||
* | replace implicit this == window with explicit binding | Mike Greiling | 2017-02-17 | 1 | -1/+1 |
| | |||||
* | Cache js selectors; fix css26200-convert-sidebar-to-dropdown | Annabel Dunstone Gray | 2017-02-16 | 1 | -5/+9 |
| | |||||
* | Move necessary sidebar code to right_sidebar.js; delete sidebar.js | Annabel Dunstone Gray | 2017-02-15 | 1 | -0/+12 |
| | |||||
* | resolve all x-spacing and no-spaced-x eslint violations | Mike Greiling | 2017-01-18 | 1 | -2/+2 |
| | |||||
* | resolve all padded-blocks eslint violations | Mike Greiling | 2017-01-18 | 1 | -3/+1 |
| | |||||
* | resolve all semi and no-extra-semi eslint violations | Mike Greiling | 2017-01-18 | 1 | -2/+2 |
| | |||||
* | resolve all instances of no-undef eslint rule violationsclean-no-undef | Mike Greiling | 2016-12-14 | 1 | -1/+3 |
| | |||||
* | explicitly disable eslint inlineexplicitly-disable-eslint-inline | Luke "Jared" Bennett | 2016-11-15 | 1 | -1/+1 |
| | |||||
* | Merge branch 'add-todo-toggle-event' into 'master' remove-tooltip-text-truncation-from-pipeline-graph-build-node-tooltips | Fatih Acet | 2016-10-27 | 1 | -8/+3 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add todo toggle event ## What does this MR do? Adds a custom jQuery event `todo:toggle` to detect when a new todo is added so that the respective todo counters (header navigation and sidebar) can update as needed ## Are there points in the code the reviewer needs to double check? * I wasn't sure whether each `spec` should be modularized based on the html templates or whether they should be separated based on function. There are some crossovers between the `dashboard_spec` and the `header_spec`. * The naming conventions for `sidebar` and `right_sidebar` were a little confusing since they were named the opposite in their `specs`. I made a few assumptions and named a few files based on what I thought they should be named. I'd be happy to change it to something else though :smile: ## Why was this MR needed? This resolves an existing issue where the todo count on the sidebar would not update (until refresh) and refactors the existing methods that are used to update the todo counters (header navigation and sidebar) ## What are the relevant issue numbers? Closes #20140 ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !5724 | ||||
| * | Add todo toggle event | Clement Ho | 2016-10-26 | 1 | -8/+3 |
| | | |||||
* | | Merge branch 'eslint' into 'master' | Fatih Acet | 2016-10-26 | 1 | -0/+1 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add ESLint ## What does this MR do? - create `package.json` - add ESLint dependencies to `package.json` - add JavaScript linting to CI - add Rake task `lint:javascript`as alias for `eslint` (which itself is an alias for `npm run eslint`) ## Are there points in the code the reviewer needs to double check? Probably not. ## Why was this MR needed? My hovercraft was full of eels. ## What are the relevant issue numbers? - https://gitlab.com/gitlab-org/gitlab-ce/issues/13224#note_12537431 - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5006#note_13255658 See merge request !5445 | ||||
| * | | disable ESLint for all JavaScript files | winniehell | 2016-10-26 | 1 | -0/+1 |
| | | | |||||
* | | | Merge branch 'master' into issue-board-sidebarissue-board-sidebar | Phil Hughes | 2016-10-26 | 1 | -3/+1 |
|\ \ \ | |/ / | |||||
| * | | remove manual Cookie.set "path" option in favor of global setting | Mike Greiling | 2016-10-24 | 1 | -3/+1 |
| | | | |||||
| * | | replace jquery.cookie vendor script with js.cookie | Mike Greiling | 2016-10-24 | 1 | -1/+1 |
| |/ | |||||
* | | Show clicked issue data in the sidebar | Phil Hughes | 2016-10-07 | 1 | -1/+10 |
|/ | |||||
* | use gitlab global root url as canonical base url for all javascript set ↵ | Mike Greiling | 2016-08-24 | 1 | -1/+1 |
| | | | | cookies (closes #20435) | ||||
* | ES6ify all the things! | Fatih Acet | 2016-07-24 | 1 | -0/+201 |