Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Filter merge requests by target branch | Hiroyuki Sato | 2019-03-09 | 1 | -1/+8 |
| | |||||
* | Make getting a user by the username case insensitive | William George | 2018-10-18 | 1 | -1/+1 |
| | |||||
* | Enable frozen string in app/controllers/**/*.rbrepo-forks/gitlab-ce-frozen-string-app-controller | gfyoung | 2018-09-18 | 1 | -0/+2 |
| | | | | | | | | | | | | Enables frozen string for the following: * app/controllers/*.rb * app/controllers/admin/**/*.rb * app/controllers/boards/**/*.rb * app/controllers/ci/**/*.rb * app/controllers/concerns/**/*.rb Partially addresses #47424. | ||||
* | Refactor AutocompleteControllerdefine-abstraction-levels | Yorick Peterse | 2018-08-20 | 1 | -50/+22 |
| | | | | | | | | | | | | | | | | | | | | | | | This refactors the AutocompleteController according to the guidelines and boundaries discussed in https://gitlab.com/gitlab-org/gitlab-ce/issues/49653. Specifically, ActiveRecord logic is moved to different finders, which are then used in the controller. View logic in turn is moved to presenters, instead of directly using ActiveRecord's "to_json" method. The finder MoveToProjectFinder is also adjusted according to the abstraction guidelines and boundaries, resulting in a much more simple finder. By using finders (and other abstractions) more actively, we can push a lot of logic out of the controller. We also remove the need for various "before_action" hooks, though this could be achieved without using finders as well. The various finders related to AutcompleteController have also been moved into a namespace. This removes the need for calling everything "AutocompleteSmurfFinder", instead you can use "Autocomplete::SmurfFinder". | ||||
* | Use UserSerializer instead of `User.to_json` | Robert Speicher | 2017-12-19 | 1 | -2/+2 |
| | |||||
* | Adds Rubocop rule for line break after guard clause | Jacopo | 2017-11-16 | 1 | -0/+2 |
| | | | | Adds a rubocop rule (with autocorrect) to ensure line break after guard clauses. | ||||
* | move `find_users` method into finder and add `load_group` method | Maxim Rydkin | 2017-09-10 | 1 | -19/+7 |
| | |||||
* | rename yet_another_users_finder into autocomplete_users_finder | Maxim Rydkin | 2017-09-10 | 1 | -1/+1 |
| | |||||
* | extract finder and add first test | Maxim Rydkin | 2017-09-10 | 1 | -22/+1 |
| | |||||
* | Move "Move to different project" to sidebar34261-move-move-to-sidebar | Eric Eastwood | 2017-09-03 | 1 | -6/+0 |
| | | | | Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/34261 | ||||
* | Fix MySQL failure for emoji autocomplete | Sean McGivern | 2017-08-30 | 1 | -1/+1 |
| | | | | | Postgres lets you treat `count` as another alias for `COUNT(*)` apparently, even if that's not the actual alias used. | ||||
* | Add filter by my reaction | Hiroyuki Sato | 2017-08-30 | 1 | -1/+17 |
| | |||||
* | Fixes the user order being overriden in the autocomplete controllerfix-exact-matches-of-username-and-email-on-top-of-the-user-search | Tiago Botelho | 2017-07-14 | 1 | -2/+2 |
| | |||||
* | Merge branch 'dz-restrict-autocomplete' into 'security-9-1' | DJ Mountney | 2017-06-08 | 1 | -1/+1 |
| | | | | | | Allow users autocomplete by author_id only for authenticated users See merge request !2100 | ||||
* | Add per page to user autocomplete32977-user-autocomplete-per_page-does-not-work | Clement Ho | 2017-05-26 | 1 | -1/+1 |
| | |||||
* | Enable the Style/TrailingCommaInLiteral cop | Rémy Coutable | 2017-05-10 | 1 | -1/+1 |
| | | | | | | Use the EnforcedStyleForMultiline: no_comma option. Signed-off-by: Rémy Coutable <remy@rymai.me> | ||||
* | Fix autocomplete in EE when permissions are sent29316-can-t-select-a-mirror-user | Sean McGivern | 2017-03-10 | 1 | -2/+1 |
| | | | | | | | | | | In EE, `@users` can be an array at the point where we remove the current user, because it can do a permissions check on the users for project mirroring. Fix this in CE by only using array methods, not AR methods. We can't use `delete` because that uses `Object#equal?`, which isn't true in this case. | ||||
* | Don't call `#uniq` on a relation | Sean McGivern | 2017-01-27 | 1 | -3/+2 |
| | | | | | | | | | When there was no project, no search, and no current user or author param, the AutocompleteController would call `#uniq!` on a relation instead of an array. This performed the less-efficient `SELECT DISTINCT` when it wasn't even needed (because the query wouldn't return duplicates anyway - duplicates were only added by putting a user on top of the list). | ||||
* | Shows current user on top of filtered dropdown listcurrent-user-filter-top | Phil Hughes | 2017-01-17 | 1 | -1/+1 |
| | |||||
* | Do not raise error in AutocompleteController#users when not authorized | Semyon Pupkov | 2016-11-30 | 1 | -1/+1 |
| | | | | https://gitlab.com/gitlab-org/gitlab-ce/issues/25031 | ||||
* | Improved Ruby code in autocomplete user search | Phil Hughes | 2016-11-18 | 1 | -1/+1 |
| | |||||
* | Include author in assignee dropdown searchassignee-dropdown-autocomplete | Phil Hughes | 2016-11-17 | 1 | -1/+7 |
| | | | | | | When searching for the author in the assignee dropdown it now correctly returns the user Closes #22905 | ||||
* | Fix: Todos Filter Shows All Users22588-todos-filter-shows-all-users | Valery Sizov | 2016-11-04 | 1 | -1/+5 |
| | |||||
* | Move to project dropdown with infinite scroll for better performance17932-move-to-project-dropdown-improve | Paco Guzman | 2016-08-17 | 1 | -8/+6 |
| | | | | | | | | Use just SQL to check is a user can admin_issue on a project Tradeoff - we duplicate how we check admin_issue in a SQL relation in the Ability class | ||||
* | Fix a missed `before_action` for `AutocompleteController`. | Timothy Andrew | 2016-08-16 | 1 | -0/+1 |
| | | | | | | - `#find_users` depends on a project being loaded. - Missed adding this in 2193ae222b3337f03c18dd7d27408a1b138c2f92 | ||||
* | Backport `AutocompleteController#load_project` from EE!581. | Timothy Andrew | 2016-08-16 | 1 | -5/+12 |
| | | | | | - This is an optimization that was made in !581, and it needs to be backported to CE to avoid merge conflicts in the future. | ||||
* | Allow skipping users in autocompleteallow-skipping-users-in-autocomplete | Sean McGivern | 2016-07-27 | 1 | -0/+1 |
| | | | | | | Pass an array of user IDs in the `skip_users` param to have them excluded from the results (unless they are explicitly included through the `current_user` or `author_id` params). | ||||
* | Fixed issue with move dropdown not being searchableproject-move-dropdown-search | Phil Hughes | 2016-06-15 | 1 | -0/+1 |
| | | | | Closes #18634 | ||||
* | Updated Rubymove-project-dropdown-async | Phil Hughes | 2016-05-25 | 1 | -2/+5 |
| | |||||
* | Correctly sends project ID | Phil Hughes | 2016-05-20 | 1 | -1/+1 |
| | |||||
* | Loads move issue dropdown async | Phil Hughes | 2016-05-16 | 1 | -0/+15 |
| | | | | Closes #16563 | ||||
* | Merge branch 'master' into assign-to-issuable-opener | Zeger-Jan van de Weg | 2016-04-15 | 1 | -2/+3 |
|\ | |||||
* \ | Merge branch 'master' into assign-to-issuable-opener | Zeger-Jan van de Weg | 2016-03-29 | 1 | -1/+1 |
|\ \ | |/ | |||||
| * | Use the configured Kaminari "per page" defaultrs-use-kaminari-default | Robert Speicher | 2016-03-19 | 1 | -1/+1 |
| | | |||||
* | | Revert authors ability to assign anyone | Zeger-Jan van de Weg | 2016-02-22 | 1 | -1/+1 |
| | | |||||
* | | Fix loading data when no author_id is passed | Zeger-Jan van de Weg | 2016-02-22 | 1 | -1/+1 |
| | | |||||
* | | Issuable can be assigned to author | Zeger-Jan van de Weg | 2016-02-22 | 1 | -1/+7 |
|/ | | | | | | | Closes #9014 The only difference with #9014 is that I thoughed the author should also be able to assign the issue. If this is unwanted behavior Ill revert it. | ||||
* | Update autocomplete_controller to be more readable | Felipe Orlando | 2015-11-22 | 1 | -1/+1 |
| | |||||
* | Reduce method complexity in AutocompleteControlleree-flog | Douwe Maan | 2015-11-20 | 1 | -27/+22 |
| | |||||
* | Sorted autocomplete users list by name | Allister Antosik | 2015-09-15 | 1 | -0/+1 |
| | |||||
* | Fix bug preventing invite by e-mail | Stan Hu | 2015-08-21 | 1 | -2/+8 |
| | | | | | | This was broken in 70f5291808 as a result of introducing the ability to filter by current user. Closes #2320 | ||||
* | Always add current user to autocomplete controller to support filter by "Me" | Stan Hu | 2015-08-06 | 1 | -0/+2 |
| | | | | Partial fix #2202 | ||||
* | Better handle unknown projects and groups for autocomplete | Stan Hu | 2015-07-11 | 1 | -14/+23 |
| | |||||
* | Fix user autocomplete for unauthenticated users accessing public projects | Stan Hu | 2015-07-10 | 1 | -1/+5 |
| | | | | Closes #1955 | ||||
* | Add autocomplete controller | Dmitriy Zaporozhets | 2015-03-26 | 1 | -0/+30 |