Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Add latest changes from gitlab-org/gitlab@14-5-stable-eev14.5.0-rc42 | GitLab Bot | 2021-11-18 | 3 | -3/+3 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@14-4-stable-eev14.4.0-rc42 | GitLab Bot | 2021-10-20 | 1 | -1/+1 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@14-3-stable-eev14.3.0-rc42 | GitLab Bot | 2021-09-20 | 1 | -1/+1 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@14-2-stable-eev14.2.0-rc42 | GitLab Bot | 2021-08-19 | 1 | -1/+1 |
| | |||||
* | Add latest changes from gitlab-org/security/gitlab@14-1-stable-ee | GitLab Bot | 2021-08-02 | 1 | -0/+2 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@14-1-stable-eev14.1.0-rc42 | GitLab Bot | 2021-07-20 | 2 | -2/+1 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@14-0-stable-eev14.0.0-rc42 | GitLab Bot | 2021-06-16 | 1 | -1/+1 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@13-12-stable-eev13.12.0-rc42 | GitLab Bot | 2021-05-19 | 1 | -1/+1 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@13-10-stable-eev13.10.0-rc40 | GitLab Bot | 2021-03-16 | 2 | -1/+2 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@13-8-stable-eev13.8.0-rc42 | Robert Speicher | 2021-01-20 | 1 | -0/+1 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@13-7-stable-eev13.7.0-rc42 | GitLab Bot | 2020-12-17 | 1 | -1/+1 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@13-5-stable-eev13.5.0-rc42 | GitLab Bot | 2020-10-21 | 6 | -2/+14 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@13-4-stable-ee | GitLab Bot | 2020-09-19 | 1 | -3/+4 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@13-3-stable-ee | GitLab Bot | 2020-08-20 | 2 | -3/+1 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@13-2-stable-ee | GitLab Bot | 2020-07-20 | 3 | -2/+7 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@13-1-stable-ee | GitLab Bot | 2020-06-18 | 2 | -28/+14 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@13-0-stable-ee | GitLab Bot | 2020-05-20 | 1 | -2/+4 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@12-10-stable-ee | GitLab Bot | 2020-04-20 | 1 | -7/+9 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2020-03-11 | 1 | -2/+3 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2020-03-10 | 1 | -3/+2 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2020-02-05 | 1 | -0/+4 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2020-02-05 | 1 | -1/+6 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2020-01-27 | 1 | -0/+2 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2019-11-17 | 1 | -2/+2 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2019-09-18 | 1 | -2/+2 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2019-09-18 | 3 | -3/+3 |
| | |||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2019-09-13 | 1 | -0/+2 |
| | |||||
* | Add controller concern for paginated collections65988-optimize-snippet-listings | Markus Koller | 2019-09-10 | 2 | -22/+13 |
| | | | | | | We had similar code in a few places to redirect to the last page if the given page number is out of range. This unifies the handling in a new controller concern and adds usage of it in all snippet listings. | ||||
* | Optimize queries for snippet listings | Markus Koller | 2019-09-10 | 1 | -6/+8 |
| | | | | | - Avoid N+1 queries for authors and comment counts - Avoid an additional snippet existence query | ||||
* | Remove N+1 SQL query loading project feature in dashboardsh-project-feature-nplus-one | Stan Hu | 2019-08-23 | 1 | -0/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Projects that have a pipeline may need to check whether the user has permission to read the build (`can?(current_user, :read_build, project)`), which requires checking the `project_features` table. This would cause an N+1 SQL query for each project. This change also has a beneficial side effect that may avoid a race condition. When a user deletes a project, the project is queued for deletion and the user is redirected back to the dashboard page. However, the following may happen: 1. The dashboard page may load this deleted project in the list of 20 projects. 2. The view will load the project pipeline status from the cache and attempt to show each project. 3. When the view encounters the deleted project, it calls `can?(current_user, :read_build, project)` to determine whether to display the pipeline status. 4. Sidekiq deletes the project from the database. 5. However, since the deleted project is still loaded in memory, it will attempt to call `project.project_feature.access_level`. 6. Since `project_feature` was not eager loaded, a lazy `SELECT` call is made to the database. 7. This `SELECT` call returns nothing, and the user sees a 500 error. By eager loading `project_feature`, we can ensure that we have a consistent view and avoid records from being deleted later. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66482 | ||||
* | Add SortingPreference concern | George Koltsov | 2019-08-21 | 1 | -6/+16 |
| | | | | | | | Sorting preference functionality has been extracted from `IssuableCollections` to a new `SortingPreference` concern in order to reuse this functionality in projects (and groups in the future). | ||||
* | Change 'Todo' to 'To Do' | Christie Lenneville | 2019-07-04 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | Currently, we label items to be done as "Todo." This is grammatically incorrect and (therefore) confusing—especially to our Spanish-speaking users for whom "todo" has a specific and unrelated meaning. We should use "To Do" and always use it as singular (not "To Dos"). Updates to wording in a few places per MR (ee) discussion Updating locale/gitlab.pot Updates to wording in a few places per MR (ee) discussion Updating locale/gitlab.pot | ||||
* | Set default project sort method prior to initial sort on page loading | David Palubin | 2019-07-04 | 1 | -1/+1 |
| | |||||
* | Add A/B testing support to onboarding82-add-new-onboarding-to-flipper-a-b-testing | Ash McKenzie | 2019-06-28 | 1 | -0/+1 |
| | | | | | Check if we're gitlab.com and the :user_onboarding feature flag is enabled. | ||||
* | Rename Todos.with_api_entity_associations to with_entity_associationssh-optimize-todos-controller | Stan Hu | 2019-06-24 | 1 | -1/+1 |
| | | | | | Since this scope is used in both the controller and the API, we rename it to make it clear that it's used for both. | ||||
* | Eliminate N+1 queries in Dashboard::TodosController | Stan Hu | 2019-06-24 | 1 | -0/+1 |
| | | | | | | | This appears to bring down the number of SQL queries on GitLab.com for my Todos page from 672 to 100. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/43042 | ||||
* | Add render_projects method to controller | Martin Wortschack | 2019-06-05 | 1 | -6/+13 |
| | | | | - Render EE specific partial if exists | ||||
* | Update comments about N + 1 Gitaly calls | Zeger-Jan van de Weg | 2019-04-09 | 1 | -2/+1 |
| | | | | | To make sure all known issues are linked to the correct epic, I've gone through the code base, and updated the comments where required. | ||||
* | Externalize strings in projects controllers | Martin Wortschack | 2019-03-27 | 1 | -2/+2 |
| | | | | | | | - concerns - dashboard - groups - import | ||||
* | Fix undefined variable error on json project views | Alejandro Rodríguez | 2019-03-18 | 1 | -2/+2 |
| | | | | | | This mistake seems to have always been there, but it only resulted in errors on the `/explore*.json` since they were the one that _actually_ relied on the local variables. | ||||
* | Allow Gitaly N+1 calls for RootController#index | Thong Kuah | 2019-02-28 | 1 | -1/+7 |
| | | | | | | Allow developers to load GitLab root page locally without errors. Since we know this issue for a while now, no point letting the exception be triggered constantly. | ||||
* | Exclude public group milestones from counts | Heinrich Lee Yu | 2019-02-14 | 1 | -3/+1 |
| | | | | Only count milestones in groups that the user is a member of | ||||
* | Update last_activity_on for Users on some main GET endpoints | Rubén Dávila | 2019-02-05 | 1 | -0/+1 |
| | | | | | | | In order to have an accurate date about the last activity of a User we need to update the last_activity_on field when the User is visiting some basic pages of GitLab like pages related to Dashboards, Projects, Issues and Merge Requests | ||||
* | Adds milestone search | Jacopo | 2019-01-24 | 1 | -1/+1 |
| | | | | | | | Adds to search ILIKE search for milestones title in: - Milestones dashboard - Group milestones page - Project milestones page | ||||
* | Move ProjectsFinder into the controller | George Tsiolis | 2019-01-15 | 1 | -0/+3 |
| | |||||
* | Eager-load relations for Dashboard::ProjectsController | Gabriel Mazetto | 2018-12-10 | 1 | -1/+1 |
| | | | | This removes remaining N+1 queries | ||||
* | Merge branch 'security-fix-pat-web-access' into 'master' | Cindy Pallares | 2018-11-28 | 1 | -0/+1 |
| | | | | | [master] Resolve "Personal access token with only `read_user` scope can be used to authenticate any web request" See merge request gitlab/gitlabhq!2583 | ||||
* | Merge branch 'security-private-group' into 'master' | Cindy Pallares | 2018-11-28 | 1 | -0/+10 |
| | | | | | [master] Fixed read private group names See merge request gitlab/gitlabhq!2589 | ||||
* | Update MR based on Sean's feedbackrz_fix_milestone_count | Eagllus | 2018-10-26 | 1 | -1/+1 |
| | |||||
* | Update code according comment recommendations | Eagllus | 2018-10-16 | 2 | -6/+6 |
| |