Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Eager-load relations for Dashboard::ProjectsController | Gabriel Mazetto | 2018-12-10 | 1 | -1/+1 |
| | | | | This removes remaining N+1 queries | ||||
* | Merge branch 'security-fix-pat-web-access' into 'master' | Cindy Pallares | 2018-11-28 | 1 | -0/+1 |
| | | | | | [master] Resolve "Personal access token with only `read_user` scope can be used to authenticate any web request" See merge request gitlab/gitlabhq!2583 | ||||
* | Merge branch 'security-private-group' into 'master' | Cindy Pallares | 2018-11-28 | 1 | -0/+10 |
| | | | | | [master] Fixed read private group names See merge request gitlab/gitlabhq!2589 | ||||
* | Update MR based on Sean's feedbackrz_fix_milestone_count | Eagllus | 2018-10-26 | 1 | -1/+1 |
| | |||||
* | Update code according comment recommendations | Eagllus | 2018-10-16 | 2 | -6/+6 |
| | |||||
* | Fixing count on Milestones | Ronald van Zon | 2018-10-04 | 2 | -1/+6 |
| | | | | | By adding groups to milestones we can now include them in the count of Open and Closed. | ||||
* | Enable more frozen string in app/controllers/ | gfyoung | 2018-09-23 | 7 | -0/+14 |
| | | | | | | | | | | | | | | | | Enables frozen string for the following: * app/controllers/dashboard/**/*.rb * app/controllers/explore/**/*.rb * app/controllers/google_api/**/*.rb * app/controllers/groups/**/*.rb * app/controllers/import/**/*.rb * app/controllers/instance_statistics/**/*.rb * app/controllers/ldap/**/*.rb * app/controllers/oauth/**/*.rb * app/controllers/profiles/**/*.rb Partially addresses #47424. | ||||
* | Filter group milestones based on user membership | Chantal Rollison | 2018-09-13 | 1 | -1/+1 |
| | |||||
* | Disable existing offenses for the CodeReuse cops | Yorick Peterse | 2018-09-11 | 2 | -0/+6 |
| | | | | | This whitelists all existing offenses for the various CodeReuse cops, of which most are triggered by the CodeReuse/ActiveRecord cop. | ||||
* | Merge branch 'group-todos' into 'master' | Sean McGivern | 2018-08-07 | 1 | -1/+1 |
|\ | | | | | | | | | Group todos See merge request gitlab-org/gitlab-ce!20675 | ||||
| * | Revert "Revert "Merge branch 'ee-5481-epic-todos' into 'master'"" | Jarka Kadlecová | 2018-08-02 | 1 | -1/+1 |
| | | | | | | | | This reverts commit 8717c7dad9b5a8fa21ec9a652c54718a6b4c2175. | ||||
* | | Add group milestones to dashboard milestone page | Chantal Rollison | 2018-08-03 | 1 | -1/+12 |
|/ | |||||
* | Revert "Merge branch 'ee-5481-epic-todos' into 'master'" | Jarka Kadlecová | 2018-07-11 | 1 | -1/+1 |
| | | | | | This reverts commit 4d9a3f42f1fd3be21555e19872b7121cca65015e, reversing changes made to ecf9c145f6e4d170cd059df88743393d9e63c489. | ||||
* | Fix User role displayed on projects dashboard | Francisco Javier López | 2018-07-06 | 1 | -2/+3 |
| | |||||
* | [backend] Addressed review comments | Jan Provaznik | 2018-07-03 | 1 | -1/+1 |
| | | | | | | | * Group filtering now includes also issues/MRs from subgroups/subprojects * fixed due_date * Also DRYed todo controller specs | ||||
* | [Rails5] Add `safe_params` helper | blackst0ne | 2018-04-08 | 1 | -1/+1 |
| | | | | | | | | | | Rails 5.0 requires to explicitly permit attributes when building a URL using current `params` object. The `safe_params` helper allows developers to just call `safe_params.merge(...)` instead of manually adding `permit` to every call. https://github.com/rails/rails/pull/20868 | ||||
* | Port `read_cross_project` ability from EE | Bob Van Landuyt | 2018-02-22 | 4 | -0/+9 |
| | |||||
* | Resolve "Display member role per project" | Mike Greiling | 2017-12-07 | 1 | -4/+7 |
| | |||||
* | Fix access to the final page of todos | Sean McGivern | 2017-11-09 | 1 | -1/+1 |
| | | | | | | | | | The todos page limit is 20, and both that and a user's pending todo count are integers. Using integer division means that the result's floor will be taken, defeating the point of the later call to `#ceil`. So we need to convert one side of the division to a float first, otherwise the last page won't be treated as available. | ||||
* | Resolve "DashboardController#activity.json is slow due to SQL" | Francisco Javier López | 2017-11-06 | 1 | -0/+2 |
| | |||||
* | Merge branch 'master' into bvl-group-trees | Bob Van Landuyt | 2017-10-10 | 1 | -4/+26 |
|\ | |||||
| * | Fixed default group sort optiongroup-sort-dropdown-blank | Phil Hughes | 2017-10-06 | 1 | -1/+1 |
| | | | | | | | | Closes #38808 | ||||
| * | Save a query on the todos index pagesave-a-query-on-todos-with-no-filters | Sean McGivern | 2017-10-04 | 1 | -4/+26 |
| | | | | | | | | | | | | When there are no filters, we can get the total todos count from the cached count on the user object, instead of performing a DB query. This query takes about 80ms for me on GitLab.com. | ||||
* | | Reuse the groups tree for explore and dashboard. | Bob Van Landuyt | 2017-10-04 | 1 | -16/+4 |
| | | |||||
* | | Use the default sort set by the `Sortable` concern | Bob Van Landuyt | 2017-10-04 | 1 | -3/+1 |
| | | |||||
* | | Only show root groups on the dashboard | Bob Van Landuyt | 2017-10-04 | 1 | -13/+3 |
| | | | | | | | | The children are lazy-loaded when expanding | ||||
* | | Use same response-body in groups-dashboard as we do for group-home | Bob Van Landuyt | 2017-10-04 | 1 | -5/+4 |
|/ | |||||
* | Eager load namespace owners for project dashboardsdashboards-projects-controller | Yorick Peterse | 2017-09-11 | 1 | -1/+1 |
| | | | | | This solves an N+1 query problem where we'd run multiple queries when getting the namespace owners of the displayed projects. | ||||
* | Removes default scope from sortable23079-remove-default-scope-in-sortable | Tiago Botelho | 2017-09-07 | 1 | -1/+3 |
| | |||||
* | Use a specialized class for querying events | Yorick Peterse | 2017-08-10 | 1 | -3/+5 |
| | | | | | | | | | | | | | | | This changes various controllers to use the new EventCollection class for retrieving events. This class uses a JOIN LATERAL query on PostgreSQL to retrieve queries in a more efficient way, while falling back to a simpler / less efficient query for MySQL. The EventCollection class also includes a limit on the number of events to display to prevent malicious users from cycling through all events, as doing so could put a lot of pressure on the database. JOIN LATERAL is only supported on PostgreSQL starting with version 9.3.0 and as such this optimisation is only used when using PostgreSQL 9.3 or newer. | ||||
* | Eager load project creators for project dashboardsdashboard-projects-controller-query-performance | Yorick Peterse | 2017-08-07 | 1 | -2/+4 |
| | | | | | This solves an N+1 query problem where for every project we'd query the creator separately just to figure out what avatar to display. | ||||
* | Avoid plucking Todo ids and use sub-queries instead | Toon Claes | 2017-08-03 | 1 | -2/+2 |
| | | | | | | | | TodoService should not call `.select(&:id)` on todos, because this is bad performance. So instead use sub-queries, which will result in a single SQL query to the database. https://docs.gitlab.com/ee/development/sql.html#plucking-ids | ||||
* | Merge branch '33303-404-for-unauthorized-project' into 'security-9-3' | Sean McGivern | 2017-07-19 | 1 | -0/+10 |
| | | | | | [9.3 security fix] Renders 404 if given project is not readable by the user on Todos dashboard See merge request !2118 | ||||
* | Fix dashboard labels dropdown | Nick Thomas | 2017-07-07 | 1 | -2/+7 |
| | |||||
* | Enable Style/DotPosition Rubocop :cop: | Grzegorz Bizon | 2017-06-21 | 1 | -4/+4 |
| | |||||
* | Merge branch 'fix/33584-atom-layout' into 'master' | Rémy Coutable | 2017-06-13 | 1 | -1/+1 |
|\ | | | | | | | | | Refactor atom builder by using a layout See merge request !12114 | ||||
| * | Refactor atom builder by using xml.atom layout | Tieu-Philippe KHIM | 2017-06-12 | 1 | -1/+1 |
| | | |||||
* | | Test todos_count_format helper at the correct level to improve speedrs-simplify-todo-count-spec | Robert Speicher | 2017-06-09 | 1 | -5/+0 |
|/ | | | | | Instead of an integration test that creates 101 Todo records to test a simple view helper, just unit test the helper. | ||||
* | Merge branch 'dashboard-milestone-tabs-loading-async' into 'master' | Sean McGivern | 2017-06-09 | 1 | -1/+3 |
|\ | | | | | | | | | | | | | Fixed dashboard milestone tabs not loading Closes #33477 See merge request !12023 | ||||
| * | Fixed dashboard milestone tabs not loadingdashboard-milestone-tabs-loading-async | Phil Hughes | 2017-06-09 | 1 | -1/+3 |
| | | | | | | | | Closes #33477 | ||||
* | | Use group and project finders instead of direct ActiveRecord relations | Douwe Maan | 2017-06-07 | 1 | -10/+11 |
| | | |||||
* | | Merge branch 'master' into 25426-group-dashboard-ui | Alfredo Sumaran | 2017-06-07 | 1 | -2/+6 |
|\ \ | |/ | |||||
| * | Add a rubocop rule to check if a method 'redirect_to' is used without ↵31840-add-a-rubocop-that-forbids-redirect_to-inside-a-controller-destroy-action-without-an-explicit-status | blackst0ne | 2017-06-07 | 1 | -2/+6 |
| | | | | | | | | explicitly set 'status' in 'destroy' actions of controllers | ||||
* | | Merge remote-tracking branch 'origin/master' into 25426-group-dashboard-ui | Dmitriy Zaporozhets | 2017-06-02 | 3 | -7/+5 |
|\ \ | |/ | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | ||||
| * | Consistently display last push event widget | Douwe Maan | 2017-05-25 | 1 | -2/+1 |
| | | |||||
| * | Merge branch 'snippets-finder-visibility' into 'security' | Douwe Maan | 2017-05-10 | 1 | -4/+3 |
| | | | | | | | | | | | | Refactor snippets finder & dont return internal snippets for external users See merge request !2094 | ||||
| * | Colorize labels in issue search field | Winnie Hellmann | 2017-05-05 | 1 | -1/+1 |
| | | |||||
* | | Serialize groups as json for Dashboard::GroupsController | Dmitriy Zaporozhets | 2017-05-04 | 1 | -7/+20 |
|/ | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | ||||
* | Revert "Merge branch 'tc-no-todo-service-select' into 'master'"revert-c3c465ac | Stan Hu | 2017-04-29 | 1 | -2/+2 |
| | | | This reverts merge request !10845 | ||||
* | Avoid plucking Todo ids and use sub-queries insteadtc-no-todo-service-select | Toon Claes | 2017-04-27 | 1 | -2/+2 |
| | | | | | | | | TodoService should not call `.select(&:id)` on todos, because this is bad performance. So instead use sub-queries, which will result in a single SQL query to the database. https://docs.gitlab.com/ee/development/sql.html#plucking-ids |