| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Adds ability to find builds by sha when only specifying a ref.
|
|
|
|
|
|
| |
The original intention of `get_build` was as a workaround not to violate
`CodeReuse/ActiveRecord`. `find_by_id` does the exact same thing but
does not violate the rubocop rule.
|
|
|
|
|
|
|
|
| |
Inside of `Projects::ArtifactsController` and
`Projects::BuildArtifactsController` we fetching the build by id using
active record directly which violates `CodeReuse/ActiveRecord` rubocop
rule. Create `get_build` inside of `project` model which does the same
thing.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
`project.latest_successful_builds_for(ref)` is being used to find a
single job all the time. This results into us having to call `find_by`
inside of the controller which violates our CodeReuse/ActiveRecord
rubocop rule.
Refactor `project.latest_successful_builds_for(ref)` to
`project.latest_successful_build_for(job_name, ref)` which will execute
the `find_by` inside of the model.
Also create `project.latest_successful_build_for!(job_name, ref)` which
raises an exception instead of returning nil.
|
|
|
|
|
|
|
| |
This reverts commit c48e7dc2633f8ee8f38150b050938f43e75bd207.
# Conflicts:
# app/controllers/projects/artifacts_controller.rb
|
|
|
|
| |
This makes to always proxy reports
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enables frozen string for some vestigial files as
well as the following:
* app/controllers/projects/**/*.rb
* app/controllers/sherlock/**/*.rb
* app/controllers/snippets/**/*.rb
* app/controllers/users/**/*.rb
Partially addresses #47424.
|
|
|
|
|
| |
This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.
|
|
|
|
|
|
|
| |
Since Rails 5 request.format gets set by extension if it's not explicitly
set.
That means artifacts_controller#file no longer works as expected.
This commit explicitly sets request.format for artifacts_controller#file.
|
|
|
|
|
|
| |
Multiple artifacts ee
See merge request gitlab-org/gitlab-ee!3276
|
|\
| |
| |
| | |
object-storage-ee-to-ce-backport
|
| | |
|
| | |
|
|/
|
|
|
|
|
|
| |
Can migrate LFS objects to S3 style object storage
Closes #2841
See merge request !2760
|
| |
|
| |
|
|\
| |
| |
| |
| | |
Consistent diff and blob size limit names
See merge request !11776
|
| | |
|
|/
|
|
|
|
|
|
|
|
|
|
| |
Rename other URL generators
admin_builds_path -> admin_jobs_path
Fix tests and more renaming
Fix more tests
Also change build_id to job_id in the controller
|
| |
|
| |
|
|
|
|
| |
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_14469768
|
|
|
|
| |
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_14400736
|
|
|
|
| |
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_14347729
|
| |
|
|
|
|
|
| |
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_14035941
|
|
|
|
| |
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_13988401
|
|
|
|
| |
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_13908017
|
|
|
|
| |
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_13880889
|
|
|
|
|
| |
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_13164642
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* master: (335 commits)
Disable transaction when adding index for Ci::Pipeline
added changelog
allow empty repos on import/export
Modify test for Build tabs
Add tests to project builds for pending tab
Remove unused .js-running-count class
Add test for new pending tab and update tests for running tab
Add Pending Tab to Admin Builds
added changelog
limit project expor retry to only 3
use method in validates statement
Fix spec to set import_url before attempting to create import_data
Allow a project import URL to be blank to prevent false positives preventing settings from being saved
Refactor gitlab_ci_yaml_processor variables tests
Fix CI yaml example
Align cancel and retry buttons
Remove deploy to production button
Remove irrelevant comments
Fix gitlab_ci_yaml_processor_spec.rb
Fix AddWhenAndYamlVariablesToCiBuilds migration
...
|
| |
| |
| |
| | |
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5094#note_12984211
|
| |
| |
| |
| |
| |
| |
| | |
Closes #19224, Closes #19128
Also requires this MR to work:
https://gitlab.com/gitlab-org/gitlab-workhorse/merge_requests/53
|
| |
| |
| |
| | |
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_13125486
|
| |
| |
| |
| |
| | |
So it's more accessible for views to access the names of jobs.
Only filter Build#name from where we really need to download it.
|
| |
| |
| |
| |
| |
| | |
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_13058785
And note that job/build_name could contain `/`
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It turns out they are different:
builds.success.latest.first
and
builds.latest.success.first
If we put success first, that latest would also filter via success,
and which is what we want here.
|
| | |
|
| | |
|