| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |\
| |
| |
| |
| |
| |
| | |
Rollback changes made to signing_enabled.
Closes #37202
See merge request !13956
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
'31273-creating-an-project-within-an-internal-sub-group-gives-the-option-to-set-it-a-public' into 'master'
Resolve various visibility level settings issues
Closes #31273
See merge request !13442
|
| | | | |
|
| | | | |
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
'37266-nomethoderror-undefined-method-current_application_settings-build-failed-30837482' into 'master'
`current_application_settings` belongs on `Gitlab::CurrentSettings`
Closes #37266
See merge request !13955
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The initializers including this were doing so at the top level, so every object
loaded after them had a `current_application_settings` method. However, if
someone had rack-attack enabled (which was loaded before these initializers), it
would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
have that method.
To fix this:
1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
`Object.new.current_application_settings` to work.
2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
like that in several places.
3. Change the initializers to use that new form.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Don't show references to Pages when not available
Closes #34864
See merge request !13888
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
In this instance its subgroups, and given we can't deploy it, we
shouldn't allow it to be shown.
Fixes gitlab-org/gitlab-ce#34864
|
| |\ \ \ \ \
| |_|/ / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Changes the password change workflow for admins.
Closes #28938
See merge request !13901
|
| | | |_|/
| |/| | |
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Postgres lets you treat `count` as another alias for `COUNT(*)` apparently, even
if that's not the actual alias used.
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Eager load head pipeline projects for MRs index
See merge request !13877
|
| | | |_|/
| |/| |
| | | |
| | | |
| | | |
| | | | |
This ensures the project of an MR's head pipeline is eager loaded,
preventing an N+1 query problem from occurring when viewing the list of
MRs of a project.
|
| |\ \ \ \
| |_|_|/
|/| | |
| | | |
| | | | |
Remove `is_` prefix from predicate method names
See merge request !13810
|
| | | | | |
|
| | |/ / |
|
| | | | |
|
| |/ / |
|
| | |
| |
| |
| |
| | |
This avoids loading the `OmniAuthCallbacksController` at boot time so
it doesn't mess up the `before_action`-chain
|
| |/ |
|
| |\
| |
| |
| |
| | |
Fix a potential timeout in `Gitlab::Logger.read_latest`
See merge request !13751
|
| | |
| |
| |
| |
| | |
We should be defining the list of loggers in the controller, not the
view.
|
| |\ \
| |/
|/|
| |
| |
| |
| | |
Fix inability to test some project integrations
Closes gitlab-ee#3194
See merge request !13729
|
| | | |
|
| |\ \
| |/
|/|
| |
| |
| |
| | |
Improves subgroup creation permissions
Closes #35845
See merge request !13418
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | | |
Whitelist or fix additional `Gitlab/PublicSend` cop violations
See merge request !13467
|
| | | |
| | |
| | |
| | |
| | | |
An upcoming update to rubocop-gitlab-security added additional
violations.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Enable Layout/TrailingWhitespace cop and auto-correct offenses
See merge request !13573
|
| | | |/
| |/| |
|
| |/ / |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Add a `Last 7 days` option for Cycle Analytics view
Closes #36300
See merge request !13443
|
| | | | |
|
| |\ \ \
| |_|/
|/| |
| | |
| | |
| | |
| | | |
Refactor how we fetch ref for merge requests
Closes #36089 and #36296
See merge request !13416
|
| | |\ \
| | |/
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
36089-handle-ref-failure-better
* upstream/master: (47 commits)
Update CHANGELOG.md for 9.4.5
Update charlock_holmes
add a changelog entry
switch to multi-line before block
restructure the #new_key notification spec
don't send devise notifications to the ghost user
reset_delivered_emails before testing #new_key
skip the :read_project check for new_project_member
move the member spec to be with the other ones
add a spec for new_group_member
add a spec for never emailing the ghost user
rubocop fix
a membership with no user is always notifiable
check notifiability for more emails
add Member#notifiable?(type, opts)
make NotificationRecipient a little more customizable
Add notes about database performance for MySQL
fix confidential border issue as well as confidential styles leaking on new MR
Migrate force push check to Gitaly
Add option to disable project export on instance
...
|
| | |\ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
36089-handle-ref-failure-better
* upstream/master: (62 commits)
Update gitlab.po: Missing 'r' in "Fouché" that comes from "Fourcher" verb.
Docs: update user docs index
Fix minor typos in views
Fix Layout/SpaceBeforeBlockBraces violation in bin/changelog_spec
Merge branch 'rs-alphanumeric-ssh-params' into 'security-9-4'
Merge branch 'import-symlinks-9-3' into 'security-9-3'
Fix wrong method call on prometheus histogram
Document new all-in-one Helm chart - docs
Fix 404 on link path
Fix line numbers not matching up to code in code viewer.
Hide overflow-x on collapsed sidebar
removed global use of breakpoint checker
Increase performance of the breakpoint size checker
Filter sensitive query string parameters from NGINX access logs
Added a template for database changes
Render new issue link in failed job as a regular link instead of a UJS one
Include RE2 in the upgrade docs
Remove affix plugin from issuable sidebar with new navigation
Fix linter error
alternative route for download archive
...
|
| | | | | |
|
| | |_|/
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This changes the pagination of the "Explore" pages so they use a simpler
pagination system that only shows "Prev" and "Next" buttons. This
removes the need for getting the total number of rows to display, a
process that can easily take up to 2 seconds when browsing through a
large list of projects.
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/27390
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Add option to disable project export on instance
See merge request !13211
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
Also marks a few things as uncovered, and removes an unused class.
|
| |\ \ \ \
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | | |
Delete correct key from `session` after authenticating using U2F
Closes #36096
See merge request !13499
|
| | | |/
| |/| |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Use a separate table for storing push events
See merge request !12463
|
| | |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This changes various controllers to use the new EventCollection class
for retrieving events. This class uses a JOIN LATERAL query on
PostgreSQL to retrieve queries in a more efficient way, while falling
back to a simpler / less efficient query for MySQL.
The EventCollection class also includes a limit on the number of events
to display to prevent malicious users from cycling through all events,
as doing so could put a lot of pressure on the database.
JOIN LATERAL is only supported on PostgreSQL starting with version 9.3.0
and as such this optimisation is only used when using PostgreSQL 9.3 or
newer.
|
| |/ /
| |
| |
| |
| |
| |
| |
| | |
This caches the result of Appearance.first in a similar fashion to how
ApplicationSetting instances are cached. We also add some NOT NULL
constraints to the table and correct the timestamp types.
Fixes gitlab-org/gitlab-ce#36066, fixes gitlab-org/gitlab-ce#31698
|
| | |
| |
| |
| | |
Its usage has been removed at 2fa22a0729.
|
