summaryrefslogtreecommitdiff
path: root/app/helpers/branches_helper.rb
Commit message (Collapse)AuthorAgeFilesLines
* Use --left-right and --max-count for counting diverging commitsLin Jen-Shin (godfat)2018-01-051-0/+8
|
* Create and use project path helpers that only need a project, no namespaceDouwe Maan2017-07-051-1/+1
|
* Add confirm delete protected branch modalSam Rose2017-05-081-10/+0
|
* Protected Tags backend review changesJames Edwards-Jones2017-04-061-0/+4
| | | Added changelog
* Moved Project#protected_branch? to ProtectedBranch, similar for tagsJames Edwards-Jones2017-04-031-1/+1
|
* implements the basic filter functionalitytiagonbotelho2016-07-191-0/+11
|
* Revert "Revert "Merge branch '18193-developers-can-merge' into 'master' ""Rémy Coutable2016-07-181-1/+1
| | | | | | | | This reverts commit 530f5158e297f3cde27f3566cfe13bad74ba3b50. See !4892. Signed-off-by: Rémy Coutable <remy@rymai.me>
* Revert "Merge branch '18193-developers-can-merge' into 'master' "Robert Speicher2016-07-131-1/+1
| | | | | This reverts commit 9ca633eb4c62231e4ddff5466c723cf8e2bdb25d, reversing changes made to fb229bbf7970ba908962b837b270adf56f14098f.
* Refactor `Gitlab::GitAccess`Timothy Andrew2016-07-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. Don't use case statements for dispatch anymore. This leads to a lot of duplication, and makes the logic harder to follow. 2. Remove duplicated logic. - For example, the `can_push_to_branch?` exists, but we also have a different way of checking the same condition within `change_access_check`. - This kind of duplication is removed, and the `can_push_to_branch?` method is used in both places. 3. Move checks returning true/false to `UserAccess`. - All public methods in `GitAccess` now return an instance of `GitAccessStatus`. Previously, some methods would return true/false as well, which was confusing. - It makes sense for these kinds of checks to be at the level of a user, so the `UserAccess` class was repurposed for this. The prior `UserAccess.allowed?` classmethod is converted into an instance method. - All external uses of these checks have been migrated to use the `UserAccess` class 4. Move the "change_access_check" into a separate class. - Create the `GitAccess::ChangeAccessCheck` class to run these checks, which are quite substantial. - `ChangeAccessCheck` returns an instance of `GitAccessStatus` as well. 5. Break out the boolean logic in `ChangeAccessCheck` into `if/else` chains - this seems more readable. 6. I can understand that this might look like overkill for !4892, but I think this is a good opportunity to clean it up. - http://martinfowler.com/bliki/OpportunisticRefactoring.html
* Revert back to not defining a default Git access protocol.Patricio Cano2016-07-051-1/+1
|
* Default Git access protocol to `web`Patricio Cano2016-07-051-1/+1
|
* Rename ENV['PROTOCOL'] to ENV['GL_PROTOCOL'] to conform to what GitLab Shell ↵Patricio Cano2016-07-051-1/+1
| | | | expects and make the `protocol` param in `GitAccess` mandatory.
* Unify check branch name existPaco Guzman2016-06-201-1/+1
|
* Only show branches for revert / cherry-pick18377-cherry-pick-crashes-when-choosing-a-tagSean McGivern2016-06-131-0/+4
| | | | | Tags are immutable, so we can't add a commit to either revert or cherry-pick another commit to them.
* Default target branch to patch-n when editing file in protected branchDouwe Maan2015-12-081-1/+1
|
* Refactor GitAccess to use instance variables.Douwe Maan2015-03-241-1/+1
|
* developer can push to protected branchesValery Sizov2015-01-201-7/+2
|
* Dont show new file link on protected branch for developersDmitriy Zaporozhets2014-06-021-7/+18
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Add BranchesHelperDmitriy Zaporozhets2014-05-221-0/+11
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
View Lorry Controller Status