Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Align UrlValidator to validate_url gem implementation. | Thong Kuah | 2019-04-11 | 1 | -1/+1 |
| | | | | | | | Renamed UrlValidator to AddressableUrlValidator to avoid 'url:' naming collision with ActiveModel::Validations::UrlValidator in 'validates' statement. Make use of the options attribute of the parent class ActiveModel::EachValidator. Add more options: allow_nil, allow_blank, message. Renamed 'protocols' option to 'schemes' to match the option naming from UrlValidator. | ||||
* | Inherit from ApplicationRecord instead of ActiveRecord::Base | Nick Thomas | 2019-03-28 | 1 | -1/+1 |
| | |||||
* | Added FromUnion to easily select from a UNION | Yorick Peterse | 2018-09-17 | 1 | -0/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit adds the module `FromUnion`, which provides the class method `from_union`. This simplifies the process of selecting data from the result of a UNION, and reduces the likelihood of making mistakes. As a result, instead of this: union = Gitlab::SQL::Union.new([foo, bar]) Foo.from("(#{union.to_sql}) #{Foo.table_name}") We can now write this instead: Foo.from_union([foo, bar]) This commit also includes some changes to make this new setup work properly. For example, a bug in Rails 4 (https://github.com/rails/rails/issues/24193) would break the use of `from("sub-query-here").includes(:relation)` in certain cases. There was also a CI query which appeared to repeat a lot of conditions from an outer query on an inner query, which isn't necessary. Finally, we include a RuboCop cop to ensure developers use this new module, instead of using Gitlab::SQL::Union directly. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/51307 | ||||
* | Enable frozen string in app/models/*.rbrepo-forks/gitlab-ce-frozen-string-enable-app-models | gfyoung | 2018-07-26 | 1 | -0/+2 |
| | | | | Partially addresses #47424. | ||||
* | Add validation to webhook and service URLs to ensure they are not blocked ↵ | Francisco Javier López | 2018-06-01 | 1 | -1/+1 |
| | | | | because of SSRF | ||||
* | Projects and groups badges API | Francisco Javier López | 2018-03-05 | 1 | -0/+51 |