summaryrefslogtreecommitdiff
path: root/app/models/cycle_analytics.rb
Commit message (Collapse)AuthorAgeFilesLines
* updated var name based on feedbackfeature/cycle-analytics-2-backendJames Lopez2016-10-131-2/+2
|
* Ignore deployment for statistics in Cycle Analytics, except in staging and ↵James Lopez2016-10-121-4/+10
| | | | | | production stages Also, updated specs and docs.
* Implement a second round of review comments from @DouweM.Timothy Andrew2016-09-211-37/+29
| | | | | | | | | | | | | | - Don't use `TableReferences` - using `.arel_table` is shorter! - Move some database-related code to `Gitlab::Database` - Remove the `MergeRequest#issues_closed` and `Issue#closed_by_merge_requests` associations. They were either shadowing or were too similar to existing methods. They are not being used anywhere, so it's better to remove them to reduce confusion. - Use Rails 3-style validations - Index for `MergeRequest::Metrics#first_deployed_to_production_at` - Only include `CycleAnalyticsHelpers::TestGeneration` for specs that need it. - Other minor refactorings.
* Implement (some) comments from @DouweM's review.Timothy Andrew2016-09-201-68/+41
| | | | | | - Move things common to `Issue` and `MergeRequest` into `Issuable` - Move more database-specific functions into `Gitlab::Database` - Indentation changes and other minor refactorings.
* Implement review comments from @yorickpeterseTimothy Andrew2016-09-201-2/+4
| | | | | | | | | | | | | | 1. Change multiple updates to a single `update_all` 2. Use cascading deletes 3. Extract an average function for the database median. 4. Move database median to `lib/gitlab/database` 5. Use `delete_all` instead of `destroy_all` 6. Minor refactoring
* Implement a database median strategy for MySQL.Timothy Andrew2016-09-201-12/+43
| | | | | | | | 1. Dispatch between the two strategies automatically based on the current database type. 2. The MySQL version needs to run multiple statements, so the `cycle_analytics` model is modified to support this.
* CycleAnalytics operates on merge requests that have been deployed.Timothy Andrew2016-09-201-23/+17
| | | | | | | | | 1. Look for merge requests (and issues that they close) that have been deployed to production in the last X days (where X is given by the `from` parameter). 2. Cycle analytics queries only operate on this fitered set of merge requests and issues.
* Make changes to the cycle analytics JSON endpoint.Timothy Andrew2016-09-191-0/+5
| | | | | | 1. Add `summary` section. 2. `stats` is `null` if no stats are present. 3. `stats` and `summary` are both arrays.
* Move cycle analytics JSON generation to a helper.Timothy Andrew2016-09-171-7/+0
| | | | | 1. Use a new format, with each stage having a `title`, `description`, and `value.
* Move cycle analytics calculations to SQL.Timothy Andrew2016-09-171-36/+65
| | | | | | | 1. Use Arel for composable queries. 2. For a project with ~10k issues, the page loads in around 600ms. Previously, a project with ~5k issues would have a ~20s page load time.
* Improve performance of the cycle analytics page.Timothy Andrew2016-09-151-18/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. These changes bring down page load time for 100 issues from more than a minute to about 1.5 seconds. 2. This entire commit is composed of these types of performance enhancements: - Cache relevant data in `IssueMetrics` wherever possible. - Cache relevant data in `MergeRequestMetrics` wherever possible. - Preload metrics 3. Given these improvements, we now only need to make 4 SQL calls: - Load all issues - Load all merge requests - Load all metrics for the issues - Load all metrics for the merge requests 4. A list of all the data points that are now being pre-calculated: a. The first time an issue is mentioned in a commit - In `GitPushService`, find all issues mentioned by the given commit using `ReferenceExtractor`. Set the `first_mentioned_in_commit_at` flag for each of them. - There seems to be a (pre-existing) bug here - files (and therefore commits) created using the Web CI don't have cross-references created, and issues are not closed even when the commit title is "Fixes #xx". b. The first time a merge request is deployed to production When a `Deployment` is created, find all merge requests that were merged in before the deployment, and set the `first_deployed_to_production_at` flag for each of them. c. The start / end time for a merge request pipeline Hook into the `Pipeline` state machine. When the `status` moves to `running`, find the merge requests whose tip commit matches the pipeline, and record the `latest_build_started_at` time for each of them. When the `status` moves to `success`, record the `latest_build_finished_at` time. d. The merge requests that close an issue - This was a big cause of the performance problems we were having with Cycle Analytics. We need to use `ReferenceExtractor` to make this calculation, which is slow when we have to run it on a large number of merge requests. - When a merge request is created, updated, or refreshed, find the issues it closes, and create an instance of `MergeRequestsClosingIssues`, which acts as a join model between merge requests and issues. - If a `MergeRequestsClosingIssues` instance links a merge request and an issue, that issue closes that merge request. 5. The `Queries` module was changed into a class, so we can cache the results of `issues` and `merge_requests_closing_issues` across various cycle analytics stages. 6. The code added in this commit is untested. Tests will be added in the next commit.
* Add a JSON version of the `CycleAnalytics` page.Timothy Andrew2016-09-081-0/+7
|
* Tweak cycle analytics query to match the current requirements.Timothy Andrew2016-09-021-8/+8
| | | | | | | | | | | | - The `review` phase ends when a MR is merged, not "merged OR closed". - The `code` phase starts when a MR is first mentioned in a commit, and ends when a merge request closing the issue is created. - The `plan` phase ends when the issue first mentioned in a commit. --- - Fix the `median` function so it sorts the incoming data points. - A data point where `end_time` is prior to `start_time` is invalid.
* Fetch cycle analytics data for a specific date range.Timothy Andrew2016-08-261-8/+11
| | | | | | | | | 1. Supported date ranges are 30 / 90 days ago. The default is 90 days ago. 2. All issues created before "x days ago" are filtered out, even if they have other related data (test runs, merge requests) within the filter range.
* Scope Cycle Analytics queries to a projectTimothy Andrew2016-08-261-7/+11
|
* Allow multiple queries for each cycle analytics section.Timothy Andrew2016-08-261-14/+14
| | | | | | | | | 1. Pass in an array of queries - the first to return a value will be used. This makes it easier to add more heuristics later. 2. Convert all queries with 'or' in the title to two separate queries. 3. Rename all `mr_` methods to `merge_request_`
* Add the "Test" cycle analytics section.Timothy Andrew2016-08-261-0/+6
|
* Add the "Production" cycle analytics section.Timothy Andrew2016-08-261-13/+14
| | | | | | | | 1. Rewrite the `Queries` module to work off a `data_point` hash, with `issue` and `merge_request` as keys. The "production" query needs both an issue and a merge request to make it's calculation, so it makes sense to keep things consistent and provide the same data (issue + merge request) for all queries.
* Add the "Staging" cycle analytics section.Timothy Andrew2016-08-261-2/+9
|
* Add the "Review" cycle analytics section.Timothy Andrew2016-08-261-1/+8
|
* Add the "Code" Cycle Analytics section.Timothy Andrew2016-08-261-9/+12
| | | | | | | | | 1. Record the `wip_flag_first_removed_at` and `first_assigned_to_user_other_than_author` metrics for a merge request. Use a `merge_request_metrics` table, similar to the one for `issues`. Metrics are recorded `after_save`. 2. Move larger queries to a `CycleAnalytics::Queries` module.
* Add the "Plan" Cycle Analytics query.Timothy Andrew2016-08-261-0/+40
1. Move from raw SQL to ActiveRecord. 2. Add a non-persisted `CycleAnalytics` model to store all the queries.
View Lorry Controller Status