Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Improve performance of DiffDiscussion#truncated_diff_lines and ↵ | Douwe Maan | 2017-12-22 | 1 | -5/+1 |
| | | | | DiffNote#diff_line by removing expensive diff position calculation and comparison | ||||
* | Allow commenting on individual commits inside an MR | Douwe Maan | 2017-12-07 | 1 | -0/+7 |
| | |||||
* | Prevents position update for image diff notesissue_40058 | Felipe Artur | 2017-11-13 | 1 | -1/+2 |
| | |||||
* | Commenting on image diffs | Felipe Artur | 2017-10-07 | 1 | -2/+12 |
| | |||||
* | Rename ActiverecordSerialize cop | Yorick Peterse | 2017-07-06 | 1 | -3/+3 |
| | | | | | This cop has been renamed to ActiveRecordSerialize to match the way "ActiveRecord" is usually written. | ||||
* | Merge branch 'dm-update-discussion-diff-position' into 'master' | Grzegorz Bizon | 2017-06-01 | 1 | -5/+13 |
|\ | | | | | | | | | | | | | Update diff discussion position per discussion instead of per note Closes #33157 See merge request !11833 | ||||
| * | Update diff discussion position per discussion instead of per notedm-update-discussion-diff-position | Douwe Maan | 2017-05-31 | 1 | -5/+13 |
| | | |||||
* | | Added Cop to blacklist the use of serializedocument-not-using-serialize | Yorick Peterse | 2017-05-31 | 1 | -3/+3 |
|/ | | | | | This Cop blacklists the use of ActiveRecord's "serialize" method, except for cases where we already use this. | ||||
* | Merge branch 'dm-diff-cleanup' into 'master' | Robert Speicher | 2017-05-25 | 1 | -2/+2 |
|\ | | | | | | | | | Clean up diff rendering See merge request !11390 | ||||
| * | Pass fallback_diff_refs to Diff::File instead of using view helpers | Douwe Maan | 2017-05-23 | 1 | -2/+2 |
| | | |||||
* | | Add system note with link to diff comparison when MR discussion becomes outdated | Douwe Maan | 2017-05-23 | 1 | -2/+5 |
|/ | |||||
* | Allow commenting on older versions of the diff and comparisons between diff ↵dm-link-discussion-to-outdated-diff | Douwe Maan | 2017-05-03 | 1 | -3/+4 |
| | | | | versions | ||||
* | Link to outdated diff in older MR version from outdated diff discussion | Douwe Maan | 2017-04-08 | 1 | -8/+6 |
| | |||||
* | Refactor resolvability checks based on type | Douwe Maan | 2017-04-06 | 1 | -0/+2 |
| | |||||
* | Address review comments | Douwe Maan | 2017-04-05 | 1 | -0/+1 |
| | |||||
* | Don't use original_discussion_id | Douwe Maan | 2017-04-05 | 1 | -3/+0 |
| | |||||
* | Extract commonalities between DiffDiscussion and LegacyDiffDiscussion | Douwe Maan | 2017-04-05 | 1 | -13/+2 |
| | |||||
* | Add specs | Douwe Maan | 2017-04-05 | 1 | -1/+3 |
| | |||||
* | Add option to start a new discussion on an MR | Douwe Maan | 2017-04-05 | 1 | -93/+22 |
| | |||||
* | Enable Style/WordArray | Douwe Maan | 2017-02-23 | 1 | -1/+1 |
| | |||||
* | Optimize discussion notes resolving and unresolving21109-discussion-resolve-runs-a-single-update-query-per-note-but-should-run-a-single-update-query-for-all-notes-instead | Alejandro Rodríguez | 2016-09-06 | 1 | -0/+18 |
| | | | | | | | Use `update_all` to only require one query per discussion to update the notes resolved status. Some changes had to be made to the discussion spec to accout for the fact that notes are not individually updated now | ||||
* | Move #to_discussion to NoteOnDiff21211-comment-on-diff-partially-broken-after-updating-to-8-11 | Sean McGivern | 2016-08-30 | 1 | -4/+0 |
| | |||||
* | Call `set_discussion_id` again in DiffNote `before_validation` because the ↵ | Douwe Maan | 2016-08-19 | 1 | -0/+3 |
| | | | | order is important | ||||
* | Fix bug where notes weren’t shown in discussion when the code had changed ↵ | Douwe Maan | 2016-08-19 | 1 | -0/+4 |
| | | | | after creation | ||||
* | Improve performance of MR show page | Douwe Maan | 2016-08-18 | 1 | -2/+0 |
| | |||||
* | Fix a lingering conflict. | Connor Shea | 2016-08-17 | 1 | -5/+1 |
| | |||||
* | Merge branch 'master' into diff-line-comment-vuejs | Connor Shea | 2016-08-17 | 1 | -0/+4 |
|\ | |||||
| * | Don't allow resolving invalid conflicts | Sean McGivern | 2016-08-12 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | An MR can only be resolved in the UI if: - It has conflicts. - It has valid diff_refs (in other words, it supports new diff notes). - It has no conflicts with one side missing. - It has no conflicts in binary files. - It has no conflicts in files too large to display. - It has no conflicts containing invalid conflict markers. | ||||
* | | Store discussion_id on Note for faster discussion lookup. | Douwe Maan | 2016-08-17 | 1 | -14/+23 |
| | | |||||
* | | Address review feedback | Douwe Maan | 2016-08-16 | 1 | -1/+1 |
| | | |||||
* | | Add specs for new Note and DiffNote methods. | Douwe Maan | 2016-08-12 | 1 | -0/+3 |
| | | |||||
* | | Merge branch 'master' into diff-line-comment-vuejs | Douwe Maan | 2016-08-03 | 1 | -2/+10 |
|\ \ | |/ | | | | | | | | | # Conflicts: # app/models/discussion.rb # db/schema.rb | ||||
| * | Speedup DiffNote#active? on discussions, preloading noteables and avoid ↵ | Paco Guzman | 2016-08-02 | 1 | -2/+10 |
| | | | | | | | | | | | | | | | | | | | | | | touching git repository to return diff_refs when possible - Preloading noteable we share the same noteable instance when more than one discussion refers to the same noteable. - Any other call to that object that is cached in that object will be for any discussion. - In those cases where merge_request_diff has all the sha stored to build a diff_refs get that diff_refs using directly those sha instead accessing to the git repository to first get the commits and later the sha. | ||||
* | | Backend tweaks | Douwe Maan | 2016-07-28 | 1 | -2/+13 |
| | | |||||
* | | Use sha1 of discussion ID. | Douwe Maan | 2016-07-25 | 1 | -2/+2 |
| | | |||||
* | | Add methods to resolve diff notes and discussions | Douwe Maan | 2016-07-25 | 1 | -0/+18 |
| | | |||||
* | | Add resolved_at and resolved_by_id to DiffNote | Douwe Maan | 2016-07-25 | 1 | -0/+13 |
|/ | |||||
* | Make `DiffNote#update_position` private | Douwe Maan | 2016-07-07 | 1 | -19/+14 |
| | |||||
* | Keep around DiffNote position commits | Douwe Maan | 2016-07-06 | 1 | -0/+13 |
| | |||||
* | Automatically update diff note positions when MR is pushed to | Douwe Maan | 2016-07-06 | 1 | -1/+21 |
| | |||||
* | Support new diff notes on MRs with diff_refs | Douwe Maan | 2016-07-06 | 1 | -1/+1 |
| | |||||
* | Add DiffNote model | Douwe Maan | 2016-07-06 | 1 | -0/+99 |