summaryrefslogtreecommitdiff
path: root/app/models/diff_note.rb
Commit message (Collapse)AuthorAgeFilesLines
* Improve performance of DiffDiscussion#truncated_diff_lines and ↵Douwe Maan2017-12-221-5/+1
| | | | DiffNote#diff_line by removing expensive diff position calculation and comparison
* Allow commenting on individual commits inside an MRDouwe Maan2017-12-071-0/+7
|
* Prevents position update for image diff notesissue_40058Felipe Artur2017-11-131-1/+2
|
* Commenting on image diffsFelipe Artur2017-10-071-2/+12
|
* Rename ActiverecordSerialize copYorick Peterse2017-07-061-3/+3
| | | | | This cop has been renamed to ActiveRecordSerialize to match the way "ActiveRecord" is usually written.
* Merge branch 'dm-update-discussion-diff-position' into 'master'Grzegorz Bizon2017-06-011-5/+13
|\ | | | | | | | | | | | | Update diff discussion position per discussion instead of per note Closes #33157 See merge request !11833
| * Update diff discussion position per discussion instead of per notedm-update-discussion-diff-positionDouwe Maan2017-05-311-5/+13
| |
* | Added Cop to blacklist the use of serializedocument-not-using-serializeYorick Peterse2017-05-311-3/+3
|/ | | | | This Cop blacklists the use of ActiveRecord's "serialize" method, except for cases where we already use this.
* Merge branch 'dm-diff-cleanup' into 'master'Robert Speicher2017-05-251-2/+2
|\ | | | | | | | | Clean up diff rendering See merge request !11390
| * Pass fallback_diff_refs to Diff::File instead of using view helpersDouwe Maan2017-05-231-2/+2
| |
* | Add system note with link to diff comparison when MR discussion becomes outdatedDouwe Maan2017-05-231-2/+5
|/
* Allow commenting on older versions of the diff and comparisons between diff ↵dm-link-discussion-to-outdated-diffDouwe Maan2017-05-031-3/+4
| | | | versions
* Link to outdated diff in older MR version from outdated diff discussionDouwe Maan2017-04-081-8/+6
|
* Refactor resolvability checks based on typeDouwe Maan2017-04-061-0/+2
|
* Address review commentsDouwe Maan2017-04-051-0/+1
|
* Don't use original_discussion_idDouwe Maan2017-04-051-3/+0
|
* Extract commonalities between DiffDiscussion and LegacyDiffDiscussionDouwe Maan2017-04-051-13/+2
|
* Add specsDouwe Maan2017-04-051-1/+3
|
* Add option to start a new discussion on an MRDouwe Maan2017-04-051-93/+22
|
* Enable Style/WordArrayDouwe Maan2017-02-231-1/+1
|
* Optimize discussion notes resolving and unresolving21109-discussion-resolve-runs-a-single-update-query-per-note-but-should-run-a-single-update-query-for-all-notes-insteadAlejandro Rodríguez2016-09-061-0/+18
| | | | | | | Use `update_all` to only require one query per discussion to update the notes resolved status. Some changes had to be made to the discussion spec to accout for the fact that notes are not individually updated now
* Move #to_discussion to NoteOnDiff21211-comment-on-diff-partially-broken-after-updating-to-8-11Sean McGivern2016-08-301-4/+0
|
* Call `set_discussion_id` again in DiffNote `before_validation` because the ↵Douwe Maan2016-08-191-0/+3
| | | | order is important
* Fix bug where notes weren’t shown in discussion when the code had changed ↵Douwe Maan2016-08-191-0/+4
| | | | after creation
* Improve performance of MR show pageDouwe Maan2016-08-181-2/+0
|
* Fix a lingering conflict.Connor Shea2016-08-171-5/+1
|
* Merge branch 'master' into diff-line-comment-vuejsConnor Shea2016-08-171-0/+4
|\
| * Don't allow resolving invalid conflictsSean McGivern2016-08-121-1/+1
| | | | | | | | | | | | | | | | | | | | An MR can only be resolved in the UI if: - It has conflicts. - It has valid diff_refs (in other words, it supports new diff notes). - It has no conflicts with one side missing. - It has no conflicts in binary files. - It has no conflicts in files too large to display. - It has no conflicts containing invalid conflict markers.
* | Store discussion_id on Note for faster discussion lookup.Douwe Maan2016-08-171-14/+23
| |
* | Address review feedbackDouwe Maan2016-08-161-1/+1
| |
* | Add specs for new Note and DiffNote methods.Douwe Maan2016-08-121-0/+3
| |
* | Merge branch 'master' into diff-line-comment-vuejsDouwe Maan2016-08-031-2/+10
|\ \ | |/ | | | | | | | | # Conflicts: # app/models/discussion.rb # db/schema.rb
| * Speedup DiffNote#active? on discussions, preloading noteables and avoid ↵Paco Guzman2016-08-021-2/+10
| | | | | | | | | | | | | | | | | | | | | | touching git repository to return diff_refs when possible - Preloading noteable we share the same noteable instance when more than one discussion refers to the same noteable. - Any other call to that object that is cached in that object will be for any discussion. - In those cases where merge_request_diff has all the sha stored to build a diff_refs get that diff_refs using directly those sha instead accessing to the git repository to first get the commits and later the sha.
* | Backend tweaksDouwe Maan2016-07-281-2/+13
| |
* | Use sha1 of discussion ID.Douwe Maan2016-07-251-2/+2
| |
* | Add methods to resolve diff notes and discussionsDouwe Maan2016-07-251-0/+18
| |
* | Add resolved_at and resolved_by_id to DiffNoteDouwe Maan2016-07-251-0/+13
|/
* Make `DiffNote#update_position` privateDouwe Maan2016-07-071-19/+14
|
* Keep around DiffNote position commitsDouwe Maan2016-07-061-0/+13
|
* Automatically update diff note positions when MR is pushed toDouwe Maan2016-07-061-1/+21
|
* Support new diff notes on MRs with diff_refsDouwe Maan2016-07-061-1/+1
|
* Add DiffNote modelDouwe Maan2016-07-061-0/+99