summaryrefslogtreecommitdiff
path: root/app/models/global_milestone.rb
Commit message (Collapse)AuthorAgeFilesLines
* Updates from last code review.issue_13621_2Rubén Dávila2016-03-061-49/+4
|
* Refactor Merge Requests tab into a custom partialRubén Dávila2016-03-041-0/+6
| | | | | * Add Labels tab to Groups * Add decorator for label so it's aware of Milestones.
* Eager load Issues/MRs project for Milestone.Rubén Dávila2016-03-041-2/+2
| | | | | With this change we avoid doing N+1 queries when viewing Milestone's Issues/MRs from a Group context.
* Refactor GlobalMilestone queries.Rubén Dávila2016-03-041-13/+13
| | | | Make methods return ActiveRecord Relations instead of Arrays.
* Add two custom Date/Time conversion formatsRobert Speicher2016-01-071-2/+2
|
* Remove stamp gemRobert Speicher2016-01-071-2/+2
| | | | Closes #5908
* Fix Error 500 when global milestones have slashesStan Hu2015-12-221-1/+1
| | | | Closes #4226
* Merge branch 'gsmethells/gitlab-ce-sort-by-due-date'Douwe Maan2015-12-071-0/+29
|\
| * Satisfy RubocopDouwe Maan2015-12-071-1/+1
| |
| * sort milestones by due_dateGreg Smethells2015-12-031-1/+30
| |
* | Fix Error 500 when creating global milestones with Unicode charactersStan Hu2015-12-051-1/+1
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Two issues: 1. The constraints in the resources were incorrect. Here's what it was before: ``` group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/} ``` In this case, id is actually the title of the milestone, which can be anything at the moment. After: ``` group_milestone GET /groups/:group_id/milestones/:id(.:format) groups/milestones#show {:id=>/[^\/]+/, :group_id=>/[a-zA-Z.0-9_\-]+(?<!\.atom)/} ``` 2. `parameterize` would strip all Unicode characters, leaving a blank string. Rails would report something like: ActionView::Template::Error (No route matches {:action=>"show", :controller=>"groups/milestones", :group_id=>#<Group id: 48, name: "ops-dev", path: "ops-dev", owner_id: nil, created_at: "2015-11-15 08:55:30", updated_at: "2015-12-02 06:23:26", type: "Group", description: "", avatar: "sha1.c71e73d51af1865c1bbbf6208e10044d46c9bb93.png", public: false>, :id=>"", :title=>"肯定不是中文的问题"} missing required keys: [:id]): This change uses the babosa library to create a better slug, which surprisingly isn't actually used by the global milestone controllers. Instead, they use the title passed as a query string for some reason. Closes https://github.com/gitlabhq/gitlabhq/issues/9881 Fix constraints
* Some code and doc improvementsglobal-milestonesDmitriy Zaporozhets2015-11-161-0/+4
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Refactor global and group milestones logicDmitriy Zaporozhets2015-11-161-0/+97
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>