summaryrefslogtreecommitdiff
path: root/app/models/group.rb
Commit message (Collapse)AuthorAgeFilesLines
* Support custom attributes on groupsMarkus Koller2017-11-061-0/+1
|
* Add system hooks user_rename and group_renameWinnie Hellmann2017-11-031-0/+11
|
* CE port of code changed for epicsjk-epic-changes-ce-portJarka Kadlecova2017-11-021-0/+6
|
* Load counts everywhere we render a group treeBob Van Landuyt2017-10-051-0/+1
|
* Rename `GroupHierarchy` to `GroupDescendant`Bob Van Landuyt2017-10-041-1/+1
|
* Add a concern to build hierarchies of groupsBob Van Landuyt2017-10-041-0/+1
|
* Optimize SQL queries used in Groups::GroupMembersController#create27374-groups-groupmemberscontroller-create-is-slow-due-to-sqlRubén Dávila2017-09-051-0/+1
| | | | | | | | | | | The following optimizations were performed: - Add new association to GroupMember and ProjectMember This new association will allow us to check if a user is a member of a Project or Group through a single query instead of two. - Optimize retrieving of Members when adding multiple Users
* Merge branch ↵Tim Zallmann2017-08-311-8/+37
|\ | | | | | | | | | | | | | | | | '31273-creating-an-project-within-an-internal-sub-group-gives-the-option-to-set-it-a-public' into 'master' Resolve various visibility level settings issues Closes #31273 See merge request !13442
| * revert changes to visibility level helpers from 6f03ddcMike Greiling2017-08-301-3/+3
| |
| * Address some suggestions from first code reviewRubén Dávila2017-08-291-20/+20
| |
| * prefer !x.exists? instead of x.none? to prevent unnecessary instantiation of ↵Mike Greiling2017-08-261-2/+2
| | | | | | | | records
| * Fix broken spec.Rubén Dávila2017-08-261-1/+1
| | | | | | | | parent_id is being set to 0 by RSpec.
| * recognize instances where group visibility levels are unavailableMike Greiling2017-08-261-0/+6
| |
| * separate visibility_level_allowed logic from model validatorsMike Greiling2017-08-261-15/+17
| |
| * Add validation to check visibility level of sub groups.Rubén Dávila2017-08-261-4/+16
| |
| * Add validation for visibility level of sub groupsRubén Dávila2017-08-261-0/+9
| | | | | | | | Sub groups should not have a visibility level higher than its parent.
* | Move sidekiq-based project authorization refresh out of Projects::CreateServiceNick Thomas2017-08-251-2/+2
|/ | | | | | | | | | | If the project is in a group, the `group.refresh_members_authorized_projects` is made non-blocking, and we call `current_user.refresh_authorized_projects` directly. Projects in a personal namespace are more difficult. Rather than passing the `blocking:` parameter through the entire `add_master` chain, have the `AuthorizedProjectsWorker` automatically inline authorizations for three IDs or less. Since the maximum number of IDs in this path is 2, that has the same effect.
* Speed up Group#user_ids_for_project_authorizationsNick Thomas2017-08-141-6/+24
|
* Don't treat anonymous users as owners when group has pending invitesSean McGivern2017-07-241-1/+5
| | | | | | The `members` table can have entries where `user_id: nil`, because people can invite group members by email. We never want to include those as members, because it might cause confusion with the anonymous (logged out) user.
* Promote visibility level helpers from Group to NamespaceNick Thomas2017-07-171-5/+0
| | | | | In EE, we make use of `namespace#public?` in projects. When the project is in a personal namespace, this breaks as the `public?` helper isn't present.
* Native group milestonesFelipe Artur2017-07-071-0/+1
|
* secret_variables_for: rails readability versinoShinya Maeda2017-07-071-11/+5
|
* Add CASE When Clause for saving order when using where INShinya Maeda2017-07-071-1/+9
|
* Use ancestors for avoiding N queriesShinya Maeda2017-07-071-4/+3
|
* Basic BE changeShinya Maeda2017-07-071-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix static-snalysis Move the precedence of group secure variable before project secure variable. Allow project_id to be null. Separate Ci::VariableProject and Ci::VariableGroup Add the forgotton files Add migration file to update type of ci_variables Fix form_for fpr VariableProject Fix test Change the table structure according to the yorik advice Add necessary migration files. Remove unnecessary migration spec. Revert safe_model_attributes.yml Fix models Fix spec Avoid self.variable. Use becomes for correct routing. Use unique index on group_id and key Add null: false for t.timestamps Fix schema version Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable Rename the rest of them Add the rest of files Basic BE change Fix static-snalysis Move the precedence of group secure variable before project secure variable. Allow project_id to be null. Separate Ci::VariableProject and Ci::VariableGroup Add the forgotton files Add migration file to update type of ci_variables Fix form_for fpr VariableProject Fix test Change the table structure according to the yorik advice Add necessary migration files. Remove unnecessary migration spec. Revert safe_model_attributes.yml Fix models Fix spec Avoid self.variable. Use becomes for correct routing. Use unique index on group_id and key Add null: false for t.timestamps Fix schema version Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable Rename the rest of them Add the rest of files Implement CURD Rename codes related to VariableGroup and VariableProject FE part Remove unneccesary changes Make Fe code up-to-date Add protected flag to migration file Protected group variables essential package Update schema Improve doc Fix logic and spec for models Fix logic and spec for controllers Fix logic and spec for views(pre feature) Add feature spec Fixed bugs. placeholder. reveal button. doc. Add changelog Remove unnecessary comment godfat nice catches Improve secret_variables_for arctecture Fix spec Fix StaticAnlysys & path_regex spec Revert "Improve secret_variables_for arctecture" This reverts commit c3216ca212322ecf6ca534cb12ce75811a4e77f1. Use ayufan suggestion for secret_variables_for Use find instead of find_by Fix spec message for variable is invalid Fix spec remove variable.group_id = group.id godffat spec nitpicks Use include Gitlab::Routing.url_helpers for presenter spec
* Added Cop to blacklist the use of `dependent:`Yorick Peterse2017-07-061-5/+5
| | | | | | | | This is allowed for existing instances so we don't end up 76 offenses right away, but for new code one should _only_ use this if they _have_ to remove non database data. Even then it's usually better to do this in a service class as this gives you more control over how to remove the data (e.g. in bulk).
* Add "members_count" and "parent_id" data on namespaces APIOswaldo Ferreira2017-06-281-0/+6
|
* Enable Style/DotPosition Rubocop :cop:Grzegorz Bizon2017-06-211-6/+6
|
* Allow group reporters to manage group labels33154-permissions-for-project-labels-and-group-labelsSean McGivern2017-06-051-0/+10
| | | | | | | | | Previously, only group masters could do this. However, project reporters can manage project labels, so there doesn't seem to be any need to restrict group labels further. Also, save a query or two by getting a single GroupMember object to find out if the user is a master or not.
* Use CTEs for nested groups and authorizationsYorick Peterse2017-05-171-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit introduces the usage of Common Table Expressions (CTEs) to efficiently retrieve nested group hierarchies, without having to rely on the "routes" table (which is an _incredibly_ inefficient way of getting the data). This requires a patch to ActiveRecord (found in the added initializer) to work properly as ActiveRecord doesn't support WITH statements properly out of the box. Unfortunately MySQL provides no efficient way of getting nested groups. For example, the old routes setup could easily take 5-10 seconds depending on the amount of "routes" in a database. Providing vastly different logic for both MySQL and PostgreSQL will negatively impact the development process. Because of this the various nested groups related methods return empty relations when used in combination with MySQL. For project authorizations the logic is split up into two classes: * Gitlab::ProjectAuthorizations::WithNestedGroups * Gitlab::ProjectAuthorizations::WithoutNestedGroups Both classes get the fresh project authorizations (= as they should be in the "project_authorizations" table), including nested groups if PostgreSQL is used. The logic of these two classes is quite different apart from their public interface. This complicates development a bit, but unfortunately there is no way around this. This commit also introduces Gitlab::GroupHierarchy. This class can be used to get the ancestors and descendants of a base relation, or both by using a UNION. This in turn is used by methods such as: * Namespace#ancestors * Namespace#descendants * User#all_expanded_groups Again this class relies on CTEs and thus only works on PostgreSQL. The Namespace methods will return an empty relation when MySQL is used, while User#all_expanded_groups will return only the groups a user is a direct member of. Performance wise the impact is quite large. For example, on GitLab.com Namespace#descendants used to take around 580 ms to retrieve data for a particular user. Using CTEs we are able to reduce this down to roughly 1 millisecond, returning the exact same data. == On The Fly Refreshing Refreshing of authorizations on the fly (= when users.authorized_projects_populated was not set) is removed with this commit. This simplifies the code, and ensures any queries used for authorizations are not mutated because they are executed in a Rails scope (e.g. Project.visible_to_user). This commit includes a migration to schedule refreshing authorizations for all users, ensuring all of them have their authorizations in place. Said migration schedules users in batches of 5000, with 5 minutes between every batch to smear the load around a bit. == Spec Changes This commit also introduces some changes to various specs. For example, some specs for ProjectTeam assumed that creating a personal project would _not_ lead to the owner having access, which is incorrect. Because we also no longer refresh authorizations on the fly for new users some code had to be added to the "empty_project" factory. This chunk of code ensures that the owner's permissions are refreshed after creating the project, something that is normally done in Projects::CreateService.
* Use relative paths for group/project/user avatarsblackst0ne2017-05-101-4/+5
|
* Refactor add_users method for project and groupdz-cleanup-add-usersDmitriy Zaporozhets2017-04-211-1/+1
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Support 2FA requirement per-groupMarkus Koller2017-04-061-0/+11
|
* Hide ancestor groups in the share group dropdown listdz-hide-share-group-ancestorsDmitriy Zaporozhets2017-03-211-1/+1
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Merge branch 'master' into 'rs-carrierwave-db'rs-carrierwave-dbDouwe Maan2017-03-061-0/+10
|\ | | | | | | # Conflicts: # spec/models/group_spec.rb
| * Merge branch 'master' into zj-create-mattermost-teamZ.J. van de Weg2017-03-061-1/+1
| |\
| * | Improve UXZ.J. van de Weg2017-03-021-0/+10
| | |
| * | Transactional mattermost team creationZ.J. van de Weg2017-02-201-1/+0
| | | | | | | | | | | | | | | | | | | | | Before this commit, but still on this feature branch, the creation of mattermost teams where a background job. However, it was decided it was better that these happened as transaction so feedback could be displayed to the user.
| * | Create MM team for GitLab groupZ.J. van de Weg2017-02-161-0/+1
| | |
* | | Add `has_many` associations for models that can have Upload recordsRobert Speicher2017-03-061-0/+1
| |/ |/|
* | Use string based `visibility` getter & setterToon Claes2017-03-021-1/+1
|/ | | | | | Add `visibility` & `visibility=` methods to the `Gitlab::VisibilityLevel` module so the `visibility_level` can be get/set with a string value.
* Add GFM support to nested groupsdz-nested-groups-gfm-altDmitriy Zaporozhets2017-02-131-1/+1
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Show parent group members for nested groupdz-nested-groups-members-pageDmitriy Zaporozhets2017-02-101-1/+1
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Refresh authorizations when transferring projectsrefresh-permissions-when-moving-projectsYorick Peterse2017-02-071-1/+6
| | | | | | | | This ensures that project authorizations are refreshed when moving a project from one namespace to another. When doing so the permissions for all users of both the old and new namespaces are refreshed. See #26194 for more information.
* Refactor Namespace code related to nested groupsDmitriy Zaporozhets2017-01-131-1/+1
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Fix cross-project references copy to include the project referencefix/cross-project-ref-pathJames Lopez2017-01-031-1/+1
| | | | Also added relevant specs and refactored to_references in a bunch of places to be more consistent.
* Merge branch 'dz-nested-group-access' into 'master' Dmitriy Zaporozhets2016-12-291-4/+14
|\ | | | | | | | | Inherit permissions from parent group See merge request !8071
| * Improve Group#users_with_parents methoddz-nested-group-accessDmitriy Zaporozhets2016-12-291-1/+1
| | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * Include group parents into read access for project and groupDmitriy Zaporozhets2016-12-261-4/+14
| | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* | Add more storage statisticsMarkus Koller2016-12-211-1/+7
|/ | | | | | | | | | | | | This adds counters for build artifacts and LFS objects, and moves the preexisting repository_size and commit_count from the projects table into a new project_statistics table. The counters are displayed in the administration area for projects and groups, and also available through the API for admins (on */all) and normal users (on */owned) The statistics are updated through ProjectCacheWorker, which can now do more granular updates with the new :statistics argument.
View Lorry Controller Status