Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge issuable "reopened" state into "opened"merge-issuable-reopened-into-opened-state | Yorick Peterse | 2017-07-28 | 1 | -3/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Having two states that essentially mean the same thing is very much like having a boolean "true" and boolean "mostly-true": it's rather silly. This commit merges the "reopened" state into the "opened" state while taking care of system notes still showing messages along the lines of "Alice reopened this issue". A big benefit from having only two states (opened and closed) is that indexing and querying becomes simpler and more performant. For example, to get all the opened queries we no longer have to query both states: SELECT * FROM issues WHERE project_id = 2 AND state IN ('opened', 'reopened'); Instead we can query a single state directly, which can be much faster: SELECT * FROM issues WHERE project_id = 2 AND state = 'opened'; Further, only having two states makes indexing easier as we will only ever filter (and thus scan an index) using a single value. Partial indexes could help but aren't supported on MySQL, complicating the development process and not being helpful for MySQL. | ||||
* | fix created_after | James Lopez | 2017-07-07 | 1 | -2/+0 |
| | |||||
* | refactor created at filter to use model scopes | James Lopez | 2017-07-07 | 1 | -0/+1 |
| | |||||
* | Added Cop to blacklist the use of `dependent:` | Yorick Peterse | 2017-07-06 | 1 | -2/+7 |
| | | | | | | | | This is allowed for existing instances so we don't end up 76 offenses right away, but for new code one should _only_ use this if they _have_ to remove non database data. Even then it's usually better to do this in a service class as this gives you more control over how to remove the data (e.g. in bulk). | ||||
* | Add many foreign keys to the projects table | Yorick Peterse | 2017-07-06 | 1 | -1/+1 |
| | | | | | | | | | | | | This removes the need for relying on Rails' "dependent" option for data removal, which is _incredibly_ slow (even when using :delete_all) when deleting large amounts of data. This also ensures data consistency is enforced on DB level and not on application level (something Rails is really bad at). This commit also includes various migrations to add foreign keys to tables that eventually point to "projects" to ensure no rows get orphaned upon removing a project. | ||||
* | Create and use project path helpers that only need a project, no namespace | Douwe Maan | 2017-07-05 | 1 | -5/+1 |
| | |||||
* | Enable Style/DotPosition Rubocop :cop: | Grzegorz Bizon | 2017-06-21 | 1 | -2/+2 |
| | |||||
* | Migration - Remove position field from issues and merge requests | Felipe Artur | 2017-06-16 | 1 | -0/+3 |
| | |||||
* | Order issues by priority | Felipe Artur | 2017-06-16 | 1 | -1/+1 |
| | |||||
* | Enable the Style/PreferredHashMethods coprc/enable-PreferredHashMethods-cop | Rémy Coutable | 2017-06-02 | 1 | -2/+2 |
| | | | | Signed-off-by: Rémy Coutable <remy@rymai.me> | ||||
* | Rename all references to rendered_title to realtime_changesrename-rendered_title | Luke "Jared" Bennett | 2017-05-13 | 1 | -1/+1 |
| | |||||
* | Consistently use monospace font for commit SHAs and branch and tag names | Douwe Maan | 2017-05-12 | 1 | -1/+1 |
| | |||||
* | Backport of multiple_assignees_feature [ci skip] | Valery Sizov | 2017-05-04 | 1 | -3/+32 |
| | |||||
* | Allow to create new branch and empty WIP merge request from issue page | Alfredo Sumaran | 2017-05-04 | 1 | -0/+8 |
| | |||||
* | Fix Error 500 when referencing issue with project in pending deletesh-fix-issue-31215 | Stan Hu | 2017-04-20 | 1 | -1/+1 |
| | | | | Closes #31215 | ||||
* | Remove an unused `cared` scope from Issue and MergeRequestrs-remove-open-for-scope | Robert Speicher | 2017-04-10 | 1 | -1/+0 |
| | |||||
* | Remove an unused `Issue.open_for` scope | Robert Speicher | 2017-04-10 | 1 | -1/+0 |
| | |||||
* | Merge branch 'update-droplab-to-webpack-version' into new-resolvable-discussion | Luke "Jared" Bennett | 2017-04-06 | 1 | -0/+11 |
|\ | |||||
| * | Issue title realtime | Regis Boudinot | 2017-04-06 | 1 | -0/+11 |
| | | |||||
* | | Add option to start a new discussion on an MR | Douwe Maan | 2017-04-05 | 1 | -0/+1 |
|/ | |||||
* | Do not set closed_at to nil when issue is reopenedissue_91_ee_backport | Felipe Artur | 2017-04-04 | 1 | -4/+0 |
| | |||||
* | Spam check only when spammable attributes have changed | Oswaldo Ferreira | 2017-03-21 | 1 | -2/+1 |
| | |||||
* | Add closed_at field to issues | Felipe Artur | 2017-03-17 | 1 | -0/+8 |
| | |||||
* | Merge branch '27271-missing-time-spent-in-issue-webhook' into 'master' | Douwe Maan | 2017-03-15 | 1 | -1/+7 |
|\ | | | | | | | | | | | | | Include time tracking attributes in webhooks payload Closes #27271 See merge request !9942 | ||||
| * | Include time tracking attributes in webhooks payload27271-missing-time-spent-in-issue-webhook | Ruben Davila | 2017-03-14 | 1 | -1/+7 |
| | | |||||
* | | Preserve order by priority on issues boardpreserve_order_issue_board | Valery Sizov | 2017-03-14 | 1 | -0/+7 |
|/ | |||||
* | Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into orderable-issues | Valery Sizov | 2017-02-24 | 1 | -2/+0 |
|\ | |||||
| * | Disable unused tags count cache for Projects, Builds and Runners | Pawel Chojnacki | 2017-02-23 | 1 | -2/+0 |
| | | | | | | | | + remove complete leftover when Issues were tagged using acts_as_taggable | ||||
* | | Allow issues in boards to be ordered | Douwe Maan | 2017-02-17 | 1 | -0/+1 |
|/ | |||||
* | Add commment to Issue, Project and MergeRequest #to_reference | Oswaldo Ferreira | 2017-01-27 | 1 | -0/+1 |
| | |||||
* | Present group and dashboard MR list without grouping by project | Oswaldo Ferreira | 2017-01-27 | 1 | -2/+2 |
| | |||||
* | Refactor Project#to_reference and make full_path a keyword argument | Berna Castro | 2017-01-27 | 1 | -2/+2 |
| | | | | | | | | | | | | Refactor overall code and fix failing specs Fix Project#to_reference Fix wrong spaces and update changelog Refactor #to_reference for Project & Issue Fix and improves Project#to_reference | ||||
* | Fix cross-project references copy to include the project referencefix/cross-project-ref-path | James Lopez | 2017-01-03 | 1 | -2/+2 |
| | | | | Also added relevant specs and refactored to_references in a bunch of places to be more consistent. | ||||
* | Fix N+1 queries on milestone show pages | James Edwards-Jones | 2016-12-20 | 1 | -0/+2 |
| | |||||
* | Merge branch 'jej-24637-move-issue-visible_to_user-to-finder' into 'security' | Sean McGivern | 2016-12-15 | 1 | -55/+0 |
| | | | | | | | Issue#visible_to_user moved to IssuesFinder Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/24637. See merge request !2039 | ||||
* | Add shorthand support to gitlab markdown references | Oswaldo Ferreira | 2016-12-02 | 1 | -5/+1 |
| | |||||
* | Merge branch 'events-cache-invalidation' into 'master' | Douwe Maan | 2016-11-28 | 1 | -12/+0 |
|\ | | | | | | | | | | | | | Remove caching of events data This MR removes the caching of events data as this was deemed unnecessary while increasing load on the database. See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6578#note_18864037 and 5371da341e9d7768ebab8e159b3e2cc8fad1d827 for more information. See merge request !6578 | ||||
| * | Remove event caching code | Yorick Peterse | 2016-11-23 | 1 | -12/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Flushing the events cache worked by updating a recent number of rows in the "events" table. This has the result that on PostgreSQL a lot of dead tuples are produced on a regular basis. This in turn means that PostgreSQL will spend considerable amounts of time vacuuming this table. This in turn can lead to an increase of database load. For GitLab.com we measured the impact of not using events caching and found no measurable increase in response timings. Meanwhile not flushing the events cache lead to the "events" table having no more dead tuples as now rows are only inserted into this table. As a result of this we are hereby removing events caching as it does not appear to help and only increases database load. For more information see the following comment: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6578#note_18864037 | ||||
* | | Drop Project#authorized_for_user? in favor of ProjectTeam#member? | Ahmad Sherif | 2016-11-23 | 1 | -1/+1 |
|/ | | | | Closes #23938 | ||||
* | Remove default value for `project` argument on subscribable concern | Douglas Barbosa Alexandre | 2016-11-17 | 1 | -1/+1 |
| | |||||
* | Fixed issue boards when not logged inissue-boards-signed-out-state | Phil Hughes | 2016-11-14 | 1 | -1/+1 |
| | |||||
* | Merge branch 'issue_23548_dev' into 'master' | Douwe Maan | 2016-11-09 | 1 | -22/+30 |
| | | | | | | | | | | | | | | | | | | | | | disable markdown in comments when referencing disabled features fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/23548 This MR prevents the following references when tool is disabled: - issues - snippets - commits - when repo is disabled - commit range - when repo is disabled - milestones This MR does not prevent references to repository files, since they are just markdown links and don't leak information. See merge request !2011 Signed-off-by: Rémy Coutable <remy@rymai.me> | ||||
* | add "x of y tasks completed" on issuable | Guilherme Salazar | 2016-10-28 | 1 | -1/+0 |
| | | | | | | fix issues pointed out in !6527 add task completion status feature to CHANGELOG | ||||
* | Merge branch 'master' into issue-board-sidebarissue-board-sidebar | Phil Hughes | 2016-10-26 | 1 | -1/+7 |
|\ | |||||
| * | Use MergeRequestsClosingIssues cache data on Issue#closed_by_merge_requests ↵14192-issues-closed-by-merge-requests-using-metrics-data | Paco Guzman | 2016-10-20 | 1 | -1/+7 |
| | | | | | | | | method | ||||
* | | Merge branch 'master' into issue-board-sidebar | Phil Hughes | 2016-10-19 | 1 | -0/+12 |
|\ \ | |/ | |||||
| * | Add self.project_foreign_key on both Issue and MergeRequest | Douglas Barbosa Alexandre | 2016-10-19 | 1 | -0/+4 |
| | | |||||
| * | Fix issue board related controllers to expose label priority per project | Douglas Barbosa Alexandre | 2016-10-19 | 1 | -0/+12 |
| | | |||||
* | | Restore subscribe status in JSON | Phil Hughes | 2016-10-07 | 1 | -0/+6 |
|/ | |||||
* | Use the `IssuableBaseService` lifecycle hooks to cache ↵ | Timothy Andrew | 2016-09-21 | 1 | -1/+1 |
| | | | | | | | `MergeRequestsClosingIssues` - Instead of overriding `create` and `update` in `MergeRequests::BaseService` - Get all merge request service specs passing |