Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Remove `projects` inclusion in `notes_with_associations` to skip some ↵ | Alejandro Rodríguez | 2016-06-08 | 1 | -1/+1 |
| | | | | | | | | | | | | | | unnecessary queries `notes_with_associations` are used for `participant` declarations, but `Participable` only really cares about the target entity project, and not the participants projects. `notes_with_associations` are also used in `Commit::has_been_reverted?` which employs the reference extractor of the commit, so no references to the notes projects are made there (`Mentionable::all_references` cares only about the `author` and other `attr_mentionable`). A paralel situation occurs on `Issue::referenced_merge_requests`. | ||||
* | Refactor Participable | Yorick Peterse | 2016-06-01 | 1 | -1/+6 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are several changes to this module: 1. The use of an explicit stack in Participable#participants 2. Proc behaviour has been changed 3. Batch permissions checking == Explicit Stack Participable#participants no longer uses recursion to process "self" and all child objects, instead it uses an Array and processes objects in breadth-first order. This allows us to for example create a single Gitlab::ReferenceExtractor instance and pass this to any Procs. Re-using a ReferenceExtractor removes the need for running potentially many SQL queries every time a Proc is called on a new object. == Proc Behaviour Changed Previously a Proc in Participable was expected to return an Array of User instances. This has been changed and instead it's now expected that a Proc modifies the Gitlab::ReferenceExtractor passed to it. The return value of the Proc is ignored. == Permissions Checking The method Participable#participants uses Ability.users_that_can_read_project to check if the returned users have access to the project of "self" _without_ running multiple SQL queries for every user. | ||||
* | Remove the annotate gem and delete old annotations | Jeroen van Baarsen | 2016-05-09 | 1 | -16/+0 |
| | | | | | | | | | In 8278b763d96ef10c6494409b18b7eb541463af29 the default behaviour of annotation has changes, which was causing a lot of noise in diffs. We decided in #17382 that it is better to get rid of the whole annotate gem, and instead let people look at schema.rb for the columns in a table. Fixes: #17382 | ||||
* | Annotate the models | Zeger-Jan van de Weg | 2016-05-06 | 1 | -3/+3 |
| | |||||
* | Properly handle bigger files | Zeger-Jan van de Weg | 2016-04-28 | 1 | -0/+4 |
| | |||||
* | Memoize reference_pattern/link_reference_patternmemoize-pattern-methods | Yorick Peterse | 2016-04-01 | 1 | -2/+2 |
| | | | | | These methods are called quite often in loops so by memoizing their output we can reduce timings a bit. | ||||
* | Removed arel_table receiver from search methods | Yorick Peterse | 2016-03-11 | 1 | -1/+1 |
| | | | | | We can just use "arel_table" in these cases instead of "SomeClass.arel_table". | ||||
* | Use ILIKE/LIKE for searching snippets | Yorick Peterse | 2016-03-11 | 1 | -2/+22 |
| | | | | | | Previously this used a regular LIKE which is case-sensitive on PostgreSQL. This ensures that for both PostgreSQL and MySQL the searching is case-insensitive similar to searching for projects. | ||||
* | Remove `Snippet#expires_at`rs-snippets-dont-expire | Robert Speicher | 2016-03-05 | 1 | -7/+0 |
| | | | | | | This was removed from the interface in https://github.com/gitlabhq/gitlabhq/pull/6027 but its implementation lingered around for two years. | ||||
* | Autolink first so we don't pick up numeric anchors as issue references. | Douwe Maan | 2015-12-01 | 1 | -5/+2 |
| | |||||
* | Recognize issue/MR/snippet/commit links as references. | Douwe Maan | 2015-11-30 | 1 | -2/+9 |
| | |||||
* | Make snippet filename optional. | Nicolas | 2015-06-20 | 1 | -1/+0 |
| | | | | Fixes #2384. | ||||
* | Surround Project.reference_pattern in parenthesis inside other patterns | Robert Speicher | 2015-05-26 | 1 | -1/+1 |
| | |||||
* | Add `reference_pattern` to Referable models | Robert Speicher | 2015-05-26 | 1 | -0/+10 |
| | |||||
* | Minor model spec cleanups | Robert Speicher | 2015-05-26 | 1 | -1/+2 |
| | | | | Snippet model was missing project association | ||||
* | Add `to_reference` for models that support references | Robert Speicher | 2015-05-26 | 1 | -2/+17 |
| | | | | | Now there is a single source of information for which attribute a model uses to be referenced, and its special character. | ||||
* | Move participants method to shared Participable concern. | Douwe Maan | 2015-04-24 | 1 | -12/+3 |
| | |||||
* | Clean up code somewhat.better-commit-mentions | Douwe Maan | 2015-04-17 | 1 | -4/+2 |
| | |||||
* | Fix Snippet#participants. | Douwe Maan | 2015-04-15 | 1 | -0/+2 |
| | |||||
* | Include snippet author in recipients of snippet note notification. | Douwe Maan | 2015-04-15 | 1 | -0/+12 |
| | |||||
* | Use more specific regexes. | Douwe Maan | 2015-03-27 | 1 | -2/+2 |
| | |||||
* | Added comment notification events to HipChat and Slack services. | Stan Hu | 2015-03-06 | 1 | -0/+4 |
| | | | | | | | | | Supports four different event types all bundled under the "note" event type: - comments on a commit - comments on an issue - comments on a merge request - comments on a code snippet | ||||
* | Explicitly define ordering in models using default_scope | Dmitriy Zaporozhets | 2015-02-05 | 1 | -0/+1 |
| | |||||
* | Rubocop: Style/AlignHash enabled | Dmitriy Zaporozhets | 2015-02-02 | 1 | -3/+5 |
| | |||||
* | Sanitize snippet file name in raw headers | Dmitriy Zaporozhets | 2014-12-12 | 1 | -0/+4 |
| | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | ||||
* | Add strict validation to snippet file names | Dmitriy Zaporozhets | 2014-12-12 | 1 | -2/+4 |
| | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | ||||
* | annotate | Valery Sizov | 2014-10-09 | 1 | -11/+11 |
| | |||||
* | Snippets: public/internal/private | Valery Sizov | 2014-10-09 | 1 | -4/+12 |
| | |||||
* | Snippets: rename public to internal | Valery Sizov | 2014-10-07 | 1 | -1/+1 |
| | |||||
* | Adding in snippet search functionality | Charles Bushong | 2014-08-29 | 1 | -0/+14 |
| | | | | http://feedback.gitlab.com/forums/176466-general/suggestions/5529795-search-though-snippets | ||||
* | Project hook, milestone, snippet strong params | Dmitriy Zaporozhets | 2014-06-26 | 1 | -2/+0 |
| | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | ||||
* | User model to strong params. Comment other attr_accessible to let tests run | Dmitriy Zaporozhets | 2014-06-26 | 1 | -1/+1 |
| | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | ||||
* | Rename snippets scopes to plural names. | Marin Jankovski | 2014-06-04 | 1 | -2/+2 |
| | |||||
* | Replace now forbidden keywords public and private for snippets scope | Marin Jankovski | 2014-06-03 | 1 | -2/+2 |
| | |||||
* | Re-annotate models | Dmitriy Zaporozhets | 2014-04-09 | 1 | -3/+3 |
| | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | ||||
* | Default value for Snippet#private | Dmitriy Zaporozhets | 2014-03-17 | 1 | -0/+2 |
| | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | ||||
* | Reannotate | Dmitriy Zaporozhets | 2013-08-21 | 1 | -3/+3 |
| | |||||
* | Annotated | Dmitriy Zaporozhets | 2013-06-19 | 1 | -4/+5 |
| | |||||
* | Notes fixed | Andrew8xx8 | 2013-03-25 | 1 | -0/+1 |
| | |||||
* | It's better to use STI instead | Andrew8xx8 | 2013-03-25 | 1 | -1/+0 |
| | |||||
* | Additional scopes added | Andrew8xx8 | 2013-03-25 | 1 | -2/+5 |
| | |||||
* | Private added to attr_accessible | Andrew8xx8 | 2013-03-25 | 1 | -1/+1 |
| | |||||
* | Project snippet moved to separate model | Andrew8xx8 | 2013-03-24 | 1 | -3/+2 |
| | |||||
* | All scopes must be in lambdas | Andrew8xx8 | 2013-02-12 | 1 | -3/+3 |
| | |||||
* | remove length of snippet content | Valeriy Sizov | 2013-01-22 | 1 | -1/+1 |
| | |||||
* | Rework of milestones | Dmitriy Zaporozhets | 2012-12-14 | 1 | -1/+1 |
| | |||||
* | Annotated. schema updated | Dmitriy Zaporozhets | 2012-11-19 | 1 | -16/+15 |
| | |||||
* | Annotated | Dmitriy Zaporozhets | 2012-10-09 | 1 | -0/+1 |
| | |||||
* | simple refactoring | Andrey Kumanyaev | 2012-10-09 | 1 | -1/+3 |
| | |||||
* | cosmetical cleanup of models | Nihad Abbasov | 2012-09-27 | 1 | -19/+6 |
| |