| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |\
| |
| |
| |
| |
| |
| | |
Add API support for pipeline schedule
Closes #30892
See merge request !11307
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Resolve "Allow to disable username on checkout url"
Closes #30410 and #30174
See merge request !11792
|
| | | |
| | |
| | |
| | |
| | |
| | | |
This partially reverts be25bbc4d2c7e3d5cf3da6f51cb7f7355295ef52.
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit c425f366bfa84efab92b5d5e1d0721f16a2890bc, reversing
changes made to 82f6c0f5ac4ed29390ed90592d2c431f3494d93f.
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
| | |/
|/| |
|
| |\ \
| |/
|/|
| |
| |
| |
| |
| |
| | |
'19107-404-when-creating-new-milestone-or-issue-for-project-that-has-issues-disabled' into 'master'
'New issue'/'New merge request' dropdowns should show only projects with issues/merge requests feature enabled
Closes #19107
See merge request !11754
|
| | |
| |
| |
| | |
issues/merge requests feature enabled
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Resolve "pipeline_schedules pages throwing error 500"
Closes #32790
See merge request !11706
|
| | |/ |
|
| |\ \
| | |
| | |
| | |
| | | |
Rework project authorizations and nested groups for better performance
See merge request !10885
|
| | | |
| | |
| | |
| | |
| | |
| | | |
This hides/disables some UI elements and API parameters related to
nested groups when MySQL is used, since nested groups are not supported
for MySQL.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit introduces the usage of Common Table Expressions (CTEs) to
efficiently retrieve nested group hierarchies, without having to rely on
the "routes" table (which is an _incredibly_ inefficient way of getting
the data). This requires a patch to ActiveRecord (found in the added
initializer) to work properly as ActiveRecord doesn't support WITH
statements properly out of the box.
Unfortunately MySQL provides no efficient way of getting nested groups.
For example, the old routes setup could easily take 5-10 seconds
depending on the amount of "routes" in a database. Providing vastly
different logic for both MySQL and PostgreSQL will negatively impact the
development process. Because of this the various nested groups related
methods return empty relations when used in combination with MySQL.
For project authorizations the logic is split up into two classes:
* Gitlab::ProjectAuthorizations::WithNestedGroups
* Gitlab::ProjectAuthorizations::WithoutNestedGroups
Both classes get the fresh project authorizations (= as they should be
in the "project_authorizations" table), including nested groups if
PostgreSQL is used. The logic of these two classes is quite different
apart from their public interface. This complicates development a bit,
but unfortunately there is no way around this.
This commit also introduces Gitlab::GroupHierarchy. This class can be
used to get the ancestors and descendants of a base relation, or both by
using a UNION. This in turn is used by methods such as:
* Namespace#ancestors
* Namespace#descendants
* User#all_expanded_groups
Again this class relies on CTEs and thus only works on PostgreSQL. The
Namespace methods will return an empty relation when MySQL is used,
while User#all_expanded_groups will return only the groups a user is a
direct member of.
Performance wise the impact is quite large. For example, on GitLab.com
Namespace#descendants used to take around 580 ms to retrieve data for a
particular user. Using CTEs we are able to reduce this down to roughly 1
millisecond, returning the exact same data.
== On The Fly Refreshing
Refreshing of authorizations on the fly (= when
users.authorized_projects_populated was not set) is removed with this
commit. This simplifies the code, and ensures any queries used for
authorizations are not mutated because they are executed in a Rails
scope (e.g. Project.visible_to_user).
This commit includes a migration to schedule refreshing authorizations
for all users, ensuring all of them have their authorizations in place.
Said migration schedules users in batches of 5000, with 5 minutes
between every batch to smear the load around a bit.
== Spec Changes
This commit also introduces some changes to various specs. For example,
some specs for ProjectTeam assumed that creating a personal project
would _not_ lead to the owner having access, which is incorrect. Because
we also no longer refresh authorizations on the fly for new users some
code had to be added to the "empty_project" factory. This chunk of code
ensures that the owner's permissions are refreshed after creating the
project, something that is normally done in Projects::CreateService.
|
| | |/
|/| |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Fix counter cache invalidation
Closes #32854 and #32870
See merge request !11736
|
| | | | |
|
| |/ / |
|
| |\ \
| | |
| | |
| | |
| | | |
Clean up diff rendering
See merge request !11390
|
| | | | |
|
| | | | |
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Provide default for calculating label text color
Closes #32728
See merge request !11681
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Refactor `DynamicPathValidator` and `GitLab::Regex` some more
See merge request !11693
|
| | | | | |
| | | | |
| | | | | |
This reverts commit b0498c176fa134761d899c9b369be12f1ca789c5
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fix terminals support for Kubernetes service
Closes #31754
See merge request !11653
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
It was broken, because we introduced a default namespace, which was not used by terminal methods.
|
| |\ \ \ \ \ \
| |/ / / / /
|/| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Implement Web Hooks calls logging
Closes #17848
See merge request !11027
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* implemented logging of project and system web hooks
* implemented UI for user area (project hooks)
* implemented UI for admin area (system hooks)
* implemented retry of logged webhook
* NOT imeplemented log remover
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
we do this on attribute read since migrating all existing users is not a
feasible solution.
|
| | |/ / / /
|/| | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Add system note with link to diff comparison when MR discussion becomes outdated
Closes #30058
See merge request !11584
|
| | | | | | | |
|
| | | | | | | |
|
| | | |_|/ /
| |/| | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fix ambiguous routing issues by teaching router about reserved words
See merge request !11570
|
| | | | | | | |
|
| | | |_|/ /
| |/| | | |
|
| |\ \ \ \ \
| |_|/ / /
|/| | | |
| | | | |
| | | | | |
Rescue OpenSSL::SSL::SSLError in JiraService
See merge request !11467
|
| | | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | | |
Add OpenSSL::SSL::SSLError to rescue in JiraService & IssueTrackerService. This
will prevent an exception in production and instead display
a message to the user.
|
| | | | |
| | | |
| | | |
| | | | |
These were untested by the cherry picked commit.
|
| | |/ /
|/| | |
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Remove readme project_view option
See merge request !11425
|
| | | | | |
|
| |\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
Render plain README using Markup viewer so it is displayed below tree
See merge request !11510
|
