| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
| |
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
|
| |\
| |
| |
| |
| |
| |
| | |
SSH public-key authentication for push mirroring
Closes #49565
See merge request gitlab-org/gitlab-ce!22982
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Change project cache key to depend on ID instead of full path
Closes #42191
See merge request gitlab-org/gitlab-ce!23135
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Rails5 deprecation: Passing a class as a value in an Active Record query is deprecated
See merge request gitlab-org/gitlab-ce!23164
|
| | | |/
| |/| |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Match users better by their private commit email
Closes #54046
See merge request gitlab-org/gitlab-ce!23080
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Private commit emails were introduced in !22560, but some parts of
GitLab were not updated to take account of them. This commit adds
support in places that were missed.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Improve variables support
See merge request gitlab-org/gitlab-ce!23077
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This ensures that variables accept only string,
alongside also improves kubernetes_namespace,
improving validation and default value being set.
|
| | |/ / /
|/| | | |
|
| |\ \ \ \
| |_|/ /
|/| | |
| | | |
| | | | |
Refactor Member#add_user for GitLab EE
See merge request gitlab-org/gitlab-ce!23119
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
GitLab EE extends Member#add_user by adding some LDAP specific flags.
Prior to these changes, the only way this could be done was by modifying
Member#add_user in place. This could lead to merge conflicts whenever a
developer wants to change this method.
To resolve this issue, the logic that EE extends has been moved into a
separate method with the appropriate arguments. This allows EE to extend
the logic by prepending the method using an EE specific module.
|
| |\ \ \ \
| |_|_|/
|/| | |
| | | |
| | | |
| | | |
| | | | |
Hashed Storage: allow migration to be retried in partially migrated projects
Closes #53700
See merge request gitlab-org/gitlab-ce!23087
|
| | |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Previously we verified if the projecthave at least migrated their
repository to hashed storage and prevented the migration command to
start a new migration.
The new version checks for the latest storage version available
(fully migrated), otherwise it allows migration to be triggered again.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Refactor how a few ActiveRecord enums are defined
See merge request gitlab-org/gitlab-ce!23024
|
| | |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In a few models we define ActiveRecord enums that are redefined in EE
using the following pattern:
enum :some_enum, {
...
}.merge(EE_ENUM_VALUES)
This particular approach is problematic to deal with, because it
requires that we `prepend` and EE module _before_ defining the enum.
This typically translates to the `prepend` being the first line in the
model in EE, but this can easily lead to merge conflicts when developers
add more `include` and/or `prepend` lines.
As part of https://gitlab.com/gitlab-org/gitlab-ee/issues/8244 and
https://gitlab.com/gitlab-org/gitlab-ee/issues/8241 we are moving
`prepend` to the last line in a file, reducing the chances of running
into merge conflicts. This poses a bit of a problem with the pattern
above, because this pattern does not allow us to move the `prepend`
further down a file.
To resolve this problem, we simply move the Hash value of the enum to a
separate class method. This method is defined in a separate module where
necessary, allowing us to use it like so:
enum :failure_reasons, ::SomeModelEnums.failure_reasons
The method in turn is defined in a very straightforward manner:
module SomeModelEnums
def self.failure_reasons
{
...
}
end
end
This makes it easy for EE to add values without requiring the `prepend`
to be placed before the `enum` is defined.
For more information, see the following issues and merge requests:
* https://gitlab.com/gitlab-org/gitlab-ee/issues/8244
* https://gitlab.com/gitlab-org/gitlab-ee/issues/8241
* https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8424
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Resolve "Upgrade Helm Tiller Version Used By GitLab Managed Apps"
Closes #49726
See merge request gitlab-org/gitlab-ce!22693
|
| | | | | |
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Resolve "Can merge branch before build is started"
Closes #28682
See merge request gitlab-org/gitlab-ce!22911
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Backport ServiceHook#execute from EE
See merge request gitlab-org/gitlab-ce!23122
|
| | | |_|/ /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
In EE this method takes an additional argument that specifies the name
of the hook to trigger. There is no particular reason to not backport
this to CE, since by default the behaviour remains the same. By
backporting this code we remove the need for prepending ServiceHook with
a module in EE.
|
| |/ / / / |
|
| | |_|/
|/| | |
|
| | | | |
|
| | | |
| | |
| | |
| | | |
In Rails 5 all models by default inherit from ApplicationRecord.
|
| | | |
| | |
| | |
| | | |
not successful
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Refactor reference regexes and identity scopes
See merge request gitlab-org/gitlab-ce!22987
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Moving this method to a separate module looks a bit odd, but it allows
for EE to extend the method without also having to redefine a variety of
validation rules.
|
| | | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
`Mentionable::ReferenceRegexes` used to define the following two
constants:
1. DEFAULT_PATTERN
2. EXTERNAL_PATTERN
These two constants were built using some of the class methods that
reside in this same module. In EE we redefine one of these methods by
using `prepend` at the start of the `ReferenceRegexes` module. This
poses a problem: we can not move the `prepend` to the end of the file,
because the constants later on depend on it.
To resolve this problem, this commit turns these constants into class
methods that memoize their results. This allows EE to redefine the
appropriate methods before these two class methods are used, in turn
allowing us to move the `prepend` to the end of the file.
See https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8198 for more
information.
|
| | | | |
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fix tags for environments
Closes gitlab-ee#8397
See merge request gitlab-org/gitlab-ce!22993
|
| | | | | |
|
| | | |/
| |/| |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Make sure there's only one slash as path separator
Closes #53180
See merge request gitlab-org/gitlab-ce!22954
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In Ruby 2.4, `URI.join("http://test//", "a").to_s` will
remove the double slash, however it's not the case in
Ruby 2.5. Using chomp should work better for the intention,
as we're not trying to allow things like ../ or / paths
resolution.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53180
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When a branch is deleted, the push commit IDs is an empty array.
The previous change would attempt to call `[].exists?`, which is
invalid. Fix this by returning `MergeRequestDiffCommit.none` instead.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53853
|
| |\ \ \ \
| |_|_|/
|/| | |
| | | |
| | | |
| | | |
| | | | |
Comment on any expanded diff line on MRs (with feature-flag)
Closes #13950
See merge request gitlab-org/gitlab-ce!22914
|
| | | |/
| |/| |
|
| |\ \ \
| |_|/
|/| |
| | |
| | |
| | |
| | | |
Add Discord integration
Closes #21635
See merge request gitlab-org/gitlab-ce!22684
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
