| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prior to GitLab 9.0, attachments were not tracked the `uploads` table,
so it was possible that the appearance logos were just stored in the
database as a string and mounted via CarrierWave.
https://gitlab.com/gitlab-org/gitlab-ce/issues/29240 implemented in
GitLab 10.3 was supposed to cover populating the `uploads` table for all
attachments, including all the logos from appearances. However, it's
possible that didn't work for logos or the `uploads` entry was orphaned.
GitLab instances that had a customized logo with no associated `uploads`
entry would see Error 500s. The only way to fix this is to delete the
`logo` column from the `appearances` table and re-upload the attachment.
This change makes things more robust by falling back to the original
behavior if the upload is not available.
This is a CE backport of
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9277.
Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/9357
|
| |
|
|
|
|
|
| |
This is the 1st step for moving Auto DevOps domain into cluster
settings, whether is project or group.
Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/52363
|
| |\
| |
| |
| |
| |
| |
| | |
Hashed Storage: `AfterRenameService` was not renaming Pages or Uploads folder on legacy storage
Closes #56636
See merge request gitlab-org/gitlab-ce!24526
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We still rely on the Dirty API for project rename (before/after) values,
but we don't access the dirty api from the service class anymore.
The previous value is now part of the initialization, which makes it
easier to test and the behavior is clearer.
The same was done with the `rename_repo` on the Storage classes, we now
provide before and after values as part of the method signature.
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Resolve "Inconsistent text color for labels"
Closes #53714
See merge request gitlab-org/gitlab-ce!23873
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
In different parts of the application, the same label was being rendered
with a different foreground color. This was due to the "textColor" JSON
property not being generated by the backend. This commit adds
this property to JSON representation of labels.
|
| |\ \ \
| |_|/
|/| |
| | |
| | |
| | |
| | | |
Resolve "Don't check confidential issues for spam"
Closes #56371
See merge request gitlab-org/gitlab-ce!24453
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Spam checks are meant for content that could be indexed by search
engines. Confidential issues aren't indexed by search engines, so we
don't need to do spam checks for them.
We do need to check for spam when an issue changes from confidential to
public, even if nothing else changed.
|
| |\ \ \
| |_|/
|/| |
| | |
| | |
| | |
| | | |
Return the maximum group access level in the projects API
Closes #43684
See merge request gitlab-org/gitlab-ce!24403
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Currently if a project is inside a nested group and a user doesn't have
specific permissions for that group but does have permissions on a
parent group the `GET /projects/:id` API call will return the following
permissions:
```json
permissions: { project_access: null, group_access: null }
```
It could also happen that the group specific permissions are of lower
level than the ones the user has in parent groups. This patch makes it
so that the permission returned for `group_access` is the highest from
amongst the hierarchy, which is (ostensibly) the information that the
API user is interested in for that field.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Add spec
Add changelog
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Port generic Helm upgrade functionality to CE
See merge request gitlab-org/gitlab-ce!23924
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- #update_errored? method def is redundant, already defined from state
machine
- #update_in_progress? moved to ApplicationStatus
- #ready_status becomes a constant. Previously it was extended in ee/ so
maybe that was why it's a instance method
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Port from EE generic upgrade related functionality used to upgrade Helm
applications
Remove memoization which could be incorrect
It looks like we are memoizing without regard to the method's argument
so this could result in an incorrect upgrade_command
Remove `const_get` indirection now we are no longer in EE
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Markdown footnotes not working
Closes #26375
See merge request gitlab-org/gitlab-ce!24168
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Since the rendering of footnotes is changed, the cached
html need to be updated
|
| |\ \ \ \ \
| |_|_|_|/
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Improve MilestonesFinder to accept project and group relations
Closes #47988
See merge request gitlab-org/gitlab-ce!24325
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Instead of querying relations into ids we just pass them to the model
scope because the scope supports it now.
Also changes other calls to `Milestone.for_projects_and_groups`
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Refactor checking personal project limits
See merge request gitlab-org/gitlab-ce!24396
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This refactors the code used for checking if a user has exceeded the
personal projects limit. As part of this refactor the method has been
renamed from Project#check_limit to "check_personal_projects_limit", as
this name makes it much more clear what the purpose of the method is.
Standalone unit tests have also been added, as before we only had a
single generic validation test that did not cover all cases.
The old implementation of the refactored method also included a `rescue`
statement. This code would only run when a project creator was not set.
The error that would be added wasn't super useful, especially since
there would already be errors for the creator not being present. As none
of the other code in the "check_personal_projects_limit" raises, it has
been removed.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Refactor Project#after_create_default_branch
See merge request gitlab-org/gitlab-ce!24329
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This refactors some of the logic used for protecting default branches,
in particular Project#after_create_default_branch. The logic for this
method is moved into a separate service class. Ideally we'd get rid of
Project#after_create_default_branch entirely, but unfortunately
Project#after_import depends on it. This means it has to stick around
until we also refactor Project#after_import.
For branch protection levels we introduce
Gitlab::Access::BranchProtection, which provides a small wrapper around
Integer based branch protection levels. Using this class removes the
need for having to constantly refer to Gitlab::Access::PROTECTION_*
constants.
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Enable Gitlab-Pages for subgroups
See merge request gitlab-org/gitlab-ce!23505
|
| | | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
GitLab Pages supports projects hosted under a subgroup, but not subgroup
websites. That means that only the highest-level group supports
i.e.:
You created a group for your engineering department called
`engineering`, a subgroup for all your documentation websites called
`docs`,and a project within this subgroup is called `workflows`.
Your project URL is `https://gitlab.com/engineering/docs/workflows/`.
Once you enable GitLab Pages for this project, the site will live under
`https://engineering.gitlab.io/docs/workflows`.
|
| | | | | | | | | |
|
| |\ \ \ \ \ \ \ \
| |_|_|_|_|_|_|/
|/| | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Only send one notification for failed remote mirror
Closes #56222
See merge request gitlab-org/gitlab-ce!24381
|
| | | |_|/ / / /
| |/| | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Retries in Sidekiq and in the remote mirror scheduler can cause repeated
attempts in quick succession if the sync fails. Each failure will then
send an e-mail to all project maintainers, which can spam users
unnecessarily.
Modify the logic to send one notification the first time the mirror
fails by setting `error_notification_sent` to `true` and reset the
flag after a successful sync.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56222
|
| |/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This backports changes made in
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9134.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Ensure pool participants are linked before GC
Closes gitaly#1354
See merge request gitlab-org/gitlab-ce!24230
|
| | |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
In theory the case could happen that the initial linking of the pool
fails and so do all the retries that Sidekiq performs. This could lead
to data loss.
To prevent that case, linking is done before Gits GC too. This makes
sure that case doesn't happen.
|
| |\ \ \ \ \ \
| |_|/ / / /
|/| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Adjust applied suggestion reverting previous changes
Closes #56017
See merge request gitlab-org/gitlab-ce!24250
|
| | | |_|/ /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
1. Avoid suggestions being applied on the same file
from reverting previous changes
2. Gracefully use and handle file changes error
when updating the file (though, it does not totally
solves the sync problem for multiple suggestion
applications at once)
|
| |\ \ \ \ \
| |_|/ / /
|/| | | |
| | | | |
| | | | | |
Bump nginx-ingress chart to 1.1.2
See merge request gitlab-org/gitlab-ce!24203
|
| | | |_|/
| |/| | |
|
| | |_|/
|/| |
| | |
| | | |
now deprecated
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Remove get_build method for find_by_id
See merge request gitlab-org/gitlab-ce!24271
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The original intention of `get_build` was as a workaround not to violate
`CodeReuse/ActiveRecord`. `find_by_id` does the exact same thing but
does not violate the rubocop rule.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fix unexpected exception by failure of finding an actual head pipeline
Closes #56113
See merge request gitlab-org/gitlab-ce!24257
|
| | | |/ /
| |/| |
| | | |
| | | | |
Add changelog
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Nullify pool_repository when a project leaves
See merge request gitlab-org/gitlab-ce!24225
|
| | | |_|/
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | | |
Previously the nullification wasn't done, as the only caller would later
destroy the model all together. In
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9070 this change
was made. This commit is basically a backport before that MR is merged.
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Add group milestones in upcoming filter
Closes #53431
See merge request gitlab-org/gitlab-ce!23098
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Refactored to use Rails 5 ActiveRecord `or` so that it can handle ids,
objects, array of objects, or relations properly.
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Initial Serverless Functions detailed view
See merge request gitlab-org/gitlab-ce!23863
|
| | | |/ / /
| |/| | | |
|
| | | | | | |
|
| |\ \ \ \ \
| |_|_|/ /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
'add-uniqueness-validation-to-url-column-in-releases-link-model' into 'master'
Add uniqueness validation to url column in Releases::Link model
Closes #55929
See merge request gitlab-org/gitlab-ce!24223
|
