Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | `current_application_settings` belongs on `Gitlab::CurrentSettings` | Sean McGivern | 2017-08-31 | 1 | -3/+1 |
| | | | | | | | | | | | | | | | | The initializers including this were doing so at the top level, so every object loaded after them had a `current_application_settings` method. However, if someone had rack-attack enabled (which was loaded before these initializers), it would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't have that method. To fix this: 1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need `Object.new.current_application_settings` to work. 2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it like that in several places. 3. Change the initializers to use that new form. | ||||
* | Merge remote-tracking branch 'origin/master' into ↵ | Timothy Andrew | 2017-06-30 | 1 | -125/+12 |
|\ | | | | | | | | | | | | | 34141-allow-unauthenticated-access-to-the-users-api - Modify policy code to work with the `DeclarativePolicy` refactor in 37c401433b76170f0150d70865f1f4584db01fa8. | ||||
| * | bugfix: use `require_dependency` to bring in DeclarativePolicybugfix/declarative-policy-reloading | http://jneen.net/ | 2017-06-29 | 1 | -1/+1 |
| | | |||||
| * | convert all the policies to DeclarativePolicy | http://jneen.net/ | 2017-06-27 | 1 | -123/+9 |
| | | |||||
* | | Implement review comments for !12445 from @godfat and @rymai. | Timothy Andrew | 2017-06-30 | 1 | -0/+6 |
|/ | | | | | | | | | | | | | | | - Use `GlobalPolicy` to authorize the users that a non-authenticated user can fetch from `/api/v4/users`. We allow access if the `Gitlab::VisibilityLevel::PUBLIC` visibility level is not restricted. - Further, as before, `/api/v4/users` is only accessible to unauthenticated users if the `username` parameter is passed. - Turn off `authenticate!` for the `/api/v4/users` endpoint by matching on the actual route + method, rather than the description. - Change the type of `current_user` check in `UsersFinder` to be more compatible with EE. | ||||
* | Do not inherit build policy in pipeline policy | Grzegorz Bizon | 2017-04-12 | 1 | -0/+4 |
| | |||||
* | use a magic default :global symbol instead of nil | http://jneen.net/ | 2017-03-09 | 1 | -2/+7 |
| | | | | to make sure we mean the global permissions | ||||
* | Enable Rails/Delegate | Douwe Maan | 2017-02-23 | 1 | -3/+1 |
| | |||||
* | More improvements to presenters23563-document-presenters | Rémy Coutable | 2017-01-18 | 1 | -1/+1 |
| | | | | Signed-off-by: Rémy Coutable <remy@rymai.me> | ||||
* | Handle presenters in BasePolicy | Rémy Coutable | 2017-01-18 | 1 | -0/+4 |
| | | | | Signed-off-by: Rémy Coutable <remy@rymai.me> | ||||
* | s/NB:/NOTE:/ | http://jneen.net/ | 2016-08-30 | 1 | -1/+1 |
| | |||||
* | implement RuleSet#size for tests | http://jneen.net/ | 2016-08-30 | 1 | -0/+4 |
| | |||||
* | factor out a RuleSet so that `delegate!` retains @cannot | http://jneen.net/ | 2016-08-30 | 1 | -8/+50 |
| | |||||
* | special-case blocked users | http://jneen.net/ | 2016-08-30 | 1 | -0/+1 |
| | |||||
* | use the cached abilities in #delegate! | http://jneen.net/ | 2016-08-30 | 1 | -1/+1 |
| | |||||
* | factor in global permissions | http://jneen.net/ | 2016-08-30 | 1 | -2/+2 |
| | |||||
* | add automatic detection of the policy class | http://jneen.net/ | 2016-08-30 | 1 | -1/+15 |
| | |||||
* | port CommitStatus/Build | http://jneen.net/ | 2016-08-30 | 1 | -0/+4 |
| | |||||
* | port issues to Issu{able,e}Policy | http://jneen.net/ | 2016-08-30 | 1 | -2/+10 |
| | |||||
* | add support for anonymous abilities | http://jneen.net/ | 2016-08-30 | 1 | -4/+22 |
| | |||||
* | add policies, and factor out ProjectPolicy | http://jneen.net/ | 2016-08-30 | 1 | -0/+25 |