| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
| |
This reverts merge request !26853
|
|\
| |
| |
| |
| | |
Use serialization for project boards
See merge request gitlab-org/gitlab-ce!29263
|
| |
| |
| |
| |
| |
| | |
- Add serializers and Grape::Entity
- Replace to_json
- Add specs
|
|/
|
|
|
| |
With this commit, we add docs link for confidential
and locked issues to note compose and edit forms
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have one auto merge strategy today - Merge When Pipeline
Succeeds.
In order to add more strategies for Merge Train feature,
we abstract the architecture to be more extensible.
Removed arguments
Fix spec
|
|
|
|
|
|
|
|
|
|
| |
* Add Pipeline IID to MR's
* Add Pipeline IID to commit box
* Add Pipeline IID to builds page
* Add Pipeline IID to job sidebar
* Add Pipeline IID to header on view pipeline pages
* Add changelog entry
* Update tests
|
|
|
|
|
| |
Extracts combining the job_artifacts relation with the with_reports
scope for getting report artifacts into a method.
|
| |
|
| |
|
|
|
|
| |
Exposes report download paths in build details.
|
|\
| |
| |
| |
| |
| |
| | |
Improve performance of jobs controller show
Closes #60708
See merge request gitlab-org/gitlab-ce!28093
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This change makes it possible to avoid additional serialization of
entire pipeline when rendering a build details page. Instead we expose
more information from the build entity itself what is much cheaper than
serializing entire pipeline.
Additionally we do not need to serialize `latest?` flag, which involves
multiple Gitaly calls.
|
| | |
|
| | |
|
| | |
|
|/
|
|
|
|
| |
In order to stop showing 'Not enough data' in cycle analytics view
Remove puts from the file
|
| |
|
|
|
|
|
|
|
|
| |
Only prometheus can be uninstalled atm, the rest will be dealt with
later.
Presumption is that new application types will have uninstallation
implmemented at the same time.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In Rails 5, including `ActionView::Context` can have a significant and
hidden performance penalty because this module also includes
`ActionView::CompiledTemplates`. This means that any module that
includes ActionView::Context becomes a descendant of
`CompiledTemplates`.
When a partial is rendered for the first time, it runs
`ActionView::CompiledTemplates#module_eval`, which will evaluate a
string that defines a new method for that partial. For example, the
source of partial might be this string:
```
def _app_views_project_show_html_haml___12345(local_assigns, output)
"hello world"
end
```
When this string is evaluated, the Ruby interpreter will define the
method and clear the global method cache for all descendants of
`ActionView::CompiledTemplates`. Previous to this change, we
inadvertently made a number of modules fall into this category:
* GroupChildEntity
* NoteUserEntity
* Notify
* MergeRequestUserEntity
* AnalyticsCommitEntity
* CommitEntity
* UserEntity
* Kaminari::Helpers::Paginator
* CurrentUserEntity
* ActionView::Base
* ActionDispatch::DebugExceptions::DebugView
* MarkupHelper
* MergeRequestPresenter
After this change:
* Kaminari::Helpers::Paginator
* ActionView::Base
* ActionDispatch::DebugExceptions::DebugView
Each time a partial is rendered for the first time, all methods for
those modules will have to be redefined. This can exact a significant
performance penalty.
How bad is this penalty? Using the following benchmark script, we can
use DTrace to sample the Ruby interpreter:
```
Benchmark.bm do |x|
x.report do
1000.times do
ActionView::CompiledTemplates.module_eval("def testme\nend")
end
end
end
```
This revealed a 11x jump in the time spent in `core#define_method`
alone.
Rails 6 fixes this behavior by moving the `include CompiledTemplates`
into ActionView::Base so that including `ActionView::Context` doesn't
quietly affect other modules in this way.
Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11198
|
|\
| |
| |
| |
| |
| |
| | |
into 'master'
Update merge request widget to accommodate post-merge pipelines
See merge request gitlab-org/gitlab-ce!25983
|
| |
| |
| |
| |
| | |
This commit adds two new warning messages to the MR widget that handle
cases involving merge request pipelines.
|
| |
| |
| |
| | |
Add time tracking progress bar to Issue Boards sidebar.
|
| | |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
'6649-extract-ee-specific-files-lines-for-ci-cd-app-serializers' into 'master'
Extract preloaded_relations
See merge request gitlab-org/gitlab-ce!27168
|
| | | |
|
|/ /
| |
| |
| |
| | |
Backports https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10161
(code out of ee/ folder).
|
| | |
|
|\ \
| |/
|/|
| |
| |
| |
| | |
Show error when namespace/svc account missing
Closes #54506
See merge request gitlab-org/gitlab-ce!26362
|
| |
| |
| |
| |
| | |
We can use this to show more informative error messages with
links to documentation etc.
|
| |
| |
| |
| |
| | |
- added suggestions to mock data
- fixed props to be not required
|
|\ \
| | |
| | |
| | |
| | | |
Simple masking frontend - CE
See merge request gitlab-org/gitlab-ce!26751
|
| |/
| |
| |
| |
| |
| | |
Show masked switch for each variable
When toggled on, the variable value will be masked in runner logs
Show warning message if the switch is on but the value is not maskable
|
|\ \
| | |
| | |
| | |
| | | |
Backport: Expose merge request pipeline parameters for MR widget
See merge request gitlab-org/gitlab-ce!26826
|
| |/
| |
| |
| | |
This is for merge request pipelines
|
|/
|
|
| |
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/59695
|
|
|
| |
This reverts merge request !25476
|
|
|
|
|
| |
Add a masked switch to variable rows
Copy some behavior from the protected switch
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| | |
Fix duplicated bottom match line
Closes #59147
See merge request gitlab-org/gitlab-ce!26402
|
| |
| |
| |
| |
| |
| |
| | |
This is a quick fix by only append match line once
when calling diff_lines_for_serializer multiple time.
Also enable feature by default
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Commit changes
Add spec
Add changelog
fix
fix
Fix
Fix spec
Finish spec
ok
nice
ok
ok
ok
fix
|
|\ \
| | |
| | |
| | |
| | | |
Update rubocop target ruby version
See merge request gitlab-org/gitlab-ce!24804
|
| |/ |
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add spec
Fix
Fix
Add changelog
Drop attached
Remove attached
Update changelog
ok
|
| |
|