summaryrefslogtreecommitdiff
path: root/app/services/create_branch_service.rb
Commit message (Collapse)AuthorAgeFilesLines
* Use a similar approach to branch creation for tag creationuse-rugged-to-create-tagRémy Coutable2016-05-041-5/+0
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Fix duplicated branch creation/deletion Web hooks/service notifications when ↵Stan Hu2016-02-091-5/+1
| | | | | | | | | | | | | | | | | | | using Web UI Similar to 423d2d6, except duplicates occurred only if a Web service (e.g. Slack) were configured. When deleting a branch, this is what was happening: 1. DeleteBranchService calls execute_hooks and execute_services 2. The call to repository.rm_branch triggers the GitHooksService. 3. This, in turn, calls GitPushService and then calls the same hooks/services again. 5145706 now makes it no longer necessary for DeleteBranchService and CreateBranchService to execute the branch hooks/services. Note that tags behave differently in GitTagPushService and GitPushService is not called. Closes #10330
* Fix duplicated branch creation/deletion events when using Web UIStan Hu2016-01-081-1/+0
| | | | | | | | | | | | When deleting a branch, this is what was happening: 1. DeleteBranchService calls EventCreateService and creates an event. 2. The call to repository.rm_branch triggers the GitHooksService. 3. This, in turn, calls GitPushService and then calls EventCreateService again. 5145706c now makes it no longer necessary for DeleteBranchService and CreateBranchService to create an event. Closes #4304
* Merge branch 'edit-on-fork' into 'master' Dmitriy Zaporozhets2015-12-241-2/+15
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Automatically fork a project when not allowed to edit a file. Fixes #3215. To do: - [ ] Add tests ----- ## "Edit" button on file in a project the user does NOT have write access to ![edit_file](/uploads/7602157420768aef483a6586bba2d164/edit_file.png) ## Clicking will automatically create a fork ![during_fork](/uploads/32f4f5dff9f24ea99522000b0bf881c5/during_fork.png) ## When the fork has been created, the user is returned to the edit page on the original project with a notice ![edit_notice](/uploads/94ed1319404370ff1e9c0d672fb41e03/edit_notice.png) ## The user cannot change the target branch and is informed that editing will start an MR ![edit_footer](/uploads/4da68d4795c7177e575b7c434d16eeae/edit_footer.png) ## Hitting "Commit changes" will commit and start an MR from my fork to the origin project ![Screen_Shot_2015-12-17_at_23.38.08](/uploads/d777a4db6f38a5a1be84031694465bc1/Screen_Shot_2015-12-17_at_23.38.08.png) ----- ## "Create file, "Upload file" and "New directory" buttons in a project the user does NOT have write access to ![new_directory](/uploads/72f556248f30d6652523bbb4be01b3e0/new_directory.png) ## Clicking any of these options will automatically create a fork ![during_fork](/uploads/32f4f5dff9f24ea99522000b0bf881c5/during_fork.png) ## When the fork has been created, the user is returned to the tree page on the original project with a notice ![new_directory_notice](/uploads/a1a3e11308ae0e8f0913fae6813a37ed/new_directory_notice.png) ## Clicking "New directory" again will show the modal. The user cannot change the target branch and is informed that editing will start an MR ![new_dir](/uploads/99ca8cbfb2f70603e352b3fdf67b6281/new_dir.png) ## Hitting "Create directory" will commit and start an MR from my fork to the origin project ![Screen_Shot_2015-12-17_at_23.39.19](/uploads/3713d0235abf831361b803a6198c5bc1/Screen_Shot_2015-12-17_at_23.39.19.png) cc @dzaporozhets @skyruler See merge request !2145
| * Automatically fork a project when not allowed to edit a file.Douwe Maan2015-12-181-2/+15
| |
* | Add JS validation for invalid characters in branch nameDouglas Barbosa Alexandre2015-12-171-1/+1
| | | | | | | | | | | | | | More info about valid ref names: https://www.kernel.org/pub/software/scm/git/docs/git-check-ref-format.ht ml
* | Add more descriptive error message when create branch with invalid nameDouglas Barbosa Alexandre2015-12-161-1/+1
|/
* Run custom Git hooks when creating or deleting branches through the UI. #1156Rubén Dávila2015-12-031-2/+3
|
* Ecevute hooks and services when branches are created/deleted through web.Douwe Maan2015-03-131-0/+2
|
* Use PushDataBuilder where applicable.Douwe Maan2015-03-131-3/+11
|
* Move all event creation to EventCreateService.Douwe Maan2015-02-131-1/+1
|
* Factor error and success methods from services.Ciro Santilli2014-09-211-13/+7
|
* Validate branch-names and references in WebUI, APIRobert Schilling2014-09-031-1/+26
| | | | Add specs for GitRefValidator
* Move branch creation logic in serviceDmitriy Zaporozhets2014-04-011-0/+13
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>