summaryrefslogtreecommitdiff
path: root/app/services/groups
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'security-todos_not_redacted_for_guests' into 'master'John Jarvis2019-01-021-1/+1
|\ | | | | | | | | [master] Security todos not redacted for guests See merge request gitlab/gitlabhq!2697
| * Delete confidential issue todos for guestsFelipe Artur2018-12-141-1/+1
| | | | | | | | | | Fix leaking information of confidential issues on TODOs when user is downgraded to guest access.
* | Rename GroupHierarchy into ObjectHierarchyJarka Košanová2018-12-192-2/+2
| | | | | | | | | | | | - we now use the hierarchy class also for epics - also rename supports_nested_groups? into supports_nested_objects? - move it to a concern
* | Change deprecated `except!` usagesRobert Speicher2018-12-161-1/+1
|/ | | | | These can just be `delete` calls, with the caveat that it only takes one argument.
* Fix Groups::UpdateService#execute not returning correct error codeStan Hu2018-10-181-2/+4
| | | | | This was causing problems in EE, where audit events were being generated even if the project failed to save.
* Disable existing offenses for the CodeReuse copsYorick Peterse2018-09-112-0/+6
| | | | | This whitelists all existing offenses for the various CodeReuse cops, of which most are triggered by the CodeReuse/ActiveRecord cop.
* don't trigger project deletion hooks twice when removing a groupGabriel Mazetto2018-08-261-1/+4
|
* Fix: Project deletion may not log audit events during group deletion49796-project-deletion-may-not-log-audit-events-during-group-deletionValery Sizov2018-08-161-3/+4
|
* Remove group todos when a users looses accessJarka Kadlecová2018-08-021-1/+10
|
* Enable frozen string in apps/services/**/*.rbrepo-forks/gitlab-ce-frozen-string-enable-apps-services-innergfyoung2018-07-166-0/+12
| | | | | | For directories application_settings --> labels. Partially addresses #47424.
* Add manifest import featureDmitriy Zaporozhets2018-07-111-5/+7
| | | | | | | | | It allows user to automatically import multiple repositories with nested structure by uploading a manifest xml file. AOSP project was used as an example during development of this feature. Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Merge branch 'fix/gh-namespace-issue' into 'security-10-4'James Lopez2018-02-091-3/+7
| | | | [10.4] Fix GH namespace security issue
* 31885 - Ability to transfer a single group to another groupMayra Cabrera2018-02-061-0/+96
|
* Remove soft removals related codeYorick Peterse2018-01-081-2/+1
| | | | | | | | | | | | | | This removes all usage of soft removals except for the "pending delete" system implemented for projects. This in turn simplifies all the query plans of the models that used soft removals. Since we don't really use soft removals for anything useful there's no point in keeping it around. This _does_ mean that hard removals of issues (which only admins can do if I'm not mistaken) can influence the "iid" values, but that code is broken to begin with. More on this (and how to fix it) can be found in https://gitlab.com/gitlab-org/gitlab-ce/issues/31114. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/37447
* Make Members with Owner and Master roles always able to create subgroups30473-allow-creation-of-subgroups-with-gitlab_default_can_create_group-set-to-falseRuben Davila2017-09-071-9/+29
|
* Refer to “Share with group lock” consistentlyimprove-share-locking-feature-for-subgroupsMichael Kozono2017-09-061-1/+1
|
* Make UpdateService error message translatableWinnie Hellmann2017-09-061-1/+1
|
* Refactor based on code reviewMichael Kozono2017-09-061-1/+1
|
* Dry up method for code climateMichael Kozono2017-09-061-10/+3
|
* Enforce share_with_group_lock rulesMichael Kozono2017-09-061-1/+17
| | | | …in Groups::UpdateService instead of only in the browser.
* Handle creating a nested group on MySQL correctlybvl-fix-mysql-bare-repository-importerBob Van Landuyt2017-08-251-0/+4
| | | | | Since we don't support nested groups on MySQL, raise an error explaining that on import instead of trying anyway.
* Migrate creation of nested groups into a serviceBob Van Landuyt2017-08-231-0/+45
|
* Merge branch '35845-improve-subgroup-creation-permissions' into 'master'Douwe Maan2017-08-221-2/+2
|\ | | | | | | | | | | | | Improves subgroup creation permissions Closes #35845 See merge request !13418
| * Improves subgroup creation permissions35845-improve-subgroup-creation-permissionsTiago Botelho2017-08-211-2/+2
| |
* | Make sure repository's removal work for legacy and hashed storages28283-uuid-storageGabriel Mazetto2017-08-221-1/+1
|/
* Remove Mattermost team with GitLab groupZ.J. van de Weg2017-07-281-0/+2
| | | | | | | When destroying a group, now an API call is made to the Mattermost server to request the deletion of the project. Actual team deletion on the Mattermost side happens async, so the runtime shouldn't increase by more than a second.
* Defer project destroys within a namespace in ↵Stan Hu2017-06-291-2/+1
| | | | | | | | | | | Groups::DestroyService#async_execute Group#destroy would actually hard-delete all associated projects even though the acts_as_paranoia gem is used, preventing Projects::DestroyService from doing any work. We first noticed this while trying to log all projects deletion to the Geo log.
* Fix current feature related specsTiago Botelho2017-06-281-1/+1
|
* Merge branch 'jej-group-name-disclosure' into 'security'Sean McGivern2017-03-291-0/+8
| | | | | | Prevent private group disclosure via parent_id See merge request !2077
* Fix eslintZ.J. van de Weg2017-03-061-6/+3
|
* Merge branch 'master' into zj-create-mattermost-teamZ.J. van de Weg2017-03-021-1/+2
|\
| * Make nested groups deletion synchronous to avoid potential raceStan Hu2017-02-271-1/+2
| |
* | Improve UXZ.J. van de Weg2017-03-023-21/+11
| |
* | Review changesLuke "Jared" Bennett2017-02-281-1/+1
| |
* | Fix testsZ.J. van de Weg2017-02-243-10/+19
| |
* | Merge branch 'master' into zj-create-mattermost-teamZ.J. van de Weg2017-02-201-1/+3
|\ \ | |/
| * Fix a number of race conditions that can occur during namespace deletionsh-namespace-cleanup-deleted-projectsStan Hu2017-02-151-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are two problems in the current implementation: 1. If a project is marked for deletion via the `pending_delete` flag and then the namespace was quickly deleted, it's possible that the namespace skips over that project and leaves that project in an orphaned state. 2. Before namespace deletion, the namespace attempts to clean up all the relevant storage paths. However, if all projects have been removed synchronously, then the namespace will not be able to clean anything. To prevent this, we should load the paths to be deleted before actually destroying projects. The specs were missing this second case due to a permission issue that caused project removal never to happen.
* | Transactional mattermost team creationZ.J. van de Weg2017-02-201-8/+13
| | | | | | | | | | | | | | Before this commit, but still on this feature branch, the creation of mattermost teams where a background job. However, it was decided it was better that these happened as transaction so feedback could be displayed to the user.
* | Improve DRYness of viewsZ.J. van de Weg2017-02-162-1/+8
| |
* | Add tests for Mattermost team creationZ.J. van de Weg2017-02-161-1/+3
| |
* | Create MM team for GitLab groupZ.J. van de Weg2017-02-161-0/+5
|/
* Fix inconsistent naming for services that delete thingsdixpac2017-02-081-0/+25
| | | | | | * Changed name of delete_user_service and worker to destroy * Move and change delete_group_service to Groups::DestroyService * Rename Notes::DeleteService to Notes::DestroyService
* Refactor nested group related codedz-nested-group-miscDmitriy Zaporozhets2016-12-291-10/+4
| | | | | | | * Simplify code around group parent access check * Rename 'Nested groups' to 'Subgroups' tab at group#show page Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Add nested groups support to the Groups::CreateServiceDmitriy Zaporozhets2016-12-261-0/+13
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Fix error 500 renaming group. Also added specs and changelog.James Lopez2016-12-201-1/+7
|
* Enable Style/MultilineOperationIndentation in Rubocop, fixes #25741Rydkin Maxim2016-12-161-1/+1
|
* Address feedbackDouwe Maan2016-03-222-5/+1
|
* Fix specsDouwe Maan2016-03-201-1/+1
|
* Tweaks, refactoring, and specsDouwe Maan2016-03-203-15/+16
|
* Improve group visibility level featureZeger-Jan van de Weg2016-03-183-24/+16
|
View Lorry Controller Status