| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |\
| |
| |
| |
| |
| |
| | |
Use Commit#notes and Note.for_commit_id when possible to make sure we use all indexes available to us
Closes #34509
See merge request gitlab-org/gitlab-ce!15253
|
| | |
| |
| |
| | |
all the indexes available to us
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Rewrite the GitHub importer to perform work in parallel and greatly improve performance
Closes #33135, #38621, and #39361
See merge request gitlab-org/gitlab-ce!14731
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Prior to this MR there were two GitHub related importers:
* Github::Import: the main importer used for GitHub projects
* Gitlab::GithubImport: importer that's somewhat confusingly used for
importing Gitea projects (apparently they have a compatible API)
This MR renames the Gitea importer to Gitlab::LegacyGithubImport and
introduces a new GitHub importer in the Gitlab::GithubImport namespace.
This new GitHub importer uses Sidekiq for importing multiple resources
in parallel, though it also has the ability to import data sequentially
should this be necessary.
The new code is spread across the following directories:
* lib/gitlab/github_import: this directory contains most of the importer
code such as the classes used for importing resources.
* app/workers/gitlab/github_import: this directory contains the Sidekiq
workers, most of which simply use the code from the directory above.
* app/workers/concerns/gitlab/github_import: this directory provides a
few modules that are included in every GitHub importer worker.
== Stages
The import work is divided into separate stages, with each stage
importing a specific set of data. Stages will schedule the work that
needs to be performed, followed by scheduling a job for the
"AdvanceStageWorker" worker. This worker will periodically check if all
work is completed and schedule the next stage if this is the case. If
work is not yet completed this worker will reschedule itself.
Using this approach we don't have to block threads by calling `sleep()`,
as doing so for large projects could block the thread from doing any
work for many hours.
== Retrying Work
Workers will reschedule themselves whenever necessary. For example,
hitting the GitHub API's rate limit will result in jobs rescheduling
themselves. These jobs are not processed until the rate limit has been
reset.
== User Lookups
Part of the importing process involves looking up user details in the
GitHub API so we can map them to GitLab users. The old importer used
an in-memory cache, but this obviously doesn't work when the work is
spread across different threads.
The new importer uses a Redis cache and makes sure we only perform
API/database calls if absolutely necessary. Frequently used keys are
refreshed, and lookup misses are also cached; removing the need for
performing API/database calls if we know we don't have the data we're
looking for.
== Performance & Models
The new importer in various places uses raw INSERT statements (as
generated by `Gitlab::Database.bulk_insert`) instead of using Rails
models. This allows us to bypass any validations and callbacks,
drastically reducing the number of SQL queries and Gitaly RPC calls
necessary to import projects.
To ensure the code produces valid data the corresponding tests check if
the produced rows are valid according to the model validation rules.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
By using SQL::Union we can return a proper ActiveRecord::Relation,
making it possible to select the columns we're interested in (instead of
all of them).
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Added missing strings to prepare the tags page for internationalization
See merge request gitlab-org/gitlab-ce!15256
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Change Sign Out route from a DELETE to a GET
Closes #39708
See merge request gitlab-org/gitlab-ce!15231
|
| | | | | |
| | | | |
| | | | |
| | | | | |
Closes #39708
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
When deleting merged branches, ignore protected tags
Closes #39732
See merge request gitlab-org/gitlab-ce!15252
|
| | | |_|_|/
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
In gitlab-org/gitlab-ce!13251 wildcard Protected Branches were handled
properly when deleting all merged branches. But this fix wasn't that
good. It also checked branch names against Protected Tags. That's not
correct.
This change will **only** check if there is a Protected Branch
matching the merged branch, and ignores Protected Tags.
Closes gitlab-org/gitlab-ce#39732.
|
| |\ \ \ \ \
| |_|_|_|/
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Project with many branches can lock server running "git branch --contains XXX"
Closes #37824
See merge request gitlab-org/gitlab-ce!14812
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | | |
Make small improvements over well.css files
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Fixes thinner right border on the limit box
- Adds and 'elsif' on @branches for the scenario in which a commit is not related to a branch
- Fixes small details on limit_exceeded_for_message partial
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Improves CSS files by reusing existing code
- Changes logic in views to avoid future problems in translations
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Display the default branch (if the limit is not exceeded)
- Requires '...' to be clicked before showing the rest of the branches and/or tags
- Fixes haml lints
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Create a partial for limit exceeded message
- Modifies specs to adjust new scenarios
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Leave 'too many tags to search' always visible
- Add different message to the branch/tags so it states its unavailable
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | | |
threshhold, a message is shown indicating we didn't perform the search
|
| | | | | |
| | | | |
| | | | |
| | | | | |
the long running git query
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
add-ingress-to-cluster-applications
|
| | |\ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Add support for k8s cluster applications - Helm tiller installation
See merge request gitlab-org/gitlab-ce!14908
|
| | |\ \ \ \ \ \
| | |_|_|_|_|/
| |/| | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Revert Auto DevOps gear animation
Closes #39798
See merge request gitlab-org/gitlab-ce!15232
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/39798
|
| | |\ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Fixed multi-file editor table cells content width jumping
See merge request gitlab-org/gitlab-ce!15245
|
| | | | |_|_|/ /
| | |/| | | | |
|
| |\ \ \ \ \ \ \
| | |_|_|/ / /
| |/| | | | |
| | | | | | | |
into add-ingress-to-cluster-applications
|
| | |\ \ \ \ \ \
| | |/ / / / / |
|
| | | |\ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Fix commit pipeline showing wrong status
Closes #39878
See merge request gitlab-org/gitlab-ce!15238
|
| | | | | | | | | |
|
| | | |\ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
don't re-run smart interval callback if there is already one in progress
Closes #38394
See merge request gitlab-org/gitlab-ce!15032
|
| | | | |\ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
38394-smarter-interval
|
| | | | | | | | | | | |
|
| | | | | | | | | | | |
|
