summaryrefslogtreecommitdiff
path: root/app
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'master' into james11/gitlab-ce-removable-group-ownerDouwe Maan2015-11-17249-1130/+2235
|\
| * Merge branch 'issue/vars-need-eval' into 'master' Douwe Maan2015-11-171-1/+1
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ensure variable in mail is evalled I received this snippet in the mail: ``` Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Project #{@old_path_with_namespace} was moved to another location The project is now located under ``` This MR fixes it. Notes: * I did a quick grep on other 'text.erb' files, but this was the only one with this type of error * I made no changes to the specs. The only [spec](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/spec/mailers/notify_spec.rb#L412) I could find passes because (I assume) the correct value is in the html-part See merge request !1706
| | * Ensure variable is evalledGert Goet2015-10-291-1/+1
| | |
| * | Merge branch 'rs-wiki-touches-project' into 'master' Douwe Maan2015-11-171-0/+10
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | Make ProjectWiki touch Project#last_activity_at after wiki actions Closes #3026 See merge request !1803
| | * | Make ProjectWiki touch Project#last_activity_at after wiki actionsrs-wiki-touches-projectRobert Speicher2015-11-161-0/+10
| | | | | | | | | | | | | | | | Closes #3026
| * | | Merge branch 'http-to-https' into 'master' Achilleas Pipinellis2015-11-172-4/+4
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rewrite HTTP links to force TLS, where possible I got annoyed at the fact that the links on the profile page don't force the use of TLS, so I grepped through the entire source tree, tested all the links I found, and replaced them if possible. See merge request !1806
| | * | | Rewrite HTTP links to force TLS, where possibleAlex Jordan2015-11-162-4/+4
| | | | |
| * | | | Merge branch 'global-milestones' into 'master' Dmitriy Zaporozhets2015-11-1624-186/+230
| |\ \ \ \ | | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Create milestones in the group When you work with groups its quite often you want to create same milestone in multiple projects. This MR allows you to do so For #3488 Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> See merge request !1797
| | * | | Some code and doc improvementsglobal-milestonesDmitriy Zaporozhets2015-11-163-2/+6
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| | * | | Fix removing avatar for groupDmitriy Zaporozhets2015-11-161-1/+1
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| | * | | Group masters should be able to create/close milestonesDmitriy Zaporozhets2015-11-165-7/+9
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| | * | | Few changes to Group Milestone feature:Dmitriy Zaporozhets2015-11-163-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Group attachments are not supported so I removed attach file link * Added changelog item * Add markdown hint to project milestone form Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| | * | | Add header and page title to new milestone pageDmitriy Zaporozhets2015-11-161-0/+3
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| | * | | Lets add more tests to Milestones servicesDmitriy Zaporozhets2015-11-161-1/+0
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| | * | | Move global milestone specsDmitriy Zaporozhets2015-11-161-26/+0
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| | * | | Fix a bug when milestone/label filter was empty for dashboard issues pageDmitriy Zaporozhets2015-11-161-0/+5
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| | * | | Refactor global and group milestones logicDmitriy Zaporozhets2015-11-1619-165/+145
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| | * | | Create milestones in the groupDmitriy Zaporozhets2015-11-163-8/+86
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | | Merge branch 'ci-runners-master-or-owner' into 'master' Dmitriy Zaporozhets2015-11-161-5/+10
| |\ \ \ \ | | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Show specific runners from projects where user is master or owner This fix for permission escalation when handling specific runners. The users were allowed to assign runners from projects where they were guests. See merge request !1809
| | * | | Show specific runners from projects where user is master or ownerci-runners-master-or-ownerKamil Trzcinski2015-11-161-5/+10
| | | | |
| * | | | Merge branch 'refactor-duplication' into 'master' Dmitriy Zaporozhets2015-11-166-92/+45
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove some code duplication * remove duplicate code in uploaders * remove duplicate code in NotificationHelper * remove duplicate code in Repository Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> See merge request !1800
| | * | | | Fix wrong variable namerefactor-duplicationDmitriy Zaporozhets2015-11-161-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| | * | | | Remove duplicate code in Repository#*_names_containsDmitriy Zaporozhets2015-11-161-16/+7
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| | * | | | Fix code duplication in NotificationsHelperDmitriy Zaporozhets2015-11-161-25/+13
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| | * | | | Remove duplicate methods in uploadersDmitriy Zaporozhets2015-11-164-51/+25
| | |/ / / | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | | Add support for git lfs.lfsMarin Jankovski2015-11-165-3/+59
| |/ / /
| * | | Merge branch 'fix_trailing_title_space' of ↵Dmitriy Zaporozhets2015-11-162-2/+6
| |\ \ \ | | | | | | | | | | | | | | | https://gitlab.com/dblessing/gitlab-ce
| | * | | Fix trailing space issue with merge requests and issues. Fixes #2514Drew Blessing2015-11-102-2/+6
| | | | |
| * | | | Revert "Merge pull request #9812 from chrspeich/hide-tabs-lone-auth-provider"rs-revert-gh-9812Robert Speicher2015-11-151-27/+19
| | |/ / | |/| | | | | | | | | | | | | | This reverts commit 84999611d8f7894219eb4ebc76555c79b1f14794, reversing changes made to 0d9fb211f3f842d10e1c57dcb9d3d42a9c11cd0b.
| * | | Merge branch 'impersonate' into 'master' Dmitriy Zaporozhets2015-11-146-7/+47
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | refactor login as to be impersonation with better login/logout Modifies the existing "login as" feature to be called impersonation. This also adds: * Application keep track of who is impersonating the user so they can revert back to the original user without having to log out. * Stores the user profile via `HTTP_REFERER` so you get redirected back to the person you have impersonated once you stop. ## Screenshots: ![](http://sindacio.us/i/2015-10-28_17-52-41.png) ![](http://sindacio.us/i/2015-10-28_17-53-08.png) See merge request !1702
| | * | | refactor login as to be impersonation with better login/logoutJames Newton2015-10-296-7/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Modifies the existing "login as" feature to be called impersonation, as well as keeping track of who is impersonating to revert back to that user without having to log out.
| * | | | Merge branch 'annotate-models' into 'master' Dmitriy Zaporozhets2015-11-1428-77/+177
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Annotate models Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> See merge request !1799
| | * | | | Annotate modelsDmitriy Zaporozhets2015-11-1328-77/+177
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | | | Merge branch 'builds_feature' into 'master' Kamil Trzciński2015-11-1310-38/+35
| |\ \ \ \ \ | | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Expose builds feature Expose builds feature in project settings (as feature). Enable it by default for a new projects. I deliberately named it builds instead of CI, because we actualy allow to run tests using infrastructure built-in GitLab. I'm free to change it. ![Screen_Shot_2015-11-09_at_16.42.21](/uploads/a8af0a56fc0498688c0428ff22252d9c/Screen_Shot_2015-11-09_at_16.42.21.png) If we are ok, I'll add feature tests for it. /cc @sytses @dzaporozhets See merge request !1767
| | * | | | Fix broken testsKamil Trzcinski2015-11-131-24/+0
| | | | | |
| | * | | | Expose CI enable option in project featuresKamil Trzcinski2015-11-139-14/+35
| | | | | | | | | | | | | | | | | | | | | | | | - Enable CI by default for all new projects
| * | | | | Merge branch 'refactor-complex-methods' into 'master' Dmitriy Zaporozhets2015-11-134-76/+98
| |\ \ \ \ \ | | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactor complex methods Make flog part of CI check which is not allowed to fail. I used high score (70) and refactored most complex method. In future releases we should lower acceptable score to something like 40..50 Part of #3444 See merge request !1794
| | * | | | Split complex method EventsHelper#event_feed_url.Dmitriy Zaporozhets2015-11-131-11/+15
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| | * | | | Split complex method Issues::UpdateService#executeDmitriy Zaporozhets2015-11-131-13/+16
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| | * | | | Split complex method SystemHooksService#build_event_dataDmitriy Zaporozhets2015-11-131-30/+42
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| | * | | | Split huge method MergeRequests::UpdateService#executeDmitriy Zaporozhets2015-11-131-22/+25
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | | | | Merge pull request #9825 from huacnlee/cache-application-settingDmitriy Zaporozhets2015-11-132-3/+15
| |\ \ \ \ \ | | | | | | | | | | | | | | Add caching for ApplicationSetting, Ci::ApplicationSetting.
| | * | | | | Add caching for ApplicationSetting, Ci::ApplicationSetting.Jason Lee2015-11-122-3/+15
| | | |_|/ / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ApplicationSetting.current was called in every pages, cache it and expires it after it updated. This changes will avoid a SQL query in every pages (~0.3 - 0.5ms). ```SQL SELECT "application_settings".* FROM "application_settings" ORDER BY "application_settings"."id" DESC LIMIT 1 ```
| * | | | | Add ignore white space option in merge request diffMinsik Yoon2015-11-135-6/+21
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | fix this issue(https://gitlab.com/gitlab-org/gitlab-ce/issues/1393). Add ignore whitespace optoin to Commits Compare view
| * | | | Merge branch 'use-path-for-new-issue-button' into 'master' Dmitriy Zaporozhets2015-11-121-1/+1
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use a relative link instead of full URL with New Issue button to be consistent Relates to #3095 See merge request !1631
| | * | | | Use a relative link instead of full URL with New Issue button to be consistentStan Hu2015-10-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Relates to #3095
| * | | | | Merge branch 'fix-avatar-not-showing' of https://gitlab.com/stanhu/gitlab-ceDmitriy Zaporozhets2015-11-124-4/+4
| |\ \ \ \ \
| | * | | | | Fix avatars not showing in Atom feeds and project issues when Gravatar disabledStan Hu2015-11-104-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix for https://github.com/gitlabhq/gitlabhq/pull/9783
| * | | | | | Merge pull request #9820 from huacnlee/avoid-render-form-in-notes-listDmitriy Zaporozhets2015-11-125-13/+16
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | Avoid render edit_form in each notes.
| | * | | | | | Avoid render edit_form in each notes.Jason Lee2015-11-125-13/+16
| | | |_|/ / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use RJS to render edit note feature. Before: ``` Rendered projects/notes/_note.html.haml (27.9ms) Rendered projects/_zen.html.haml (0.3ms) Rendered projects/notes/_hints.html.haml (0.7ms) Rendered projects/_md_preview.html.haml (3.9ms) Rendered projects/notes/_edit_form.html.haml (6.9ms) Rendered projects/notes/_note.html.haml (17.7ms) Rendered projects/_zen.html.haml (0.3ms) Rendered projects/notes/_hints.html.haml (0.6ms) Rendered projects/_md_preview.html.haml (3.4ms) Rendered projects/notes/_edit_form.html.haml (7.0ms) ``` After: ``` Rendered projects/notes/_note.html.haml (13.8ms) Rendered projects/notes/_note.html.haml (7.1ms) Rendered projects/notes/_note.html.haml (9.5ms) Rendered projects/notes/_note.html.haml (8.5ms) ``` This change reduce at least 6ms * N ('N' - number of notes).