delta/gitlab/gitlab-ce.git - gitlab.com: gitlab-org/gitlab-ce.git

	Commit message (Collapse)	Author	Age	Files	Lines
*	Fixed issue boards loading issues on large screensissue-boards-large-height-load	Phil Hughes	2016-09-13	1	-0/+5
\| \| \| \|	Closes #22092
*	Remove unnecessary variables	Katarzyna Kobierska	2016-09-13	2	-8/+8
\|
*	Code refactoring	Katarzyna Kobierska	2016-09-13	3	-11/+14
\|
*	Improve build_path name and admin variable	Katarzyna Kobierska	2016-09-13	5	-14/+13
\|
*	Fix error in paths	Katarzyna Kobierska	2016-09-13	1	-6/+5
\|
*	Build path with call	Katarzyna Kobierska	2016-09-13	4	-30/+6
\|
*	Create shared partial for project and admin builds	Katarzyna Kobierska	2016-09-13	6	-93/+46
\|
*	Moved build tabs partial to shared	Katarzyna Kobierska	2016-09-13	3	-2/+2
\|
*	Improve table code and add CHANGELOG	Katarzyna Kobierska	2016-09-13	1	-4/+2
\|
*	Improve code in table partial	Katarzyna Kobierska	2016-09-13	1	-3/+4
\|
*	Improve code	Katarzyna Kobierska	2016-09-13	5	-10/+11
\|
*	Liken admin and project builds views to each other	Katarzyna Kobierska	2016-09-13	3	-43/+31
\|
*	Move builds content list to partial	Katarzyna Kobierska	2016-09-13	3	-40/+45
\|
*	Use local variables in partial	Katarzyna Kobierska	2016-09-13	3	-10/+10
\|
*	Change the way paths are generated	Katarzyna Kobierska	2016-09-13	5	-15/+9
\|
*	Add partial to admin builds and project builds	Katarzyna Kobierska	2016-09-13	5	-44/+34
\|
*	Merge branch 'rails-5-backports' into 'master'	Robert Speicher	2016-09-12	1	-1/+1
\|\ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Fix two problematic bits of code that will be deprecated or broken in Rails 5. Found in the Rails 5 MR: !5555 These are safe to use in Rails 4.2.7 as well as Rails 5.0.0, so I figured I'd backport them for the sake of making that merge request smaller. The explanation for the mime_types.rb code is here: https://github.com/rails-api/active_model_serializers/issues/1027#issuecomment-126543577 See merge request !6214
\| *	Fix two problematic bits of code that will be deprecated or broken in Rails 5.	Connor Shea	2016-09-05	1	-1/+1
\| \|
* \|	Merge branch '21092-file-execution-flag-is-not-preserved-when-editing-files' ↵	Rémy Coutable	2016-09-12	3	-9/+6
\|\ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	into 'master' While using Gitlab UI to edit a file it changes the file permissions this MR aims to fix it Closes #21092 See merge request !5979
\| * \|	Simplify a condition in Repository#update_file	Rémy Coutable	2016-09-12	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \|	Signed-off-by: Rémy Coutable <remy@rymai.me>
\| * \|	fixes distinction between renaming a file and updating its content and21092-file-execution-flag-is-not-preserved-when-editing-files	tiagonbotelho	2016-09-09	3	-9/+6
\| \| \| \| \| \| \| \| \| \| \| \|	refactors update file
* \| \|	Merge branch 'issue_21825' into 'master'	Rémy Coutable	2016-09-12	1	-0/+11
\|\ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Add information about user and manual build start to runner as variables Closes #21825 See merge request !6201
\| * \| \|	Add information about user and manual build start to runner as variables	Sergey Gnuskov	2016-09-09	1	-0/+11
\| \| \| \|
* \| \| \|	Merge branch 'slightly-more-readable' into 'master'	Rémy Coutable	2016-09-12	1	-3/+3
\|\ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Make the cases clear instead of having guards See merge request !6304
\| * \| \| \|	Make the cases clear instead of having guardsslightly-more-readable	Lin Jen-Shin	2016-09-12	1	-3/+3
\| \| \| \| \|
* \| \| \| \|	Merge branch 'sh-defer-resolvable-check' into 'master'	Yorick Peterse	2016-09-12	1	-1/+2
\|\ \ \ \ \ \| \|/ / / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \|	Only check :can_resolve permission if the note is resolvable See merge request !6298
\| * \| \| \|	Only check :can_resolve permission if the note is resolvablesh-defer-resolvable-check	Stan Hu	2016-09-12	1	-1/+2
\| \| \|/ / \| \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \|	Currently this permission check incurs a significant performance hit on loading issues where it does not make sense to check this permission in the first place.
* \| \| \|	Merge branch '21814-fix' into 'master'	Robert Speicher	2016-09-10	1	-1/+1
\|\ \ \ \ \| \|/ / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Pull import sources from Gitlab::ImportSources ## What does this MR do? `ApplicationSettings.create_from_defaults` defines an array of import sources, but we should be pulling them from `Gitlab::ImportSources.options` since that's what they're validated against. ## What are the relevant issue numbers? Closes #21814 See merge request !6293
\| * \| \|	Pull import sources from Gitlab::ImportSources	Ojas Shirekar	2016-09-09	1	-1/+1
\| \| \| \|
* \| \| \|	Merge branch 'enable-pipeline-events-by-default' into 'master'	Robert Speicher	2016-09-09	1	-0/+1
\|\ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Enable pipeline events by default This should probably be included in !5620 but missed. See merge request !6278
\| * \| \| \|	Enable pipeline events by defaultenable-pipeline-events-by-default	Lin Jen-Shin	2016-09-09	1	-0/+1
\| \|/ / / \| \| \| \| \| \| \| \| \| \| \| \|	Not sure why I missed this before. I thought I added it.
* \| \| \|	Merge branch 'add-remember-option-u2f' into 'master'	Robert Speicher	2016-09-09	3	-2/+4
\|\ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Pass the remember_me option into the u2f form and support it while authenticating ## What does this MR do? Adds remember me support in the u2f authentication, and makes sure the flag gets passed from the login form to the u2f form. Based on the changes for the same thing done for regular 2fa: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4369 ## Why was this MR needed? The remember me option wasn't working for u2f devices (yubikey) ## What are the relevant issue numbers? Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/18103 See merge request !5918
\| * \| \| \|	Pass the remember_me option into the u2f form and support it while ↵add-remember-option-u2f	DJ Mountney	2016-09-01	3	-2/+4
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	authenticating Matches the changes done for non-u2f two-factor auth
* \| \| \| \|	Merge branch 'branches-mr-button-permissions' into 'master'	Robert Speicher	2016-09-09	1	-2/+3
\|\ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Hides merge request button on branches page ## What does this MR do? If user does not have the correct permissions, the merge request button is hidden ## What are the relevant issue numbers? Closes #21805 See merge request !6181
\| * \| \| \| \|	Hides merge request button on branches pagebranches-mr-button-permissions	Phil Hughes	2016-09-02	1	-2/+3
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	If user does not have the correct permissions, the merge request button is hidden Closes #21805
* \| \| \| \| \|	Merge branch '20300-restore-comments' into 'master'	Jacob Schatz	2016-09-09	75	-62/+757
\|\ \ \ \ \ \ \| \|_\|_\|/ / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Restore comments lost when converting CoffeeScript to JavaScript ## What does this MR do? Restores comments lost in the great fire of !5464. ## Are there points in the code the reviewer needs to double check? ## Why was this MR needed? #20300 ## What are the relevant issue numbers? - #20300 (comments) - #20098 (ES6) ## Does this MR meet the acceptance criteria? - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) Closes #20300 See merge request !5541
\| * \| \| \| \|	Require comments must be included before code	Jared Deckard	2016-09-08	1	-3/+0
\| \| \| \| \| \|
\| * \| \| \| \|	Restore comments lost when converting CoffeeScript to JavaScript	Jared Deckard	2016-09-08	75	-62/+760
\| \| \|_\|/ / \| \|/\| \| \|
* \| \| \| \|	Merge branch 'gitlab-workhorse-safeties' into 'master'	Jacob Vosmaer (GitLab)	2016-09-09	4	-8/+14
\|\ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Security and safety improvements for gitlab-workhorse integration Companion to https://gitlab.com/gitlab-org/gitlab-workhorse/merge_requests/60 - Use a custom content type when sending data to gitlab-workhorse - Verify (using JWT and a shared secret on disk) that internal API requests came from gitlab-workhorse This will allow us to build features in gitlab-workhorse that require more trust, and protect us against programming mistakes in the future. This is designed so that no action is required for installations from source. For omnibus-gitlab we need to add code that manages the shared secret. See merge request !5907
\| * \| \| \| \|	Verify JWT messages from gitlab-workhorse	Jacob Vosmaer	2016-09-05	4	-8/+14
\| \| \| \| \| \|
* \| \| \| \| \|	Merge branch '21714-refresh-the-todos-count-cache-after-issuable-delete' ↵	Rémy Coutable	2016-09-09	2	-0/+22
\|\ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	into 'master' Refresh todos count cache when an Issue/MR is deleted Fixes #21714 See merge request !6161
\| * \| \| \| \| \|	Refresh todos count cache when an Issue/MR is deleted	Douglas Barbosa Alexandre	2016-09-08	2	-0/+22
\| \| \| \| \| \| \|
* \| \| \| \| \| \|	Merge branch 'sidekiq-ps-parsing' into 'master'	Rémy Coutable	2016-09-09	2	-6/+21
\|\ \ \ \ \ \ \ \| \|/ / / / / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	* Moves splitting of `ps` result to helper. * Users a regexp to extract the different parts The result of `ps` at least depends on the _LANG_ and the distance of _start_ to _now_ (start time then the day + hour then month+day) I've tested with _LANG=en_US.UTF-8_ and _LANG=de_CH.UTF-8_ Closes #20632 See merge request !6245
\| * \| \| \| \| \|	Remove original regexp	Pascal Betz	2016-09-08	1	-9/+7
\| \| \| \| \| \| \|
\| * \| \| \| \| \|	Reformat Regexp	Pascal Betz	2016-09-08	2	-3/+13
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Fix show template (missing tr) Separate exercise/verify
\| * \| \| \| \| \|	feedback code review	Pascal Betz	2016-09-08	2	-2/+2
\| \| \| \| \| \| \|
\| * \| \| \| \| \|	Move parsing of sidekiq ps into helper	Pascal Betz	2016-09-07	2	-8/+15
\| \| \| \| \| \| \|
* \| \| \| \| \| \|	Merge branch 'support-long-branch-namers' into 'master'	Annabel Dunstone Gray	2016-09-08	1	-3/+9
\|\ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Give project selection dropdowns responsive width, long names wrap. ## What does this MR do? Makes two dropdown menus (branch name selector & project selector) wider on larger screens, and allows their contents to wrap. ## Are there points in the code the reviewer needs to double check? Sanity check. ## Why was this MR needed? Considered a regression, as users who relied on long branch names could no longer see them fully. ## Screenshots (if relevant) Before: ![Screen_Shot_2016-08-30_at_2.50.43_PM](/uploads/e0252cb02c5f34f3c777d2d67028042f/Screen_Shot_2016-08-30_at_2.50.43_PM.png) After: ![Screen_Shot_2016-08-30_at_2.49.35_PM](/uploads/b504e0f3e139c85699bc5aafb58199f3/Screen_Shot_2016-08-30_at_2.49.35_PM.png) After (updated after fixes, including project selector): ![Screen_Shot_2016-09-02_at_1.46.53_PM](/uploads/b480fc8193f713ce43518cb83886fd52/Screen_Shot_2016-09-02_at_1.46.53_PM.png) ![Screen_Shot_2016-09-02_at_1.50.26_PM](/uploads/f0d31702668e83e6c0c24782cc43fdbd/Screen_Shot_2016-09-02_at_1.50.26_PM.png) ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [x] API support added - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #15633 See merge request !6105
\| * \| \| \| \| \| \|	Give project selection dropdowns responsive width, long-names wrap.support-long-branch-namers	Bryce	2016-09-02	1	-3/+9
\| \| \|_\|_\|_\|/ / \| \|/\| \| \| \| \|
* \| \| \| \| \| \|	Merge branch 'smart-pipeline-duration' into 'master'	Rémy Coutable	2016-09-08	2	-1/+12
\|\ \ \ \ \ \ \ \| \|_\|_\|_\|/ / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Smartly calculate real running time and pending time ## What does this MR do? Try to smartly calculate the running time and pending time for pipelines, instead of just use wall clock time from start to end. The algorithm is based on: > Suppose we have A, B, and C jobs: > * A: from 1 to 3 > * B: from 2 to 4 > * C: from 6 to 7 > The processing time should be accumulated from 1 to 4, and 6 to 7, totally 4, excluding retires, and calculate on `%w[success failed running canceled]` jobs (if a job is not finished yet, assume it's `Time.now`) ## Are there points in the code the reviewer needs to double check? I would actually like to test `Gitlab::Ci::PipelineDuration#process_segments`, but it's a private method right now and it's not very convenient to test it. Is there a way to test it without changing the original code too much? Note that I would like to avoid saving merged segments because it's not used and should be garbage collected. ## Screenshots: ![Screen_Shot_2016-09-05_at_6.45.32_PM](/uploads/a82bfaf316661091e383b743a2f11334/Screen_Shot_2016-09-05_at_6.45.32_PM.png) ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - Tests - [x] Added for this feature/bug ## What are the relevant issue numbers? Closes #18260, #19804 See merge request !6084