| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |\
| |
| |
| |
| | |
removed tab indexes from tag form
See merge request gitlab-org/gitlab-ce!15886
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
'tmlee/gitlab-ce-28004-consider-refactoring-member-view-by-using-presenter' into 'master'
Refactor member view by using presenter
Closes #28004
See merge request gitlab-org/gitlab-ce!15715
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- Create MemberPresenter alongside with GroupMemberPresenter and ProjectMemberPresenter
- Make Member model Presentable
- Move action_member_permission from MembersHelper into the MemberPresenter
- Added rspec using double, separate specs for GroupMemberPresenter and ProjectMemberPresenter
Fixes #28004.
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Use memoization for commits on diffs
See merge request gitlab-org/gitlab-ce!15857
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The Gitaly CommitService is being hammered by n + 1 calls, mostly when
finding commits. This leads to this gRPC being turned of on production:
https://gitlab.com/gitlab-org/gitaly/issues/514#note_48991378
Hunting down where it came from, most of them were due to
MergeRequest#show. To prove this, I set a script to request the
MergeRequest#show page 50 times. The GDK was being scraped by
Prometheus, where we have metrics on controller#action and their Gitaly
calls performed. On both occations I've restarted the full GDK so all
caches had to be rebuild.
Current master, 806a68a81f1baee, needed 435 requests
After this commit, 154 requests
|
| | | | |
| | | |
| | | |
| | | | |
import url
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Hide issues and MRs in labels list if disabled
See merge request gitlab-org/gitlab-ce!15863
|
| | | |/ /
| |/| |
| | | |
| | | | |
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
| |\ \ \ \
| |_|_|/
|/| | |
| | | |
| | | | |
Treat empty markdown and html strings as valid cached text, not missing cache…
See merge request gitlab-org/gitlab-ce!15856
|
| | | | |
| | | |
| | | |
| | | | |
cache that needs to be updated
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Use Single list for multiple clusters
See merge request gitlab-org/gitlab-ce!15848
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Use app host instead of asset host when rendering image blob or diff
Closes #41002
See merge request gitlab-org/gitlab-ce!15854
|
| | |/ / / / |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fix comment on image discussion icon alignment (update icons)
Closes #39608
See merge request gitlab-org/gitlab-ce!15760
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/39608
Use SVG icons to avoid having to position things
See https://gitlab.com/gitlab-org/gitlab-ce/issues/39608#note_50088917
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Ignore temporary table in schema
Closes #40976
See merge request gitlab-org/gitlab-ce!15866
|
| | | |_|_|_|/
| |/| | | | |
|
| |\ \ \ \ \ \
| |_|_|_|_|/
|/| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Animate contextual sidebar; change class names for easier readability
Closes #35724
See merge request gitlab-org/gitlab-ce!15797
|
| | | | | | | |
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Remove allocation tracking code from InfluxDB sampler for performance
Closes gitlab-com/infrastructure#3250
See merge request gitlab-org/gitlab-ce!15834
|
| | | |/ / / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
On GitLab.com, InfluxSampler#sample_objects appears to take 1.2 s or so to
iterate through 1059 objects. This had led to delays of a couple hundred
milliseconds in processing in the main thread. Remove this code since it's not
really being used.
Closes gitlab-com/infrastructure#3250
|
| |\ \ \ \ \ \
| |_|_|_|/ /
|/| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
'40743-bug-accepting-new-group-members-when-permission-level-developer' into 'master'
Bugfix: User can't change the access level of an access requester
Closes #40743
See merge request gitlab-org/gitlab-ce!15832
|
| | |/ / / /
| | | | |
| | | | |
| | | | |
| | | | | |
The endpoint was returning 404 because it was only searching on the
current members of a Group or Project and not the access requesters.
|
| |/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
If the source import directory were different from the destination directory,
GitLab would first create a blank repository and then erroneously move the
original one into a subdirectory. Adding an import type prevents this the project
from being initialized in the first place. It was accidentally removed in
1f917cbd49.
Closes #40765
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Resolve "Deploy markers should be more verbose"
Closes #38032
See merge request gitlab-org/gitlab-ce!15641
|
| | | | | | |
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fix N+1 query when displaying events
See merge request gitlab-org/gitlab-ce!15788
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
When displaying events we would load the target of those events, then
render the entire data using our Markdown pipeline. This pipeline would
eventually request the author of every target, leading to an additional
query being executed for every target to get the author.
To fix this we now eager load the author of the event's target. In my
local environment this reduces the number of queries to display a
project's Atom feed from 40 to 24 queries.
See https://gitlab.com/gitlab-org/gitlab-ce/issues/36878 for more
information.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Use prefix for TableOfContents filter hrefs
Closes #38473
See merge request gitlab-org/gitlab-ce!15806
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
TableOfContents filter generates hrefs for each header in markdown,
if the header text consists from digits and redacted symbols only,
e.g. "123" or "1.0 then the auto-generated href has the same format
as issue references.
If the generated id contains only digits, then 'anchor-' prefix is
prepended to the id.
Closes #38473
|
| | |/ / / / /
|/| | | | | |
|
| |\ \ \ \ \ \
| |_|_|_|/ /
|/| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
'master'
Add docs explaining why you get signed out with "Remember me" checked
See merge request gitlab-org/gitlab-ce!15756
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
See https://gitlab.slack.com/archives/C101F3796/p1512486640000434
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Moving the check out of the general requests, makes sure we don't have
any slowdown in the regular requests.
To keep the process performing this checks small, the check is still
performed inside a unicorn. But that is called from a process running
on the same server.
Because the checks are now done outside normal request, we can have a
simpler failure strategy:
The check is now performed in the background every
`circuitbreaker_check_interval`. Failures are logged in redis. The
failures are reset when the check succeeds. Per check we will try
`circuitbreaker_access_retries` times within
`circuitbreaker_storage_timeout` seconds.
When the number of failures exceeds
`circuitbreaker_failure_count_threshold`, we will block access to the
storage.
After `failure_reset_time` of no checks, we will clear the stored
failures. This could happen when the process that performs the checks
is not running.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
'40555-replace-absolute-urls-with-related-branches-to-avoid-hostname' into 'master'
Replace absolute URLs on related branches/MRs with relative url to avoid hostname
Closes #40555
See merge request gitlab-org/gitlab-ce!15735
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
hostname
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
fix #39233 - 500 in merge request
Closes #39233
See merge request gitlab-org/gitlab-ce!15774
|
| | | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
- handle unchanged empty lines in inline diff
|
| |\ \ \ \ \ \ \ \
| |_|_|_|_|/ / /
|/| | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
'master'
Dependency validator
Closes #34834
See merge request gitlab-org/gitlab-ce!14009
|
| | | | | | | | | |
|
| |\ \ \ \ \ \ \ \
| |_|_|_|_|_|_|/
|/| | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Fixed remove deploy key loading icon not being removed after canceling
Closes #37595
See merge request gitlab-org/gitlab-ce!15779
|
| | | |_|_|_|_|/
| |/| | | | |
| | | | | | |
| | | | | | | |
Closes #37595
|
| | | | | | | | |
|
| |\ \ \ \ \ \ \
| |_|_|_|_|/ /
|/| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Fixed merge request locked icon size
Closes #40876
See merge request gitlab-org/gitlab-ce!15767
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Closes #40876
|
