summaryrefslogtreecommitdiff
path: root/changelogs/unreleased
Commit message (Collapse)AuthorAgeFilesLines
* Disallow NULL values for environments.project_idci-environment-status-performanceYorick Peterse2017-09-131-0/+5
|
* Constrain environment deployments to project IDsYorick Peterse2017-09-131-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When querying the deployments of an environment the query Rails produces will be along the lines of the following: SELECT * FROM deployments WHERE environment_id = X For queries such as this (or queries that use this as their base and add more conditions) there is no meaningful index that can be used as long as deployments.project_id is not part of a WHERE clause. To work around this we change that "has_many :deployments" relation to always add a "WHERE project_id = X" condition. This means that queries filtering deployments can make better use of the existing indexes. For example, when filtering by deployments.iid this will result in the following query: SELECT * FROM deployments WHERE environment_id = X AND project_id = Y AND iid = Z This means PostgreSQL can use the existing index on (project_id, environment_id, iid) instead of having to use a different index (or none at all) and having to scan over a large amount of data. Query plan wise this means that instead of this query and plan: EXPLAIN (BUFFERS, ANALYZE) SELECT deployments.* FROM deployments WHERE deployments.environment_id = 5 AND deployments.iid = 225; Index Scan using index_deployments_on_project_id_and_iid on deployments (cost=0.42..14465.75 rows=1 width=117) (actual time=6.394..38.048 rows=1 loops=1) Index Cond: (iid = 225) Filter: (environment_id = 5) Rows Removed by Filter: 839 Buffers: shared hit=4534 Planning time: 0.076 ms Execution time: 38.073 ms We produce the following query and plan: EXPLAIN (BUFFERS, ANALYZE) SELECT deployments.* FROM deployments WHERE deployments.environment_id = 5 AND deployments.iid = 225 AND deployments.project_id = 1292351; Index Scan using index_deployments_on_project_id_and_iid on deployments (cost=0.42..4.45 rows=1 width=117) (actual time=0.018..0.018 rows=1 loops=1) Index Cond: ((project_id = 1292351) AND (iid = 225)) Filter: (environment_id = 5) Buffers: shared hit=4 Planning time: 0.088 ms Execution time: 0.039 ms On GitLab.com these changes result in a (roughly) 11x improvement in SQL timings for the CI environment status endpoint. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/36877
* Merge branch 'zj-auto-devops-banner' into 'master'Kamil Trzciński2017-09-131-0/+6
|\ | | | | | | | | | | | | AutoDevOps banner hidden on explicit CI config Closes #37652 See merge request !14207
| * AutoDevOps banner hidden on explicit CI configZeger-Jan van de Weg2017-09-131-0/+6
| | | | | | | | | | | | | | Extends the helper method to no show the banner as soon as the project has a `.gitlab-ci.yml` file on the default branch. Fixes gitlab-org/gitlab-ce#37652
* | Fix: GPG tmp dir removal race conditionAlexis Reigel2017-09-131-0/+5
| |
* | Merge branch 'replace_profile_active_tab.feature' into 'master'Rémy Coutable2017-09-131-0/+5
|\ \ | |/ |/| | | | | Replace the 'profile/active_tab.feature' spinach test with an rspec analog See merge request !14239
| * Replace the 'profile/active_tab.feature' spinach test with an rspec analogVitaliy @blackst0ne Klachkov2017-09-131-0/+5
| |
* | Merge branch ↵Douwe Maan2017-09-131-0/+5
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | '37629-lazy-image-loading-breaks-notification-mails-for-an-added-screenshot' into 'master' Resolve "Lazy image loading breaks notification mails for an added screenshot" Closes #37629 See merge request !14161
| * | Remove ImageLazyLoadFilter from EmailPipeline37629-lazy-image-loading-breaks-notification-mails-for-an-added-screenshotRobert Speicher2017-09-121-0/+5
| | |
* | | Merge branch 'zj-feature-flipper-disable-banner' into 'master'Kamil Trzciński2017-09-131-0/+5
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Allow all AutoDevOps banners to be disabled Closes #37653 See merge request !14218
| * | | Allow all AutoDevOps banners to be disabledZeger-Jan van de Weg2017-09-121-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Given the default in the development and production environment is false, the negation of enabling is used in the flag to signal you'd turn it off. It reads a bit awkward, but makes us have a migration less. Fixes gitlab-org/gitlab-ce#37653
* | | | Merge branch 'zj-usage-data-auto-devops' into 'master'Kamil Trzciński2017-09-131-0/+5
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add usage ping for Auto DevOps Closes #37648 See merge request !14162
| * | | | Add usage ping for Auto DevOpsZeger-Jan van de Weg2017-09-081-0/+5
| | | | | | | | | | | | | | | | | | | | Fixes gitlab-org/gitlab-ce#37648
* | | | | Add help text to runner edit page that tags should be separated by commas.Brendan O'Leary2017-09-131-0/+5
| | | | |
* | | | | Merge branch '5836-move-lib-ci-into-gitlab-namespace' into 'master'Grzegorz Bizon2017-09-131-0/+5
|\ \ \ \ \ | |_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | Resolve "Move `lib/ci` to `lib/gitlab/ci`" Closes #5836 See merge request !14078
| * | | | adds changelogMaxim Rydkin2017-09-121-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fix CI fix CI
* | | | | Resolve "Image onion skin + swipe does not work anymore"Tim Zallmann2017-09-121-0/+5
| | | | |
* | | | | Merge branch 'revert-2f46c3a8' into 'master'Robert Speicher2017-09-121-0/+5
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | Revert "Merge branch 'revert-f2421b2b' into 'master'" See merge request !14190
| * | | | Revert "Merge branch 'revert-f2421b2b' into 'master'"revert-2f46c3a8Annabel Dunstone Gray2017-09-111-0/+5
| | | | | | | | | | | | | | | This reverts merge request !14148
* | | | | Decrease Perceived Complexity threshold to 15Maxim Rydkin2017-09-121-0/+5
| | | | |
* | | | | Decrease Cyclomatic Complexity threshold to 13Maxim Rydkin2017-09-121-0/+5
| |_|_|/ |/| | |
* | | | Resolve "Error 500 in non-UTF8 branch names"Micael Bergeron2017-09-121-0/+4
| | | |
* | | | Merge branch 'detect-orphaned-repositories' into 'master'Douwe Maan2017-09-121-0/+5
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Detect orphaned repositories See merge request !14204
| * | | | Changelogdetect-orphaned-repositoriesGabriel Mazetto2017-09-121-0/+5
| | | | |
* | | | | Merge branch 'housekeeping_settings' into 'master'Douwe Maan2017-09-121-0/+6
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow to use same periods for housekeeping tasks Closes #34981 See merge request !13711
| * | | | | Allow to use same periods for housekeeping tasksAlex Lossent2017-09-111-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This enables skipping a lesser housekeeping task (incremental or full repack) by consistently scheduling a higher task (respectively full repack or gc) with the same period. Cf. #34981
* | | | | | Merge branch 'replace_project_issues_award_emoji.feature' into 'master'Rémy Coutable2017-09-121-0/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace the 'project/issues/award_emoji.feature' spinach test with an rspec analog See merge request !14202
| * | | | | | Replace the 'project/issues/award_emoji.feature' spinach test with an rspec ↵Vitaliy @blackst0ne Klachkov2017-09-121-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | analog
* | | | | | | Merge branch 'replace_project_builds_summary.feature' into 'master'Rémy Coutable2017-09-121-0/+5
|\ \ \ \ \ \ \ | |_|_|_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | Replace the 'project/builds/summary.feature' spinach test with an rspec analog See merge request !14177
| * | | | | | Replace the 'project/builds/summary.feature' spinach test with an rspec analogVitaliy @blackst0ne Klachkov2017-09-121-0/+5
| |/ / / / /
* | | | | | Merge branch 'dashboards-projects-controller' into 'master'Rémy Coutable2017-09-121-0/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Eager load namespace owners for project dashboards Closes #27376 See merge request !14188
| * | | | | | Eager load namespace owners for project dashboardsdashboards-projects-controllerYorick Peterse2017-09-111-0/+5
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | This solves an N+1 query problem where we'd run multiple queries when getting the namespace owners of the displayed projects.
* | | | | | Merge branch '36953-add-gitLab-pages-version-to-admin-dashboard' into 'master'Rémy Coutable2017-09-121-0/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add GitLab-Pages version to Admin Dashboard Closes #36953 See merge request !14040
| * | | | | | Add GitLab-Pages version to Admin DashboardTravis Miller2017-09-071-0/+5
| | |_|_|_|/ | |/| | | |
* | | | | | Merge branch 'hide-read-registry-scope-when-registry-disabled' into 'master'Kamil Trzciński2017-09-121-0/+4
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | | | | | | | | | | | | | Hide read_registry scope when registry is disabled on instance See merge request !13314
| * | | | | Hide read_registry scope when registry is disabled on instanceRobin Bobbitt2017-08-211-0/+4
| | | | | |
* | | | | | Merge branch 'replace_project_merge_requests_revert.feature' into 'master'Rémy Coutable2017-09-121-0/+6
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace the 'project/merge_requests/revert.feature' spinach test with an rspec analog See merge request !14201
| * | | | | | Replace the 'project/merge_requests/revert.feature' spinach test with an ↵Vitaliy @blackst0ne Klachkov2017-09-121-0/+6
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | rspec analog
* | | | | | Merge branch 'replace_milestone.feature' into 'master'Rémy Coutable2017-09-121-0/+5
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | Replace the 'project/milestone.feature' spinach test with an rspec analog See merge request !14171
| * | | | | Replace the project/milestone.feature spinach test with an rspec analogVitaliy @blackst0ne Klachkov2017-09-121-0/+5
| | | | | |
* | | | | | Make all the tooltips in the same direction on the commit info boxJedidiah2017-09-111-0/+5
| | | | | |
* | | | | | Merge branch 'replace_project_merge_requests_accept.feature' into 'master'Rémy Coutable2017-09-111-0/+5
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | | | | | | | | | | | | | Replace the 'project/merge_requests/accept.feature' spinach test with an rspec analog See merge request !14176
| * | | | | Replace the 'project/merge_requests/accept.feature' spinach test with an ↵blackst0ne2017-09-111-0/+5
| |/ / / / | | | | | | | | | | | | | | | rspec analog
* | | | | Merge branch 'replace_spinach_wiki.feature' into 'master'Rémy Coutable2017-09-111-0/+5
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Replace 'project/wiki.feature' spinach test with an rspec analog See merge request !13856
| * | | | | Replace 'project/wiki.feature' spinach test with an rspec analogVitaliy @blackst0ne Klachkov2017-09-111-0/+5
| |/ / / /
* | | | | Emoji was rendered as italicBranka Martinovic2017-09-111-0/+5
| | | | |
* | | | | Merge branch 'replace_group_links.feature' into 'master'Rémy Coutable2017-09-111-0/+5
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Replace 'project/group_links.feature' spinach test with an rspec analog See merge request !14169
| * | | | | Replace project/group_links.feature spinach test with an rspec analogVitaliy @blackst0ne Klachkov2017-09-101-0/+5
| |/ / / /
* | | | | Adds Event polyfill for IEFilipa Lacerda2017-09-111-0/+5
| | | | |
* | | | | Merge branch 'replace_emails.feature' into 'master'Rémy Coutable2017-09-111-0/+5
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Replace the 'profile/emails.feature' spinach test with an rspec analog See merge request !14172
View Lorry Controller Status