summaryrefslogtreecommitdiff
path: root/changelogs/unreleased
Commit message (Collapse)AuthorAgeFilesLines
* [skip ci] Add changelogforce-two-up-viewClement Ho2017-09-201-0/+5
|
* fix #35290 Make read-only API for public merge requests available without ↵haseeb2017-09-181-0/+4
| | | | authentication
* Merge branch 'add_closed_at_attribute' into 'master'Rémy Coutable2017-09-181-0/+5
|\ | | | | | | | | | | | | Add 'closed_at' attribute to Issues API Closes #5935 See merge request gitlab-org/gitlab-ce!14316
| * Add 'closed_at' attribute to Issues APIVitaliy @blackst0ne Klachkov2017-09-161-0/+5
| |
* | Merge branch 'sh-optimize-discussion-json' into 'master'Yorick Peterse2017-09-181-0/+5
|\ \ | | | | | | | | | | | | | | | | | | Eliminate N+1 queries in loading discussions.json endpoint Closes #37955 See merge request gitlab-org/gitlab-ce!14327
| * | Eliminate N+1 queries in loading discussions.json endpointsh-optimize-discussion-jsonStan Hu2017-09-181-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In #37955,we see that the profile had a number of N+1 queries from repeated access to `cross_reference_not_visible_for?`. This was optimized in previous versions of GitLab by rendering all notes at once, counting the number of visible references, and then using that number to check whether a system note should be fully redacted. There was also another N+1 query calling `ProjectTeam#member?`, which did not take advantage of an optimization in prepare_notes_for_rendering that would preload the maximum access level per project. Closes #37955
* | | Merge branch '37590-pipelines-mr' into 'master'Annabel Dunstone Gray2017-09-181-0/+5
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Fix mini graph pipeline breaking in merge request view Closes #37590 See merge request gitlab-org/gitlab-ce!14306
| * | | Fix mini graph pipeline breakin in merge request view37590-pipelines-mrFilipa Lacerda2017-09-151-0/+5
| | |/ | |/|
* | | Merge branch 'milestone-avatar-issuable-link' into 'master'Tim Zallmann2017-09-181-0/+5
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Fixes milestone issuable assignee URL Closes #33124 See merge request gitlab-org/gitlab-ce!14292
| * | | Fixes milestone issuable assignee URLmilestone-avatar-issuable-linkPhil Hughes2017-09-151-0/+5
| | | | | | | | | | | | | | | | Closes #33124
* | | | Merge branch 'docs-17499-documentation-errors-about-creating-a-new-tag' into ↵Achilleas Pipinellis2017-09-181-0/+5
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'master' Fix docs for lightweight tag creation via API Closes #17499 See merge request gitlab-org/gitlab-ce!14328
| * | | | Fix docs for lightweight tag creation via APIMark Fletcher2017-09-181-0/+5
| | | | |
* | | | | Merge branch 'replace_project_snippets.feature' into 'master'Rémy Coutable2017-09-181-0/+5
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Replace the 'project/snippets.feature' spinach test with an rspec analog See merge request gitlab-org/gitlab-ce!14326
| * | | | | Replace the 'project/snippets.feature' spinach test with an rspec analogVitaliy @blackst0ne Klachkov2017-09-181-0/+5
| | | | | |
* | | | | | Merge branch '24121_extract_yet_another_users_finder' into 'master'Grzegorz Bizon2017-09-181-0/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Extract AutocompleteController#users into finder Closes #24121 See merge request gitlab-org/gitlab-ce!13778
| * | | | | | add Mayra Cabrera to authors of changeMaxim Rydkin2017-09-101-1/+1
| | | | | | |
| * | | | | | adds changelogMaxim Rydkin2017-09-101-0/+5
| | | | | | |
* | | | | | | Merge branch 'replace_project_commits_revert.feature' into 'master'Rémy Coutable2017-09-181-0/+5
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace the 'project/commits/revert.feature' spinach test with an rspec analog See merge request gitlab-org/gitlab-ce!14325
| * | | | | | | Replace the 'project/commits/revert.feature' spinach test with an rspec analogVitaliy @blackst0ne Klachkov2017-09-181-0/+5
| | |/ / / / / | |/| | | | |
* | | | | | | Merge branch 'replace_project_archived.feature' into 'master'Rémy Coutable2017-09-181-0/+5
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace the 'project/archived.feature' spinach test with an rspec analog See merge request gitlab-org/gitlab-ce!14322
| * | | | | | | Replace the 'project/archived.feature' spinach test with an rspec analogVitaliy @blackst0ne Klachkov2017-09-171-0/+5
| |/ / / / / /
* | | | | | | Merge branch 'replace_search.feature' into 'master'Rémy Coutable2017-09-181-0/+5
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | | | | | | | | | | | | | | Replace the 'search.feature' spinach test with an rspec analog See merge request gitlab-org/gitlab-ce!14248
| * | | | | | Replace the 'search.feature' spinach test with an rspec analogVitaliy @blackst0ne Klachkov2017-09-161-0/+5
| | |_|_|/ / | |/| | | |
* | | | | | Fixed the new sidebars width when browser has scrollbarsPhil Hughes2017-09-161-0/+5
| |_|_|_|/ |/| | | |
* | | | | Merge branch 'master' into 'issue_37640'issue_37640Felipe Artur2017-09-1541-0/+206
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | # Conflicts: # db/schema.rb
| * | | | | created services for keyshaseeb2017-09-151-0/+4
| | | | | |
| * | | | | Merge branch '21331-improve-confusing-compare-page' into 'master'Phil Hughes2017-09-151-0/+5
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make the labels in the Compare form less confusing Closes #21331 See merge request gitlab-org/gitlab-ce!14225
| | * | | | | Make the labels in the Compare form less confusing21331-improve-confusing-compare-pageRémy Coutable2017-09-151-0/+5
| | |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Improve the descriptive text * Rename "from" to "Target" and "to" to "Source" * Swap "Target" and "Source" to have the same order as in MRs * Reworded "Switch base of comparison" to "Swap versions" Signed-off-by: Rémy Coutable <remy@rymai.me>
| * | | | | Merge branch 'projects-controller-show' into 'master'Rémy Coutable2017-09-152-0/+10
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | SQL performance improvements for ProjectsController#show See merge request gitlab-org/gitlab-ce!14226
| | * | | | | Memoize the latest builds of a pipelineprojects-controller-showYorick Peterse2017-09-141-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This ensures that if a pipeline is present for the last commit on a project's homepage we only run 1 query to get the builds, instead of running 2 queries. See https://gitlab.com/gitlab-org/gitlab-ce/issues/36878#note_40073339 for more information.
| | * | | | | Memoize pipelines for project download buttonsYorick Peterse2017-09-141-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds Project#latest_successful_pipeline_for and Project#latest_successful_pipeline_for_default_branch. The 2nd method memoizes the result (taking nil values into account) to ensure the underlying query isn't executed multiple times when viewing a project's homepage. See https://gitlab.com/gitlab-org/gitlab-ce/issues/36878#note_40073607 for more information.
| * | | | | | Display whether branch has been merged when deleting protected branchWinnie Hellmann2017-09-151-0/+5
| | |/ / / / | |/| | | |
| * | | | | Merge branch '20824-scope-users-to-members-in-group-issuable-list' into 'master'Phil Hughes2017-09-151-0/+5
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolve "Scope users by group inside dropdowns if I'm on group page (Issue, MRs)" Closes #20824 See merge request gitlab-org/gitlab-ce!14249
| | * | | | | Return only group's members in user dropdowns on issuables list pages20824-scope-users-to-members-in-group-issuable-listRémy Coutable2017-09-141-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
| * | | | | | Merge branch 'ci-environment-status-performance' into 'master'Stan Hu2017-09-142-0/+10
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Constrain environment deployments to project IDs Closes #36877 See merge request gitlab-org/gitlab-ce!14252
| | * | | | | | Disallow NULL values for environments.project_idci-environment-status-performanceYorick Peterse2017-09-131-0/+5
| | | | | | | |
| | * | | | | | Constrain environment deployments to project IDsYorick Peterse2017-09-131-0/+5
| | |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When querying the deployments of an environment the query Rails produces will be along the lines of the following: SELECT * FROM deployments WHERE environment_id = X For queries such as this (or queries that use this as their base and add more conditions) there is no meaningful index that can be used as long as deployments.project_id is not part of a WHERE clause. To work around this we change that "has_many :deployments" relation to always add a "WHERE project_id = X" condition. This means that queries filtering deployments can make better use of the existing indexes. For example, when filtering by deployments.iid this will result in the following query: SELECT * FROM deployments WHERE environment_id = X AND project_id = Y AND iid = Z This means PostgreSQL can use the existing index on (project_id, environment_id, iid) instead of having to use a different index (or none at all) and having to scan over a large amount of data. Query plan wise this means that instead of this query and plan: EXPLAIN (BUFFERS, ANALYZE) SELECT deployments.* FROM deployments WHERE deployments.environment_id = 5 AND deployments.iid = 225; Index Scan using index_deployments_on_project_id_and_iid on deployments (cost=0.42..14465.75 rows=1 width=117) (actual time=6.394..38.048 rows=1 loops=1) Index Cond: (iid = 225) Filter: (environment_id = 5) Rows Removed by Filter: 839 Buffers: shared hit=4534 Planning time: 0.076 ms Execution time: 38.073 ms We produce the following query and plan: EXPLAIN (BUFFERS, ANALYZE) SELECT deployments.* FROM deployments WHERE deployments.environment_id = 5 AND deployments.iid = 225 AND deployments.project_id = 1292351; Index Scan using index_deployments_on_project_id_and_iid on deployments (cost=0.42..4.45 rows=1 width=117) (actual time=0.018..0.018 rows=1 loops=1) Index Cond: ((project_id = 1292351) AND (iid = 225)) Filter: (environment_id = 5) Buffers: shared hit=4 Planning time: 0.088 ms Execution time: 0.039 ms On GitLab.com these changes result in a (roughly) 11x improvement in SQL timings for the CI environment status endpoint. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/36877
| * | | | | | Merge branch 'change-dashed-border-button-color' into 'master'Annabel Dunstone Gray2017-09-141-0/+5
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changed dashed border button color to be darker See merge request gitlab-org/gitlab-ce!14041
| | * | | | | | changed dashed border button color to be darkerchange-dashed-border-button-colorDimitrie Hoekstra2017-09-141-0/+5
| | | |/ / / / | | |/| | | |
| * | | | | | Add missing classes to omniauth remember-me checkbox and add correct font-sizeJedidiah2017-09-141-0/+5
| | | | | | |
| * | | | | | Merge branch 'refactor-animate-js' into 'master'Clement Ho2017-09-141-0/+5
| |\ \ \ \ \ \ | | |_|_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | Reduce footprint of animate.js See merge request gitlab-org/gitlab-ce!14187
| | * | | | | Remove animate.js and the issuable label pulse animation.refactor-animate-jsBryce Johnson2017-09-131-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Nobody tell @jschatz1 :P
| * | | | | | Merge branch '37759-also-treat-newlines-as-separator' into 'master'Kamil Trzciński2017-09-141-0/+5
| |\ \ \ \ \ \ | | |_|/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Treat newlines as separators for pipeline emails service Closes #37759 See merge request gitlab-org/gitlab-ce!14250
| | * | | | | Add changelog entry37759-also-treat-newlines-as-separatorLin Jen-Shin2017-09-131-0/+5
| | | |/ / / | | |/| | |
| * | | | | Truncate milestone text on collapse; add tooltip for titleAnnabel Dunstone Gray2017-09-141-0/+5
| | | | | |
| * | | | | Merge branch '34510-board-issues-sql-speedup' into 'master'Douwe Maan2017-09-141-0/+5
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fix #34510 add association preloading for issue boards Closes #34510 See merge request gitlab-org/gitlab-ce!14198
| | * | | | | add changelog entrymicael.bergeron2017-09-121-0/+5
| | | | | | |
| * | | | | | Merge branch ↵Douwe Maan2017-09-141-0/+5
| |\ \ \ \ \ \ | | |_|_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | '37576-renamed-files-have-escaped-html-for-the-inline-diff-in-the-header' into 'master' Resolve "Renamed files have escaped HTML for the inline diff in the header" Closes #37576 See merge request gitlab-org/gitlab-ce!14121
| | * | | | | rework the html_safe not to use haml's auto escapingmicael.bergeron2017-09-111-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | add feature test for inline diff in file header
| * | | | | | Refactor MonitoringService classMike Greiling2017-09-131-0/+5
| | | | | | |
View Lorry Controller Status