summaryrefslogtreecommitdiff
path: root/changelogs
Commit message (Collapse)AuthorAgeFilesLines
* Add a system hook for when a project is updated.Tommy Beadle2017-01-261-0/+4
| | | | | | | This sends a project_update hook when a repo is updated. This does not include renaming or transferring a project. Those are covered by project_rename and project_transfer. This will get called, however, when the visibility is changed.
* Merge branch '27178-update-builds-link-in-project-settings' into 'master' Sean McGivern2017-01-261-0/+4
|\ | | | | | | | | | | | | Fixed builds info link on project settings page Closes #27178 See merge request !8762
| * Fixed builds info link on project settings pageRyan Harris2017-01-251-0/+4
| |
* | Merge branch '26068_tasklist_issue' into 'master' Sean McGivern2017-01-261-0/+4
|\ \ | | | | | | | | | | | | | | | | | | don’t count tasks that are not defined as list items correctly Closes #26068 See merge request !8526
| * | Don’t count tasks that are not defined as list items correctlyJarka Kadlecova2017-01-251-0/+4
| | |
* | | Update CHANGELOG.md for 8.16.2DJ Mountney2017-01-255-19/+0
| | | | | | | | | [ci skip]
* | | Merge branch '27013-regression-in-commit-title-bar' into 'master' Annabel Dunstone Gray2017-01-251-0/+4
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Resolve "regression in commit title bar" Closes #27013 See merge request !8751
| * | | added changelog entry27013-regression-in-commit-title-bardimitrieh2017-01-241-0/+4
| | | |
* | | | Merge branch 'display-project-id' into 'master' 26001-show-tags-which-contain-a-given-commit-in-their-own-metadata-row-on-the-commit-page-widgetClement Ho2017-01-251-0/+4
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Display project ID Closes #18350 See merge request !8572
| * | | | Display project ID in project settings (!8572)winniehell2017-01-251-0/+4
| | | | |
* | | | | Merge branch 'fix/26518' into 'master' Douwe Maan2017-01-251-0/+4
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix access to the wiki code via HTTP when repository feature disabled Closes #26518 See merge request !8758
| * | | | | Add CHANGELOG entryfix/26518Douglas Barbosa Alexandre2017-01-251-0/+4
| | | | | |
* | | | | | Merge branch 'copy-as-md' into 'master' Jacob Schatz2017-01-251-0/+4
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Copying a rendered issue/comment will paste into GFM textareas as actual GFM See merge request !8597
| * \ \ \ \ \ Merge branch 'master' into copy-as-mdDouwe Maan2017-01-2511-0/+44
| |\ \ \ \ \ \ | | |/ / / / / | | | | | | | | | | | | | | | | | | | | | # Conflicts: # app/assets/javascripts/lib/utils/common_utils.js.es6
| * | | | | | Merge branch 'master' into copy-as-mdDouwe Maan2017-01-24136-465/+81
| |\ \ \ \ \ \
| * \ \ \ \ \ \ Merge branch 'master' into copy-as-mdDouwe Maan2017-01-1919-0/+76
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | # Conflicts: # app/assets/javascripts/lib/utils/common_utils.js.es6
| * | | | | | | | Copying a rendered issue/comment will paste into GFM textareas as actual GFMDouwe Maan2017-01-161-0/+4
| | | | | | | | |
* | | | | | | | | Merge branch '26186-diff-view-plus-and-minus-signs-as-part-of-line-number' ↵Annabel Dunstone Gray2017-01-251-0/+4
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | into 'master' Color + and - signs in diffs to increase code legibility Closes #26186 See merge request !8768
| * | | | | | | | | Color + and - signs in diffs to increase code legibilitydimitrieh2017-01-251-0/+4
| | | | | | | | | |
* | | | | | | | | | Merge branch '27021-line-numbers-now-in-copy-pasta-data' into 'master' Fatih Acet2017-01-251-0/+4
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolve "Line numbers now in copy pasta data" Closes #27021 See merge request !8706
| * | | | | | | | | | Prevent copying of line numbers in parallel diff view27021-line-numbers-now-in-copy-pasta-datasamrose32017-01-221-0/+4
| | | | | | | | | | |
* | | | | | | | | | | Merge branch 'refresh-authorizations-fork-join' into 'master' Douwe Maan2017-01-251-0/+4
|\ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix race conditions for AuthorizedProjectsWorker Closes #26194 and #26310 See merge request !8701
| * | | | | | | | | | Fix race conditions for AuthorizedProjectsWorkerrefresh-authorizations-fork-joinYorick Peterse2017-01-251-0/+4
| |/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were two cases that could be problematic: 1. Because sometimes AuthorizedProjectsWorker would be scheduled in a transaction it was possible for a job to run/complete before a COMMIT; resulting in it either producing an error, or producing no new data. 2. When scheduling jobs the code would not wait until completion. This could lead to a user creating a project and then immediately trying to push to it. Usually this will work fine, but given enough load it might take a few seconds before a user has access. The first one is problematic, the second one is mostly just annoying (but annoying enough to warrant a solution). This commit changes two things to deal with this: 1. Sidekiq scheduling now takes places after a COMMIT, this is ensured by scheduling using Rails' after_commit hook instead of doing so in an arbitrary method. 2. When scheduling jobs the calling thread now waits for all jobs to complete. Solution 2 requires tracking of job completions. Sidekiq provides a way to find a job by its ID, but this involves scanning over the entire queue; something that is very in-efficient for large queues. As such a more efficient solution is necessary. There are two main Gems that can do this in a more efficient manner: * sidekiq-status * sidekiq_status No, this is not a joke. Both Gems do a similar thing (but slightly different), and the only difference in their name is a dash vs an underscore. Both Gems however provide far more than just checking if a job has been completed, and both have their problems. sidekiq-status does not appear to be actively maintained, with the last release being in 2015. It also has some issues during testing as API calls are not stubbed in any way. sidekiq_status on the other hand does not appear to be very popular, and introduces a similar amount of code. Because of this I opted to write a simple home grown solution. After all, all we need is storing a job ID somewhere so we can efficiently look it up; we don't need extra web UIs (as provided by sidekiq-status) or complex APIs to update progress, etc. This is where Gitlab::SidekiqStatus comes in handy. This namespace contains some code used for tracking, removing, and looking up job IDs; all without having to scan over an entire queue. Data is removed explicitly, but also expires automatically just in case. Using this API we can now schedule jobs in a fork-join like manner: we schedule the jobs in Sidekiq, process them in parallel, then wait for completion. By using Sidekiq we can leverage all the benefits such as being able to scale across multiple cores and hosts, retrying failed jobs, etc. The one downside is that we need to make sure we can deal with unexpected increases in job processing timings. To deal with this the class Gitlab::JobWaiter (used for waiting for jobs to complete) will only wait a number of seconds (30 by default). Once this timeout is reached it will simply return. For GitLab.com almost all AuthorizedProjectWorker jobs complete in seconds, only very rarely do we spike to job timings of around a minute. These in turn seem to be the result of external factors (e.g. deploys), in which case a user is most likely not able to use the system anyway. In short, this new solution should ensure that jobs are processed properly and that in almost all cases a user has access to their resources whenever they need to have access.
* | | | | | | | | | Merge branch 'label-select-toggle' into 'master' kamil-test-branchFatih Acet2017-01-251-0/+4
|\ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixed label select toggle not updating correctly Closes #26119 See merge request !8601
| * | | | | | | | | Fixed label select toggle not updating correctlylabel-select-togglePhil Hughes2017-01-161-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #26119
* | | | | | | | | | Merge branch '26775-fix-auto-complete-initial-loading' into 'master' Fatih Acet2017-01-251-0/+4
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix autocomplete initial undefined state (loading) Closes #26775 See merge request !8667
| * | | | | | | | | | Fix autocomplete initial undefined state26775-fix-auto-complete-initial-loadingEric Eastwood2017-01-231-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/26775
* | | | | | | | | | | Merge branch '25312-search-input-cmd-click-issue' into 'master' Fatih Acet2017-01-251-0/+4
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prevent removal of input that is the parent dropdown element Closes #25312 See merge request !8397
| * | | | | | | | | | | Prevent removing fields from dropdowns on input elementsSam Rose2017-01-251-0/+4
| | | | | | | | | | | |
* | | | | | | | | | | | Merge branch 'fix-ci-requests-concurrency' into 'master' Grzegorz Bizon2017-01-251-0/+3
|\ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix CI requests concurrency See merge request !8760
| * | | | | | | | | | | Add CHANGELOGKamil Trzcinski2017-01-251-0/+3
| | |_|_|_|_|_|_|/ / / | |/| | | | | | | | |
* | | | | | | | | | | Merge branch '27014-fix-pipeline-tooltip-wrapping' into 'master' Annabel Dunstone Gray2017-01-251-0/+4
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix mini-pipeline stage tooltip text wrapping Closes #27014 See merge request !8771
| * | | | | | | | | | | Fix mini-pipeline stage tooltip text wrapping27014-fix-pipeline-tooltip-wrappingEric Eastwood2017-01-241-0/+4
| | |_|_|_|_|/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/27014
* | | | | | | | | | | Display fullscreen button on small screens (!5302)winniehell2017-01-251-0/+4
| |_|_|_|_|_|_|_|_|/ |/| | | | | | | | |
* | | | | | | | | | Merge branch 'tc-only-mr-button-if-allowed' into 'master' Sean McGivern2017-01-251-0/+4
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Only show Merge Request button when user can create a MR See merge request !8639
| * | | | | | | | | | Only show Merge Request button when user can create a MRToon Claes2017-01-201-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Create Merge Request button only should be shown when the user is allowed to create a Merge request.
* | | | | | | | | | | Merge branch 'no_project_notes' into 'master' Sean McGivern2017-01-251-0/+4
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Support notes without a project (personal snippets notes) See merge request !8468
| * | | | | | | | | | | Support notes without projectJarka Kadlecova2017-01-181-0/+4
| | | | | | | | | | | |
* | | | | | | | | | | | Merge branch 'fix_broken_diff_discussions' into 'master' Sean McGivern2017-01-251-0/+4
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make diff discussions more reliable Closes #23646 See merge request !8378
| * | | | | | | | | | | | Make diff discussion more reliablefix_broken_diff_discussionsValery Sizov2016-12-301-0/+4
| | | | | | | | | | | | |
* | | | | | | | | | | | | Merge branch 'newline-eslint-rule' into 'master'Jacob Schatz2017-01-251-0/+4
|\ \ \ \ \ \ \ \ \ \ \ \ \ | |_|_|_|/ / / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add an eslint rule to flag extra newlines See merge request !8137
| * | | | | | | | | | | | Flag multiple empty lines in eslint, fix offenses.newline-eslint-ruleBryce Johnson2017-01-241-0/+4
| | | | | | | | | | | | |
* | | | | | | | | | | | | Merge branch '26447-fix-tab-list-order' into 'master' Clement Ho2017-01-241-0/+4
|\ \ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixed tab index order on branch commits list page Closes #26447 See merge request !8489
| * | | | | | | | | | | | Fixed tab index order on branch commits list pageRyan Harris2017-01-241-0/+4
| | | | | | | | | | | | |
* | | | | | | | | | | | | Merge branch '26468-fix-users-sort-in-admin-area' into 'master' Douwe Maan2017-01-241-0/+4
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixing sort of Users so that users who never logged in will be displayed last Closes #26468 See merge request !8637
| * | | | | | | | | | | | | Fixing sort of Users so that users who never logged in will be displayed lastPoornima M2017-01-241-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adding changelog entry
* | | | | | | | | | | | | | Merge branch 'misalinged-discussion-with-no-avatar-26854' into 'master' Fatih Acet2017-01-241-0/+4
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | adds avatar for discussion note Closes #26854 See merge request !8734
| * | | | | | | | | | | | | | adds changelogmisalinged-discussion-with-no-avatar-26854Nur Rony2017-01-241-0/+4
| | |_|_|_|_|_|_|/ / / / / / | |/| | | | | | | | | | | |
* | | | | | | | | | | | | | Merge branch 'broken_iamge_when_doing_offline_update_check(help_page)' into ↵Clement Ho2017-01-241-0/+4
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ | |_|_|/ / / / / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'master' fix broken image when doing offline update check(help page) Closes #25982 See merge request !8355
| * | | | | | | | | | | | | hide the version check image if internet connection is brokenKen Ding2017-01-251-0/+4
| | |_|_|_|_|_|_|_|_|_|_|/ | |/| | | | | | | | | | |
View Lorry Controller Status