| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome and other browsers ignore `autocomplete=false` and
`autocomplete=off` now. This likely caused the mirroring section to
expand whenever a user clicked "Expand" in the protected branches
settings.
https://developers.google.com/web/fundamentals/design-and-ux/input/forms/?hl=en
recommends using `new-password` as the new field to prevent automatic
filling.
This is similar to
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8477.
Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11237
|
| |
|
|\
| |
| |
| |
| |
| |
| | |
Show prioritized labels to guests
Closes #57247
See merge request gitlab-org/gitlab-ce!27307
|
| |
| |
| |
| | |
Disables sorting when guests are viewing
|
| | |
|
| |
| |
| | |
[ci skip]
|
|\ \
| |/
|/|
| |
| | |
Add configuration of access_level for runners on registration via API
See merge request gitlab-org/gitlab-ce!27490
|
| |
| |
| |
| |
| | |
Allow setting access_level of new runner to not_protected (default) or ref_protected
Minor update to relevant docs and tests
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Bump required Ruby version check to 2.5.3
Closes #60704
See merge request gitlab-org/gitlab-ce!27495
|
| |/
| |
| |
| |
| |
| | |
Relates to https://gitlab.com/gitlab-org/gitlab-ce/issues/58079
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60704
|
| | |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
'master'
CE Backport for "Restructure project merge request settings page"
See merge request gitlab-org/gitlab-ce!26834
|
| | |
| | |
| | |
| | |
| | | |
This commit updates the CE-specific files that reorganizes the project
merge request settings UI.
|
| | |
| | |
| | |
| | |
| | | |
* On the project labels page, the label itself should not be clickable.
* On the group labels page, the links for Issues and Merge Requests should be shown.
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Migrate correlation and tracing code to LabKit
See merge request gitlab-org/gitlab-ce!25379
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This change is a fairly straightforward refactor to extract the tracing
and correlation-id code from the gitlab rails codebase into the new
LabKit-Ruby project.
The corresponding import into LabKit-Ruby was in
https://gitlab.com/gitlab-org/labkit-ruby/merge_requests/1
The code itself remains very similar for now.
Extracting it allows us to reuse it in other projects, such as
Gitaly-Ruby. This will give us the advantages of correlation-ids and
distributed tracing in that project too.
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Only use backslash escapes in autocomplete when needed
Closes #45348
See merge request gitlab-org/gitlab-ce!27457
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Autocompletion for references happens on the frontend. Those references
are turned into actual references on the backend, but only after
Markdown processing has happened. That means that if a reference
contains a character that Markdown might consume, it won't render
correctly. So we need to do some escaping on the frontend.
We have these potential problem characters:
https://docs.gitlab.com/ee/user/markdown.html#emphasis
1. ~ - this is ~~strikethrough~~, but only when doubled.
2. _ - used for _emphasis_, doubled is __bold__.
3. * - also used for *emphasis*, doubled is **bold** also.
4. ` - used for `code spans`, any number works.
We don't need to escape `-` any more. When it comes to being inside a
word:
1. a~~b~~ has strikethrough, so it needs to be escaped everywhere.
2. a_b_ has no emphasis (see [a]) so it only needs to be escaped at the
start and end of words.
3. a*b* has emphasis, so it needs to be escaped everywhere.
4. a`b` has a code span, so it needs to be escaped everywhere.
Or, in code terms:
1. Always escape ~~, *, and ` when being inserted by autocomplete.
2. Escape _ when it's either at the beginning or the end of a word.
[a]: https://docs.gitlab.com/ee/user/markdown.html#multiple-underscores-in-words
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Extract discussion actions into separate component
Closes #58293
See merge request gitlab-org/gitlab-ce!27227
|
| | |_|/
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Created DiscussionActions component
- Updated NoteableDiscussion component accordingly
- Wrote Jest tests for DiscussionActions
- Updated Jest config to enable emojis aliases mock
- Updated qa specs to reflect changes in NoteableDiscussions
|
| |_|/
|/| | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
'60500-disable-jit-kubernetes-resource-creation-for-project-level-clusters' into 'master'
Disable JIT Kubernetes resource creation for project level clusters
Closes #60500
See merge request gitlab-org/gitlab-ce!27352
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
JIT resource creation blocks deployments if a user is
self-managing their cluster, as it will fail the build
if unable to create a namespace and service account.
Using a custom namespace and service account was previously
supported for project level clusters, so we should preserve
this functionality.
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/27352
|
| |/ /
|/| | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Only show author in autocomplete dropdown if author is active
See merge request gitlab-org/gitlab-ce!27292
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
#57815 Omniauth UltraAuth strategy
See merge request gitlab-org/gitlab-ce!26348
|
| | |_|/
| |/| | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Bring back Rugged implementation of ListCommitsByOid
See merge request gitlab-org/gitlab-ce!27441
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This brings back changes in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20432.
For users using Gitaly on top of NFS, accessing the Git data directly
via Rugged may be faster than going through than Gitaly. This merge
request introduces the feature flag `rugged_list_commits_by_oid` to
activate the Rugged method.
For one customer, we saw that ListCommitsByOid was the second highest
used endpoint that may be causing increased load.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Add backtrace to Gitaly performance bar
Closes #60092
See merge request gitlab-org/gitlab-ce!27345
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This adds the backtrace to a table to show exactly where the Gitaly call
was made to make it easier to understand where the call originated.
This change also collapses the details in the same row to improve the
usability when there is a backtrace.
|
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | | |
People who prefer plain text email also might prefer the raw job log
files. So include the link directly to there.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56849
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Restore "download repository path" feature, now with fixes and a feature flag
Closes gitlab-workhorse#218 and #24704
See merge request gitlab-org/gitlab-ce!27275
|
| | | | |
| | | | |
| | | | |
| | | | | |
This reverts commit 171818df0a72097aa1a804c8213666b3f66b0966.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Using custom_action and recipient filtering
Add more generic filtering to user_ids_notifiable_on
Add changelog entry
Remove commented class
Method is no longer needed
Overloading no longer required
Filter by action just in case of custom notification level
Add participant check
Fix unexpected extra notification mails
Using custom_action and recipient filtering
Add more generic filtering to user_ids_notifiable_on
Add changelog entry
Remove commented class
Method is no longer needed
Overloading no longer required
Filter by action just in case of custom notification level
Fix comment
Add repond_to? checks
Reverted custom_action filtering
Enhanced output of should_email helper
Changed :watch to :participating for custom notifiable users
Change spec variable name
Enhanced participating check
These conditions are no longer needed
Fix custom notification handling for participating type
Participating level should include maintainers
Fixed add_guest notification
Fix successful pipeline notification
Refactoring: Use maintainer? method on team instead
Add spec for new_issue: true for a custom group setting
which should have lower prio than an available project setting
Clean up specs
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Removes EE diffs for dropdown_value_collapsed.vue
Closes gitlab-ee#10083
See merge request gitlab-org/gitlab-ce!27367
|
| | |_|_|/
| |/| | | |
|
| | | | | |
|
|\ \ \ \ \
| |_|_|/ /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | | |
'master'
Allow extra args for helm in Auto-DevOps
See merge request gitlab-org/gitlab-ce!26838
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Set correct timestamps when creating past issues
Closes #58361
See merge request gitlab-org/gitlab-ce!27406
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Sets `system_note_timestamp` from `created_at`
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Test using Git 2.21
See merge request gitlab-org/gitlab-ce!27418
|
| | |_|_|/ /
| |/| | | |
| | | | | |
| | | | | |
| | | | | | |
Given Rails doesn't use the Git binary anymore, this shouldn't be a
problem.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Replaced "View file" button with doc-text icon
Closes #59034
See merge request gitlab-org/gitlab-ce!27365
|
| | |_|_|/ /
| |/| | | |
| | | | | |
| | | | | | |
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/59034
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
into 'master'
Update merge request widget to accommodate post-merge pipelines
See merge request gitlab-org/gitlab-ce!25983
|