| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
`ActiveSupport::Cache::RedisCacheStore` is not compatible with the
version of Rack Attack we are using (v4.4.1) per
https://github.com/kickstarter/rack-attack/issues/281. Users that had
rate limits enabled might see `Redis::CommandError: ERR value is not an
integer or out of range` because the `raw` parameter wasn't passed along
properly. As a result, the Rack Attack entry would be stored as an
`ActiveSupport::Cache::Entry` instead of a raw string holding an integer
value.
Let's partially revert the change in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30966 to use the
original cache store until we can update to Rack Attack v5.2.3 that has
support for `ActiveSupport::Cache::RedisCacheStore` via
https://github.com/kickstarter/rack-attack/pull/350.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66449
|
|\
| |
| |
| |
| | |
Remove concerns from eager load paths
See merge request gitlab-org/gitlab-ce!31649
|
| | |
|
| |
| |
| |
| |
| | |
Old cookies are still valid and are automatically
upgraded by Rails
|
|\ \
| |/
|/|
| |
| |
| |
| | |
Filter title, description, and body from logs
Closes #64460 and #60365
See merge request gitlab-org/gitlab-ce!31274
|
| |
| |
| |
| | |
These can contain sensitive content.
|
|/
|
|
|
|
|
|
|
|
|
|
| |
This is the first step in providing a fault-tolerant and distributed
Redis caching store. We disable compression to avoid introducing a
change that could have an adverse effect in production.
Note that we won't be able to take advantage of the fault-tolerance and
distributed features yet until we solve
https://gitlab.com/gitlab-org/gitlab-ce/issues/64829.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64794
|
|
|
|
| |
None of this code can be reached any more, so it can all be removed
|
|\
| |
| |
| |
| | |
Resolve difference in app/assets/stylesheets/application.scss
See merge request gitlab-org/gitlab-ce!31007
|
| | |
|
|/ |
|
|
|
|
| |
Updates changed method names and fixes spec failures
|
|
|
|
| |
We use the `Gitlab.ee` and `.ee?` methods in several initializers now.
|
|\
| |
| |
| |
| | |
Import bootstrap styles from gitlab-ui
See merge request gitlab-org/gitlab-ce!26165
|
| |
| |
| |
| |
| | |
Use gitlab_ui.scss instead of all the bootstrap imports
Allow the ../node_modules path from gitlab_ui.scss to resolve
|
|/
|
|
|
|
| |
This backports the EE changes made to this config file to CE. EE
specific bits do not need an `if Gitlab.ee?`, as everything will work
transparently when using CE.
|
|
|
|
| |
Model.new.attributes now also returns encrypted attributes.
|
|
|
|
| |
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
| |
|
| |
|
|
|
|
|
|
|
| |
Compile highlight CSS separately
Move highlight-specific mixins out of mixins.scss
Rename solarized themes to match theme name as this was a smaller
change than changing all instances to snake_case
|
|
|
|
| |
This change adds `note` to the Rails `filter_parameters` configuration.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
[Master] Redact sensitive information on gitlab-workhorse log
See merge request gitlab/gitlabhq!2584
|
|\
| |
| |
| |
| |
| |
| | |
Explicitly set locale fallbacks
Closes #54274
See merge request gitlab-org/gitlab-ce!23271
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
With a recent change in i18n, default language is not
included in fallbacks by default. This causes that
MissingTranslationData exception is raised both in
development and production mode.
This patch sets explicitly fallbacks language to english
which assures that english is used for missing translations.
|
|/
|
|
|
|
| |
When switching to rails 5, we added migration version to all migration
classes. This patch makes it possible to run versioned migrations
also with rails 4
|
|
|
|
|
|
|
|
| |
This significantly improves performance and reduces memory consumption
when parsing XML files. On a test with 124 JUnit files from a CE build,
there was about a 4x reduction in processing time.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54068
|
|
|
|
|
| |
* updates Gemfile
* uses Rails 5 unless explicitly disabled
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Manually includes the xterm custom colors
on the 3 files that will need it: job log page,
job terminal page, environment terminal page
Reduces main CSS bundle
|
|
|
|
|
|
|
|
|
|
|
| |
Rails does a partial match for strings in the filter_parameters
configuration, so the parameter "key" causes "key_id" to be filtered
even though it's a useful parameter for debugging internal API issues.
We now revise this filter to make any parameter ending with "key" is
filtered.
Relates to https://gitlab.com/gitlab-com/gl-infra/production/issues/463
|
|
|
|
| |
Fixes rails 5 deprecation warnings in `config/` files
|
|
|
|
| |
Use object.assign for default option
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
The previous implementation would hit the database each time
and provide a dummy response. If the database goes down, this
means all application workers would be taken out of service.
Simplify this check by using a Rails middleware that intercepts
this endpoint and returns a 200 response.
|
|\
| |
| |
| |
| | |
CE: Add PolicyCheckable concern for things passing to policy check
See merge request gitlab-org/gitlab-ce!20839
|
| | |
|
| | |
|
|/
|
|
|
| |
This is mainly the setup of mutations for GraphQL. Including
authorization and basic return type-structure.
|
| |
|
|
|
|
|
|
|
|
|
| |
This adds Keyset pagination to GraphQL lists. PoC for that is
pipelines on merge requests and projects.
When paginating a list, the base-64 encoded id of the ordering
field (in most cases the primary key) can be passed in the `before` or
`after` GraphQL argument.
|
|
|
|
|
|
|
|
|
|
| |
* `MysqlDateTimeWithTimeZone` inherits from `ActiveRecord::Type::DateTime`
(`MysqlDateTime` is not present in Rails 5)
* explicitly set `NULL` default value for `merge_request_diff_files`'s
`diff` column (otherwise empty string is used in a migration) and
empty string is not allowed for text/blob fields in Mysql
* disable NO_ZERO_DATE mode for all Mysql DB connections, otherwise
SQL queries fail on inserting `0` value for `created_at` column
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original MR [1] fixed red specs for Rails 5.
But while the failed specs were fixed, that changes brought new failed
specs which weren't caught up in [1].
This commit just fixes the fix. :)
New errors are like these:
```
Failed to upgrade to WebSocket (REQUEST_METHOD: GET, HTTP_CONNECTION: keep-alive, HTTP_UPGRADE: )
Finished "/-/boards/1/lists"[non-WebSocket] for 127.0.0.1 at 2018-06-20 18:09:26 +0200
```
[1]: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20015
|