summaryrefslogtreecommitdiff
path: root/danger/database
Commit message (Collapse)AuthorAgeFilesLines
* Document database review processToon Claes2019-07-191-18/+24
| | | | See https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/6069
* DRY up conditions for files require DB reviewToon Claes2019-07-041-31/+1
| | | | | | | | Stop using two separate lists for the conditions which files require a database review. Related discussion: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30156#note_187732053
* Backport the EE schema and migrations to CEYorick Peterse2019-06-171-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This backports all EE schema changes to CE, including EE migrations, ensuring both use the same schema. == Updated tests A spec related to ghost and support bot users had to be modified to make it pass. The spec in question assumes that the "support_bot" column exists when defining the spec. In the single codebase setup this is not the case, as the column is backported in a later migration. Any attempt to use a different schema version or use of "around" blocks to conditionally disable specs won't help, as reverting the backport migration would also drop the "support_bot" column. Removing the "support_bot" tests entirely appears to be the only solution. We also need to update some foreign key tests now that we have backported the EE columns. Fortunately, these changes are very minor. == Backporting migrations This commit moves EE specific migrations (except those for the Geo tracking database) and related files to CE, and also removes any traces of the ee/db directory. Some migrations had to be modified or removed, as they no longer work with the schema being backported. These migrations were all quite old, so we opted for removing them where modifying them would take too much time and effort. Some old migrations were modified in EE, while also existing in CE. In these cases we took the EE code, and in one case removed them entirely. It's not worth spending time trying to merge these changes somehow as we plan to remove old migrations around the release of 12.0, see https://gitlab.com/gitlab-org/gitlab-ce/issues/59177 for more details.
* Create helper to get all changed filesleipert-danger-fix-moved-filesLukas Eipert2018-10-221-3/+1
| | | | | | | | | | | | | | | | Danger apparently has three different objects which could contain files you often want to check: - git.added_files - git.modified_files - git.renamed_files The problem: If a file is renamed, `modified_files` contains the file path before the rename. In some Danger checks we use `added_files` + `modified_files`, which might contain the deleted paths of renamed files, but missing the new paths of renamed files. So we need to consider `renamed_files` as well.
* Fix regexp for detected `db/schema.rb` and `ee/db/geo/schema.rb`Thong Kuah2018-07-261-2/+2
|
* Autocorrect RuboCop violations in danger/**/DangerfileRobert Speicher2018-07-111-1/+0
|
* Wrap DB paths in backticks in the Danger checkRémy Coutable2018-07-111-1/+1
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Fix "Database Team" typo for DangerYorick Peterse2018-07-111-1/+1
|
* Tweak the Danger settings for DB changesYorick Peterse2018-07-111-8/+61
| | | | | | Instead of only checking for migrations, we now check for a variety of files and directories that require a database review. We also include some steps on how to make sure changes are reviewed.
* Improve Danger files after first reviewRémy Coutable2018-07-111-13/+28
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Start to use Danger for automating MR reviewsRémy Coutable2018-07-111-0/+16
Signed-off-by: Rémy Coutable <remy@rymai.me>
View Lorry Controller Status