summaryrefslogtreecommitdiff
path: root/danger
Commit message (Collapse)AuthorAgeFilesLines
* Danger check for ignored eslint rulesleipert-frontend-dangerLukas Eipert2018-09-291-0/+29
| | | | | | We disabled a lot of eslint rules on a per-file basis. This checks touched files for those and reminds you to re-enable the rules and fix them.
* Danger check for unprettified JavaScriptLukas Eipert2018-09-281-0/+39
| | | | | This adds a Dangerfile which executes `prettier` to find out if someone touched Frontend files and forgot to run it on their current branch.
* Relax the subject line requirements for commitsYorick Peterse2018-09-191-2/+14
| | | | | | | | | This changes the hard limit of 50 to a soft limit of 50, with the new hard limit being 72 characters. This gives people a bit more space, while still (hopefully) guiding them towards subject lines that are roughly 50 characters long. Fixes https://gitlab.com/gitlab-org/release/framework/issues/16
* Improve Emoji detection in commit messagesYorick Peterse2018-09-181-1/+28
| | | | | | | | | | | | | | | | | | | This changes our Danger integration so that it is smarter about detecting GitLab emoji in commit messages. This is done using a two step process: 1. We use the old regular expression to determine if a commit message _might_ include an emoji. 2. If this regular expression matches, we then check for all existing emoji names in the commit message. This might be a wee bit expensive, but because we couple it with the previous step it should be rarely executed. This ensures we don't trigger an error when a commit message includes text such as `:foo:bar:`, which is not a valid Emoji. Fixes https://gitlab.com/gitlab-org/release/framework/issues/15
* Merge branch 'danger-commit-count' into 'master'Robert Speicher2018-09-141-2/+7
|\ | | | | | | | | | | | | Relax Danger requirements about changed lines Closes gitlab-org/release/framework#13 See merge request gitlab-org/gitlab-ce!21739
| * Relax Danger requirements about changed linesYorick Peterse2018-09-141-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This relaxes the commit rules regarding the number of changed lines. Previously we required a detailed description if 20 or more lines were changed. Starting with this commit we change the rules so Danger only notifies you about writing a detailed description if: 1. A commit changes more than 3 files 2. The same commit changes more than 30 lines This should make it easier to do a find replace to fix a typo, without having to repeat what the subject line already says, while still reminding developers to write a detailed description for new features and other larger changes. Fixes https://gitlab.com/gitlab-org/release/framework/issues/13
* | Fix typo in Danger messageLukas Eipert2018-09-141-1/+1
|/
* Added Danger file to lint commit messagesYorick Peterse2018-09-101-0/+192
| | | | | | | | | | | | | | | | This Dangerfile ensures that commit authors write good commit messages. We also prevent the use of Emoji, since these add no value and may not always be displayed properly. Merge commits are currently ignored. In the future we most likely want to stop using these, but this is a separate discussion, hence we ignore them for the time being. The rules enforced by this Dangerfile are based on the article found at https://chris.beams.io/posts/git-commit/. For more information, refer to https://gitlab.com/gitlab-org/gitlab-ce/issues/50003. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/50003
* Merge branch 'docs/dangerfile' into 'master'Mike Lewis2018-09-071-0/+37
|\ | | | | | | | | Add Documentation Dangerfile See merge request gitlab-org/gitlab-ce!21395
| * Add Documentation DangerfileAchilleas Pipinellis2018-09-061-0/+37
| | | | | | | | | | Every time a doc change is made, a comment to ping the @gl-docsteam is added.
* | Fix wording in Danger warning about MRs to non-masterSean McGivern2018-09-041-1/+1
|/ | | | If it's most of the time, then it's not all.
* Drop WIP from changelog command in Danger commentWinnie Hellmann2018-08-241-2/+4
|
* Merge branch '49631-fix-dangerfile-schema-rb' into 'master'Rémy Coutable2018-07-261-2/+2
|\ | | | | | | | | | | | | Resolve "Dangerfile reporting that db/schema.rb wasn't updated" Closes #49631 See merge request gitlab-org/gitlab-ce!20852
| * Fix regexp for detected `db/schema.rb` and `ee/db/geo/schema.rb`Thong Kuah2018-07-261-2/+2
| |
* | Make the frozen_string Danger check more resilientRobert Speicher2018-07-251-6/+5
|/ | | | | | | It's possible for a Ruby file to be empty and thus `gets` returns `nil`. Also indents the Markdown since we're using `<<~` and removes an unneeded variable.
* Add Dangerfile for frozen_string_literalgfyoung2018-07-241-0/+27
| | | | | | | Checks that new Ruby files will enable frozen string literal. Partially addresses #47424.
* Improve danger/specs/Dangerfile by not requiring new specs if specific ↵move-danger-to-test-stageRémy Coutable2018-07-171-4/+10
| | | | | | labels are applied Signed-off-by: Rémy Coutable <remy@rymai.me>
* Improve danger/changelog/Dangerfile to include the title in the ↵Rémy Coutable2018-07-171-7/+7
| | | | | | bin/changelog command Signed-off-by: Rémy Coutable <remy@rymai.me>
* Use the correct exceptions to look for invalid YAML in Changelogsfix-dangerGabriel Mazetto2018-07-131-2/+4
|
* Fix DangerfileStan Hu2018-07-121-1/+1
|
* Autocorrect RuboCop violations in danger/**/DangerfileRobert Speicher2018-07-115-12/+5
|
* Wrap DB paths in backticks in the Danger checkRémy Coutable2018-07-111-1/+1
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Fix "Database Team" typo for DangerYorick Peterse2018-07-111-1/+1
|
* Tweak the Danger settings for DB changesYorick Peterse2018-07-111-8/+61
| | | | | | Instead of only checking for migrations, we now check for a variety of files and directories that require a database review. We also include some steps on how to make sure changes are reviewed.
* Improve Danger files after first reviewRémy Coutable2018-07-116-47/+111
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Start to use Danger for automating MR reviewsRémy Coutable2018-07-116-0/+117
Signed-off-by: Rémy Coutable <remy@rymai.me>
View Lorry Controller Status