summaryrefslogtreecommitdiff
path: root/doc/development/code_review.md
Commit message (Expand)AuthorAgeFilesLines
* Includes the way approvals are handled to the documentationDimitrie Hoekstra2018-11-061-0/+6
* Strongly recommend involving a domain expert, especially when in doubt.Douwe Maan2018-10-171-4/+8
* Merge branch 'master' into 'dm-document-role-maintainer'Douwe Maan2018-10-161-0/+14
|\
| * Fix "ready for review" linkJan Provaznik2018-10-161-1/+1
| * Add documentation how to assign a merge request for reviewJarka Kadlecová2018-10-151-1/+15
* | Clarify responsibilities of MR author and maintainer based on feedback.Douwe Maan2018-10-161-40/+51
* | Rewrite guidance on getting your merge request reviewed, approved, and mergedDouwe Maan2018-10-101-36/+32
* | Document the role of the maintainerDouwe Maan2018-10-091-16/+53
|/
* Update code_review.md to include a recommendation for assigning maintainers f...Luke Bennett2018-09-121-2/+3
* Resolve "CE documentation is not CommonMark compliant"Brett Walker2018-09-061-49/+49
* Fixed broken link to build team in documentationEddie Stubbington2018-05-301-1/+1
* Add Code Review documentation that maintainers also perform code reviewdocs/rs-code-reviewRobert Speicher2018-05-111-0/+4
* Move footnote from CONTRIBUTING.md to doc/development/code_review.mdRobert Speicher2018-05-111-0/+1
* Merge branch 'master' into 'docs-specific-review-examples'docs-specific-review-examplesClement Ho2017-08-011-0/+3
|\
| * Add code review guidelines related to Build [CI skip].Marin Jankovski2017-08-011-0/+3
* | Add note about UX paradigmClement Ho2017-07-311-0/+2
* | Add specific code review guidelinesadd-specific-review-examplesClement Ho2017-07-311-0/+8
|/
* Add GitLab-specific concerns to code review guideSean McGivern2017-07-241-0/+49
* Fix links in code review docsSean McGivern2017-05-091-5/+10
* Improving copy of CONTRIBUTING.md, PROCESS.md, and code_review.mddocs/30141-improve-contributing-guideRémy Coutable2017-05-041-3/+0
* Improve the Code review guidelines documentationRémy Coutable2017-05-031-5/+39
* Rename builds to jobs in docsAchilleas Pipinellis2017-02-151-1/+1
* Rename endboss -> maintainer, miniboss -> reviewerno-more-bossesSean McGivern2017-01-131-6/+6
* Merge branch 'fix/rename-mwbs-to-merge-when-pipeline-succeeds' into 'master' Kamil Trzciński2016-12-051-2/+2
|\
| * Update some docs to reflect MWPS name changeGrzegorz Bizon2016-11-211-2/+2
* | Remove change to MWBS in code review guidelineGrzegorz Bizon2016-12-021-1/+1
* | Copy-edit text about right balance in code reviewsdoc/extend-code-review-guidelinesGrzegorz Bizon2016-12-011-10/+10
* | Extend code review docs with chapter about the right balanceGrzegorz Bizon2016-11-301-1/+27
|/
* Fix typo and add he MWBS accronym for "Merge When Build Succeeds"improve-contributingRémy Coutable2016-10-071-4/+4
* Improve the contribution and MR review guideRémy Coutable2016-10-071-0/+7
* Re-add a note about sarcasm to the Code Review guiders-code-review-guideRobert Speicher2016-04-101-0/+3
* First pass at a Code Review guideRobert Speicher2016-04-091-0/+75
View Lorry Controller Status