summaryrefslogtreecommitdiff
path: root/features/support
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'rs-capybara-screenshot-artifacts' into 'master' Kamil Trzciński2017-03-141-6/+3
|\ | | | | | | | | | | | | Store capybara screenshots as build artifacts Closes #13971 See merge request !7985
| * Don't disable capybara-screenshot in CI environmentrs-capybara-screenshot-artifactsRobert Speicher2016-12-081-6/+3
| |
* | Decrease Capybara timeout for CI environmentrs-lower-capybara-timeoutRobert Speicher2017-03-081-1/+1
| |
* | Fix race conditions for AuthorizedProjectsWorkerrefresh-authorizations-fork-joinYorick Peterse2017-01-251-2/+1
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were two cases that could be problematic: 1. Because sometimes AuthorizedProjectsWorker would be scheduled in a transaction it was possible for a job to run/complete before a COMMIT; resulting in it either producing an error, or producing no new data. 2. When scheduling jobs the code would not wait until completion. This could lead to a user creating a project and then immediately trying to push to it. Usually this will work fine, but given enough load it might take a few seconds before a user has access. The first one is problematic, the second one is mostly just annoying (but annoying enough to warrant a solution). This commit changes two things to deal with this: 1. Sidekiq scheduling now takes places after a COMMIT, this is ensured by scheduling using Rails' after_commit hook instead of doing so in an arbitrary method. 2. When scheduling jobs the calling thread now waits for all jobs to complete. Solution 2 requires tracking of job completions. Sidekiq provides a way to find a job by its ID, but this involves scanning over the entire queue; something that is very in-efficient for large queues. As such a more efficient solution is necessary. There are two main Gems that can do this in a more efficient manner: * sidekiq-status * sidekiq_status No, this is not a joke. Both Gems do a similar thing (but slightly different), and the only difference in their name is a dash vs an underscore. Both Gems however provide far more than just checking if a job has been completed, and both have their problems. sidekiq-status does not appear to be actively maintained, with the last release being in 2015. It also has some issues during testing as API calls are not stubbed in any way. sidekiq_status on the other hand does not appear to be very popular, and introduces a similar amount of code. Because of this I opted to write a simple home grown solution. After all, all we need is storing a job ID somewhere so we can efficiently look it up; we don't need extra web UIs (as provided by sidekiq-status) or complex APIs to update progress, etc. This is where Gitlab::SidekiqStatus comes in handy. This namespace contains some code used for tracking, removing, and looking up job IDs; all without having to scan over an entire queue. Data is removed explicitly, but also expires automatically just in case. Using this API we can now schedule jobs in a fork-join like manner: we schedule the jobs in Sidekiq, process them in parallel, then wait for completion. By using Sidekiq we can leverage all the benefits such as being able to scale across multiple cores and hosts, retrying failed jobs, etc. The one downside is that we need to make sure we can deal with unexpected increases in job processing timings. To deal with this the class Gitlab::JobWaiter (used for waiting for jobs to complete) will only wait a number of seconds (30 by default). Once this timeout is reached it will simply return. For GitLab.com almost all AuthorizedProjectWorker jobs complete in seconds, only very rarely do we spike to job timings of around a minute. These in turn seem to be the result of external factors (e.g. deploys), in which case a user is most likely not able to use the system anyway. In short, this new solution should ensure that jobs are processed properly and that in almost all cases a user has access to their resources whenever they need to have access.
* Pass `--load-images=no` to PhantomJS via Capybara/Poltergeistrs-phantomjs-disable-imagesRobert Speicher2016-11-281-1/+9
| | | | | | We were unintentionally hitting `gravatar.com` whenever a test that used Poltergeist was run. This was certainly wasting their resources and slowing down our tests even further, for no reason.
* Disable warming of the asset cache in Spinach tests under CIStan Hu2016-10-211-1/+1
| | | | | | | | | | | | I suspect some combination of Knapsack tests cause no regular Rack tests to be loaded (i.e. all JavaScript tests), which leads to the error: ArgumentError: rack-test requires a rack application, but none was given In CI, we precompile all the assets so there is no need to warm the asset cache in any case. Closes #23613
* Wait for ajax for every merge request spinach testdz-spinach-wait-ajaxDmitriy Zaporozhets2016-10-182-12/+1
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Try to fix re-runcs-really-fix-spinachKamil Trzcinski2016-10-141-0/+2
|
* Remove spinach retry.Connor Shea2016-10-141-1/+1
|
* Updated failing testsPhil Hughes2016-08-131-0/+11
|
* Introduce SimpleCovEnv singleton helper and use itGrzegorz Bizon2016-07-211-2/+2
|
* Fix spinach testsKamil Trzcinski2016-07-211-1/+1
|
* Update configuration of SimpleCovKamil Trzcinski2016-07-211-0/+1
|
* Store all simplecov configuration in one fileKamil Trzcinski2016-07-211-11/+1
|
* Add simplecov to spinach testsKamil Trzcinski2016-07-211-0/+8
|
* Fix Knapsack report generation for Spinachfix-knapsack-for-spinachKamil Trzcinski2016-07-131-1/+1
|
* Remove coveralls linescleanup-forgotten-linesZ.J. van de Weg2016-06-301-5/+0
|
* Enable Knapsack only in CI environmentknapsack-env-ciKamil Trzcinski2016-06-081-2/+4
|
* Use knapsack everywhereKamil Trzcinski2016-06-031-1/+1
|
* Use own version of knapsack which supports spinach testsKamil Trzcinski2016-06-031-1/+3
|
* WIPKamil Trzcinski2016-06-031-2/+0
|
* Try to use knapsackKamil Trzcinski2016-06-031-0/+3
|
* Fix Capybara 2.6.2 deprecation warningsStan Hu2016-03-151-1/+1
|
* Retry spinach testsKamil Trzcinski2016-03-092-0/+15
|
* Set window_size to 1366*768Alfredo Sumaran2016-02-231-1/+1
|
* Prevent transient Capybara timeouts during feature testsrs-transient-capybara-timeoutRobert Speicher2016-01-281-4/+4
| | | | | | | | | | | The problem occurred because asset compilation takes a long time, so when the asset cache didn't exist and the first test ran, it would often (randomly) time out during the generation before the actual test even had a chance to run. Now we check if the cache exists before the suite runs, and if not, we manually fire a request to the root URL in order to generate it. This should allow subsequent tests to use the cached assets.
* Add spinach test for note pollingGrzegorz Bizon2015-12-151-1/+1
| | | | | This also increases capybara timeout to 15 seconds (note polling interval). Capybara will look for new note for this period of time.
* Fix tests for web editorDmitriy Zaporozhets2015-08-141-0/+4
|
* Started on the actual rspec 3 upgradeJeroen van Baarsen2015-06-221-0/+1
| | | | Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
* Remove unnecessary require from Spinach envRobert Speicher2015-06-041-1/+0
|
* Don't use capybara-screenshot in CI environmentsrs-capybara-screenshotRobert Speicher2015-04-251-3/+5
|
* Enable js_errors for Capybara in Spinach and RSpecRobert Speicher2015-04-251-1/+1
|
* Reduce timeout for non-CI featuresRobert Speicher2015-04-251-2/+5
|
* Move Spinach setup for db_cleaner and capybara to their own filesRobert Speicher2015-04-253-26/+34
| | | | | Also adds capybara-screenshot, which will automatically save the page as html and an image whenever a feature fails. Handy for debugging.
* Fixed tests for spinachJeroen van Baarsen2015-02-121-1/+1
| | | | Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
* Try wear_merged! without argumentDmitriy Zaporozhets2014-10-011-1/+1
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Refactor coverage tools usageDmitriy Zaporozhets2014-09-191-5/+5
| | | | | | | | rspec spec # no coverage generated SIMPLECOV=true rspec spec # generate coverage locally into ./coverage COVERALLS=true rspec spec # generate and send coverage data to coveralls.io Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Ask coveralls to merge resultsDmitriy Zaporozhets2014-09-191-1/+1
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Recreate tmp/tests on each test runDmitriy Zaporozhets2014-07-311-1/+1
|
* Move all test repos data to ReposHelpersDmitriy Zaporozhets2014-07-311-1/+1
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Dont stub gitlab-shell calls. Make test environment closer to real oneDmitriy Zaporozhets2014-07-311-1/+0
|
* Revert "Revert "Fix for failing specs""Dmitriy Zaporozhets2014-06-061-1/+1
| | | | This reverts commit 2545b0f85851d1e4ebc1137a2c8786a238e02ee4.
* Revert "Fix for failing specs"Jeroen van Baarsen2014-06-051-1/+1
| | | | | | | | | This reverts commit 2314438925af827b694fbaaf59c31c49dd2c0c31. Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com> Conflicts: Gemfile.lock
* Fix for failing specsJeroen van Baarsen2014-05-301-1/+1
|
* Fix MR fork validation and services loadDmitriy Zaporozhets2014-04-031-2/+0
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Add email aliases for usersJason Hollingsworth2014-02-131-1/+1
| | | | | | | | Emails are used to associate commits with users. The emails are not verified and don't have to be valid email addresses. They are assigned on a first come, first serve basis. Notifications are sent when an email is added.
* Remove chosen from testsDmitriy Zaporozhets2014-01-111-1/+1
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Require rspec expectations into spinachDmitriy Zaporozhets2013-12-101-0/+1
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Fixing unsafe use of Thread.current variable :current_userAngus MacArthur2013-10-161-0/+2
|
* Improve timing problem in spinach testHiroyuki Sato2013-09-131-1/+4
|
View Lorry Controller Status