summaryrefslogtreecommitdiff
path: root/features
Commit message (Collapse)AuthorAgeFilesLines
* exclude spec/ and features/ from `Style/PredicateName` copMaxim Rydkin2017-08-292-11/+11
|
* replace `is_member_of` with `member_of?`Maxim Rydkin2017-08-291-7/+7
|
* replace `has_n_stars` with `has_n_stars?`Maxim Rydkin2017-08-291-4/+4
|
* Merge branch 'replace_spinach_search_code.feature' into 'master'Robert Speicher2017-08-253-38/+0
|\ | | | | | | | | Replace 'source/search_code.feature' spinach test with an rspec analog See merge request !13697
| * Replace 'source/search_code.feature' spinach test with an rspec analogblackst0ne2017-08-253-38/+0
| |
* | Merge branch 'zj-reword-job-to-pipeline-chart-view' into 'master'Douwe Maan2017-08-251-3/+3
|\ \ | | | | | | | | | | | | | | | | | | Reword job to pipeline on the chart view Closes #36928 See merge request !13786
| * | Reword job to pipeline on the chart viewZeger-Jan van de Weg2017-08-241-3/+3
| |/ | | | | | | | | | | This got changed for i18n in !12480, however, I forgot to understand that the meaning of the graphs changed in !12378. This corrects the behaviour.
* | Fix feature specs for pages deploymentbackstage/gb/after-save-asynchronous-job-hooksGrzegorz Bizon2017-08-231-1/+5
|/
* Enable Layout/TrailingWhitespace cop and auto-correct offensesRobert Speicher2017-08-151-1/+1
|
* Merge branch ↵Clement Ho2017-08-142-8/+2
|\ | | | | | | | | | | | | | | | | '34527-make-edit-comment-button-always-available-outside-of-dropdown' into 'master' Resolve "Make edit comment button always available outside of dropdown" Closes #34527 See merge request !12931
| * take edit note button out of dropdown34527-make-edit-comment-button-always-available-outside-of-dropdownSimon Knox2017-08-102-8/+2
| |
* | Migrate events into a new formatYorick Peterse2017-08-101-22/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit migrates events data in such a way that push events are stored much more efficiently. This is done by creating a shadow table called "events_for_migration", and a table called "push_event_payloads" which is used for storing push data of push events. The background migration in this commit will copy events from the "events" table into the "events_for_migration" table, push events in will also have a row created in "push_event_payloads". This approach allows us to reclaim space in the next release by simply swapping the "events" and "events_for_migration" tables, then dropping the old events (now "events_for_migration") table. The new table structure is also optimised for storage space, and does not include the unused "title" column nor the "data" column (since this data is moved to "push_event_payloads"). == Newly Created Events Newly created events are inserted into both "events" and "events_for_migration", both using the exact same primary key value. The table "push_event_payloads" in turn has a foreign key to the _shadow_ table. This removes the need for recreating and validating the foreign key after swapping the tables. Since the shadow table also has a foreign key to "projects.id" we also don't have to worry about orphaned rows. This approach however does require some additional storage as we're duplicating a portion of the events data for at least 1 release. The exact amount is hard to estimate, but for GitLab.com this is expected to be between 10 and 20 GB at most. The background migration in this commit deliberately does _not_ update the "events" table as doing so would put a lot of pressure on PostgreSQL's auto vacuuming system. == Supporting Both Old And New Events Application code has also been adjusted to support push events using both the old and new data formats. This is done by creating a PushEvent class which extends the regular Event class. Using Rails' Single Table Inheritance system we can ensure the right class is used for the right data, which in this case is based on the value of `events.action`. To support displaying old and new data at the same time the PushEvent class re-defines a few methods of the Event class, falling back to their original implementations for push events in the old format. Once all existing events have been migrated the various push event related methods can be removed from the Event model, and the calls to `super` can be removed from the methods in the PushEvent model. The UI and event atom feed have also been slightly changed to better handle this new setup, fortunately only a few changes were necessary to make this work. == API Changes The API only displays push data of events in the new format. Supporting both formats in the API is a bit more difficult compared to the UI. Since the old push data was not really well documented (apart from one example that used an incorrect "action" nmae) I decided that supporting both was not worth the effort, especially since events will be migrated in a few days _and_ new events are created in the correct format.
* | Merge branch 'wiki_title' into 'master'Robert Speicher2017-08-071-1/+1
|\ \ | |/ |/| | | | | | | | | add feature rename wiki title Closes #27800 See merge request !10069
| * Allow wiki pages to be renamed in the UIwendy04022017-08-031-1/+1
| |
* | Merge branch '34060-simplified-general-project-settings' into 'master'Mike Greiling2017-08-042-5/+13
|\ \ | | | | | | | | | | | | | | | | | | 34060 Simply general project settings to use expanded panels Closes #34060 See merge request !12620
| * | fixed up specsPhil Hughes2017-07-282-5/+13
| | |
* | | Change all `:empty_project` to `:project`rs-empty_project-defaultRobert Speicher2017-08-028-14/+14
| | |
* | | Use `:empty_project` where possible in features/stepsRobert Speicher2017-08-022-2/+2
| |/ |/|
* | Rename many path_with_namespace -> full_pathGabriel Mazetto2017-08-013-9/+9
|/
* Merge branch '1827-prevent-concurrent-editing-wiki' into 'master'Robert Speicher2017-07-271-1/+1
|\ | | | | | | | | | | | | Prevent concurrent editing wiki Closes #1827 See merge request !9707
| * Fix error of spinach testHiroyuki Sato2017-07-231-1/+1
| |
* | Remove project_key from the Jira configurationJarka Kadlecova2017-07-251-1/+0
| |
* | Resolve "Lazy load images on the Frontend"Tim Zallmann2017-07-241-1/+1
|/
* Port spinach tests to rspec feature specszj-pipeline-badge-improvementsZ.J. van de Weg2017-07-212-59/+0
| | | | | | | Logic is the same, just now ported, while this feature was being improved anyway in this branch. Resolves #20961
* Reword success to passing for pipeline badgesZ.J. van de Weg2017-07-211-1/+1
|
* Rename build to pipeline for status badgesZ.J. van de Weg2017-07-211-1/+1
| | | | | | | | | | | | | | First commit in probably 2, for resolve gitlab-org/gitlab-ce#15582. This commit is renaming files and classes from build to pipeline. Also wording is editted to pipeline. Given `pipeline` had more characters than `build`, I've made the field a bit wider. The width now matchers the one for the coverage badge, so they look nice when in a table format, or in a list. As soon as this commit is merged to master, and released, the build.svg is deprecated, meaning that all users which already placed a badge should update it. However, to make sure it keeps working tests are added for this case.
* Merge branch '23036-replace-dashboard-activity-spinach' into 'master'Rémy Coutable2017-07-192-150/+0
|\ | | | | | | | | Replaces 'dashboard/event_filters.feature' spinach with rspec See merge request !12651
| * Replaces 'dashboard/activity.feature' spinach with rspecAlexander Randa2017-07-172-150/+0
| |
* | Merge branch '23036-replace-dashboard-spinach' into 'master'Rémy Coutable2017-07-193-158/+0
|\ \ | | | | | | | | | | | | Replaces dashboard/dashboard.feature spinach with rspec See merge request !12876
| * | Replaces dashboard/dashboard.feature spinach with rspecAlexander Randa2017-07-173-158/+0
| | |
* | | Update specs for new upload pathBob Van Landuyt2017-07-183-3/+3
|/ /
* | Replace 'browse_files.feature' spinach test with an rspec analogblackst0ne2017-07-121-323/+0
|/
* Native group milestonesFelipe Artur2017-07-072-9/+4
|
* Resolve "Inconsistent location of members page between groups and projects"Tim Zallmann2017-07-072-6/+9
|
* Merge branch '32408-allow-creation-of-files-and-dirs-with-spaces-in-web-ui' ↵Douwe Maan2017-07-052-14/+0
|\ | | | | | | | | | | | | | | | | into 'master' Make filename and path creation compatible with UNIX in web UI Closes #21362 See merge request !12608
| * Removes file_name_regex from Gitlab::Regex32408-allow-creation-of-files-and-dirs-with-spaces-in-web-uiTiago Botelho2017-07-052-14/+0
| |
| * Allow creation of files and directories with spaces in web UITiago Botelho2017-07-051-1/+1
| |
* | Create and use project path helpers that only need a project, no namespaceDouwe Maan2017-07-0533-161/+160
| |
* | Merge branch '23036-replace-snippets-spinach' into 'master'Rémy Coutable2017-07-054-193/+0
|\ \ | | | | | | | | | | | | Replace 'snippets/snippets.feature' spinach with rspec See merge request !12385
| * | Replace 'snippets/snippets.feature' spinach with rspecAlexander Randa2017-07-054-193/+0
| | |
* | | Merge branch '23036-replace-dashboard-new-project-spinach' into 'master'Rémy Coutable2017-07-033-104/+0
|\ \ \ | |_|/ |/| | | | | | | | Replaces 'dashboard/new-project.feature' spinach with rspec See merge request !12550
| * | Replaces 'dashboard/new-project.feature' spinach with rspecAlexander Randa2017-06-293-104/+0
| | |
* | | Merge branch 'inject-add-diff-note' into 'master'Phil Hughes2017-06-301-1/+1
|\ \ \ | | | | | | | | | | | | | | | | Render add-diff-note with server and optimize styles See merge request !12103
| * | | Render add-diff-note button with server.Bryce Johnson2017-06-291-1/+1
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit moves the rendering of the button back to the server, and shows/hides it using opacity rather than display. It also removes the transform applied to the button on hover (scale). Previously, both of these factors automatically triggered a reflow, which creates a performance bottleneck on pages with larger DOM size. MR: !12103
* | | Clean up issuable listsTaurie Davis2017-06-291-1/+1
|/ /
* | Merge branch 'dm-merge-request-creations-controller' into 'master'Sean McGivern2017-06-292-3/+3
|\ \ | | | | | | | | | | | | Split up MergeRequestsController See merge request !12150
| * | Split up MergeRequestsControllerdm-merge-request-creations-controllerDouwe Maan2017-06-282-3/+3
| | |
* | | Merge branch 'dz-refactor-group-members-tests' into 'master'Douwe Maan2017-06-271-59/+0
|\ \ \ | |/ / |/| | | | | | | | Refactor group members tests See merge request !12465
| * | Move another group member spec from spinachdz-refactor-group-members-testsDmitriy Zaporozhets2017-06-261-7/+0
| | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
| * | Move "remove group member" spec from spinach to rspecDmitriy Zaporozhets2017-06-261-12/+0
| | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>