summaryrefslogtreecommitdiff
path: root/lib/gitlab/ci
Commit message (Collapse)AuthorAgeFilesLines
* Memoize CI config node validator to prevent leaksfix/improve-ci-node-validatable-to-prevent-memory-leakGrzegorz Bizon2016-08-091-6/+4
|
* Merge branch 'rubocop/enable-access-modifiers-cops' into 'master' Robert Speicher2016-07-291-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Enable Rubocop cops that check access modifiers ## What does this MR do? This MR enables Rubocop cops that detect methods that should be restricted but are the part of public API because of access modifiers used improperly. This also fixes existing offenses. ## Why was this MR needed? Some method in our codebase are public instead of being private because it is sometimes difficult to get it right without static analysis. ## What are the relevant issue numbers? See #17478 Closes #17372 See merge request !5014
| * Enable Rubocop cops for invalid access modifiersrubocop/enable-access-modifiers-copsGrzegorz Bizon2016-07-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This enables following cops: Check for useless access modifiers Lint/UselessAccessModifier Checks for attempts to use `private` or `protected` to set the visibility of a class method, which does not work. Lint/IneffectiveAccessModifier This also disables two false possitives in concerns.
* | Improve code, remove unused validator, improve namesGrzegorz Bizon2016-07-299-33/+19
| |
* | Move job dependencies entry to the new CI configGrzegorz Bizon2016-07-201-1/+3
| |
* | Add minor readability, style improvements in CI configGrzegorz Bizon2016-07-206-16/+18
| |
* | Merge branch 'master' into refactor/ci-config-move-job-entriesGrzegorz Bizon2016-07-201-3/+3
|\ \ | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (321 commits) Fix the Sentry spam from CSP violations by disabling it. Limit git rev-list output count to one in forced push check Ensure Owners are included in the scope for authorized_projects Fix alignment of icons on project page Fix ci_status_helper_spec to look for new SVGs use 2.0.5, actually (2.0.4 was a bad release) upgrade rouge to 2.0.4 Fix help page paths to make sure shortcuts and the UI help page work. fixes an issue cause by a bad merge Vertically align status icon within table Add new icons for every CI status Add global style for running icon Align running icon in merge request Add new running icon; add a bunch of styles to get svg to match existing fa icons Improve code design Fix broken builds_for_ref Move when tests before to make it no conflict with manual-actions Use value of `yaml_variables` and `when` from config_processor if undefined Add CHANGELOG entry CHANGELOG item ... Conflicts: lib/ci/gitlab_ci_yaml_processor.rb spec/lib/ci/gitlab_ci_yaml_processor_spec.rb
* | Move job environment validation to new CI configGrzegorz Bizon2016-07-193-6/+15
| |
* | Move tags and allow_failure CI entries to new configGrzegorz Bizon2016-07-181-0/+8
| |
* | Validate allowed keys only in new CI configGrzegorz Bizon2016-07-181-0/+5
| |
* | Improve valid keys validation for CI config nodesGrzegorz Bizon2016-07-184-15/+12
| |
* | Move job artifacts configuration new CI config codeGrzegorz Bizon2016-07-184-1/+71
| |
* | Move job variables config entry to new CI configGrzegorz Bizon2016-07-181-1/+5
| |
* | Move except and only job nodes to new CI configGrzegorz Bizon2016-07-182-1/+35
| |
* | Move job image and services nodes to new CI configGrzegorz Bizon2016-07-181-1/+10
| |
* | Simplify abstract class for CI config entry nodesGrzegorz Bizon2016-07-154-39/+23
| |
* | Simplify CI config and remove logical validationGrzegorz Bizon2016-07-154-29/+10
| |
* | Add metadata to new CI config and expose job nameGrzegorz Bizon2016-07-156-30/+24
| |
* | Remove job cache configfrom legacy yaml processorGrzegorz Bizon2016-07-141-1/+5
| |
* | Remove references to global entry in new CI configGrzegorz Bizon2016-07-142-2/+1
| |
* | Revert logical validation in CI job stage entryGrzegorz Bizon2016-07-142-17/+0
| |
* | Revert references to global node in CI job entryGrzegorz Bizon2016-07-141-16/+4
| |
* | Improve CI job entry validations in new configGrzegorz Bizon2016-07-144-17/+31
| |
* | Expose CI job commands and use in legacy processorGrzegorz Bizon2016-07-131-7/+8
| |
* | Add before script and commands to CI job entryGrzegorz Bizon2016-07-131-2/+13
| |
* | Fabricate CI entry with value, set attributes laterGrzegorz Bizon2016-07-131-8/+20
| |
* | Improve CI stage configuration entry validationsGrzegorz Bizon2016-07-132-8/+10
| |
* | Do not raise when getting value of invalid CI nodeGrzegorz Bizon2016-07-121-1/+1
| |
* | Fix using `try` on delegators in CI config entriesGrzegorz Bizon2016-07-121-2/+2
| | | | | | | | | | | | See: https://github.com/rails/rails/commit/af53280a4b5b3323ac87dc60deb2b1b781197b2b
* | Simplify undefined node definition in CI configGrzegorz Bizon2016-07-125-61/+28
| |
* | Add CI config node that is unspecified null entryGrzegorz Bizon2016-07-121-0/+30
| |
* | Prevalidate CI entries recursively on processedGrzegorz Bizon2016-07-121-3/+2
| |
* | Require parent when using node factory in CI configGrzegorz Bizon2016-07-104-13/+24
| |
* | Rename CI config job script entry node to commandsGrzegorz Bizon2016-07-102-3/+7
| |
* | Move after script CI job confg to new processorGrzegorz Bizon2016-07-101-2/+6
| |
* | Add CI job script node in new config processorGrzegorz Bizon2016-07-102-3/+38
| |
* | Add before_script node to CI job entry configGrzegorz Bizon2016-07-101-2/+16
| |
* | Extend CI job entries fabrication and validationGrzegorz Bizon2016-07-094-8/+16
| |
* | Add comment for deprecated CI config `types` entryGrzegorz Bizon2016-07-091-2/+9
| |
* | Use node factory to assemble global CI config entryGrzegorz Bizon2016-07-092-15/+23
| |
* | Integrate CI job stage entry into CI configurationGrzegorz Bizon2016-07-093-8/+38
| |
* | Improve name of CI entry validation context hookGrzegorz Bizon2016-07-083-3/+3
| |
* | Add CI config known stage validation for job stageGrzegorz Bizon2016-07-081-0/+13
| |
* | Extract CI entry node validator and improve namingGrzegorz Bizon2016-07-084-24/+25
| |
* | Extract global CI config entry configuration setupGrzegorz Bizon2016-07-081-9/+12
| |
* | Extract internal attributes validator for CI entryGrzegorz Bizon2016-07-082-7/+10
| |
* | Require reference to CI config for some entriesGrzegorz Bizon2016-07-071-0/+7
| |
* | Improve creating CI config entries for jobs configGrzegorz Bizon2016-07-071-6/+10
| |
* | Simplify CI config entry node factory, use attribsGrzegorz Bizon2016-07-076-35/+30
| |
* | Add scaffold of CI config for the job stage entryGrzegorz Bizon2016-07-071-0/+22
| |
View Lorry Controller Status