| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
This style change enforces `return if ...` instead of
`return nil if ...` to save maintainers a few minor review points
|
|
|
|
|
|
|
|
|
| |
This changes the permission check so it uses the policy on Noteable
instead of Project. This prevents bypassing of rules defined in
Noteable for locked discussions and confidential issues.
Also rechecks permissions when reply_to_discussion_id is provided since the
discussion_id may be from a different noteable.
|
|
|
|
| |
Load whole file in memory to simplify code
|
|
|
|
| |
Also changes old calls to the service
|
| |
|
| |
|
|
|
|
| |
including verifying the project_slug
|
| |
|
|
|
|
| |
We now use `-issue` in order to support catch all email addresses
|
|
|
|
|
| |
We now use `-merge-request` instead of `+merge-request+`
in order to support catch all email addresses
|
|
|
|
|
| |
We now use `-unsubscribe` instead of `+unsubscribe`
in order to support catch all email addresses
|
|\
| |
| |
| |
| | |
Enable even more frozen string in lib/gitlab
See merge request gitlab-org/gitlab-ce!22863
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Enables frozens string for the following:
* lib/gitlab/conflict/**/*.rb
* lib/gitlab/cross_project_access/**/*.rb
* lib/gitlab/cycle_analytics/**/*.rb
* lib/gitlab/data_builder/**/*.rb
* lib/gitlab/database/**/*.rb
* lib/gitlab/dependency_linker/**/*.rb
* lib/gitlab/diff/**/*.rb
* lib/gitlab/downtime_check/**/*.rb
* lib/gitlab/email/**/*.rb
* lib/gitlab/etag_caching/**/*.rb
Partially addresses gitlab-org/gitlab-ce#47424.
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows users to add patches as attachments to merge request
created via email.
When an email to create a merge request is sent, all the attachments
ending in `.patch` will be applied to the branch specified in the
subject of the email. If the branch did not exist, it will be created
from the HEAD of the repository.
When the patches could not be applied, the error message will be
replied to the user.
The patches can have a maximum combined size of 2MB for now.
|
|
|
|
|
| |
This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| | |
[master] Don't expose project names in various counters
See merge request gitlab/gitlabhq!2418
|
| |
| |
| |
| |
| |
| |
| | |
Various counters would expose either project names, or full project
paths (e.g. "gitlab-org/gitlab-ce"). This commit changes various places
where we use "add_event" so we no longer expose (potentially) private
information.
|
| | |
|
|/ |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updates from MR discussion
1. Added test for ReplyParser
2. Changed param to trim_reply with default set as true
Removed keyword param in favor of normal options param
updates for MR discussion
Resolutions for code review comments
more code review fixes
|
| |
|
|
|
|
|
|
|
| |
This could only be possible for users that can create merge requests
within a project.
So they need to be a allowed to create a branch and create a merge request.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a merge request is created from email, use message body
as merge request description. If message body is empty then
merge request description is still created from the source
branch commit (if there is only single commit in the merge
request).
If message body is empty and there are multiple commits in
the source branch, then merge request description is left empty.
Closes #40968
|
|
|
|
|
|
|
|
|
|
|
| |
* new merge request can be created by sending an email to the specific
email address (similar to creating issues by email)
* for the first iteration, source branch must be specified in the mail
subject, other merge request parameters can not be set yet
* user should enable "Receive notifications about your own activity" in
user settings to receive a notification about created merge request
Part of #32878
|
|
|
|
| |
Adds a rubocop rule (with autocorrect) to ensure line break after guard clauses.
|
|
|
|
|
|
|
|
|
|
| |
This would be much more accurate. We assume this is an
auto-generated email if such header is provided, and
the value is not "no". It could also be: "auto-generated",
"auto-replied", or other values from extension. It seems
that only "no" could mean that this is sent by a human.
See: https://tools.ietf.org/html/rfc3834
|
|
|
|
| |
Also make it easier to have mailer helper
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
`Project#inspect` isn't very useful for examining usage of these features.
|
|\
| |
| |
| |
| | |
Prepare uploaders for personal snippets comments
See merge request !11022
|
| | |
|
| |
| |
| |
| |
| | |
These set the 'actual' destination email in one of the Delivered-To lines, so
check those too.
|
|/
|
|
|
|
| |
If an email doesn't match our incoming email patterns on the To header, we fall
back to the References header. If there was no References header, we'd raise an
exception, when we'd be better off acting as if it was empty.
|
| |
|
| |
|
|
|
|
|
| |
This lets us track how many incoming emails a GitLab instance is processing, by
email type (handler) and by project (where applicable).
|
|\ |
|
| | |
|
| | |
|
|/ |
|