| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | Enable frozen string for lib/gitlab/*.rb | gfyoung | 2018-10-22 | 1 | -0/+2 |
| | | |||||
| * | Fix Error 500s due to encoding issues when Wiki hooks fire | Stan Hu | 2018-08-29 | 1 | -1/+1 |
| | | | | | | | | | | | | | Saved Wiki content goes through the GitalyClient::WikiService, which calls StringIO#set_encoding on the input stream. The problem is that this call mutates the encoding of the given string object to ASCII-88BIT, which causes problems for models expecting the data to still be in UTF-8. Freezing the input disables this behavior: https://github.com/ruby/ruby/blob/v2_4_4/ext/stringio/stringio.c#L1583 Closes #50590 | ||||
| * | Resolve Naming/UncommunicativeMethod | Lin Jen-Shin | 2018-07-09 | 1 | -5/+5 |
| | | |||||
| * | Updates from `rubocop -a` | Lin Jen-Shin | 2018-07-09 | 1 | -1/+1 |
| | | |||||
| * | Fix EncodingHelper#clean blowing up on UTF-16BE stringsfix/encoding-helper-clean-blowing-up-on-utf-16be | Ahmad Sherif | 2018-03-22 | 1 | -1/+1 |
| | | | | | Closes gitaly#1101 | ||||
| * | Return a warning string if we try to encode to unsupported encoding | Ahmad Sherif | 2018-02-09 | 1 | -3/+3 |
| | | | | | Fixes gitlab-development-kit#321 | ||||
| * | Fix a bug where charlock_holmes was used needlessly to encode strings41677-branch-name-omitted-due-to-bad-utf-8-conversion-by-gitaly-ref-handler | Alejandro Rodríguez | 2018-01-04 | 1 | -10/+16 |
| | | |||||
| * | Move encoding methods to the more general EncodingHelpergitaly-encoding-helpers | Alejandro Rodríguez | 2017-12-28 | 1 | -0/+10 |
| | | |||||
| * | Fix encoding bugs in Gitlab::Git::User | Jacob Vosmaer (GitLab) | 2017-11-23 | 1 | -0/+4 |
| | | |||||
| * | Avoind unnecesary `force_encoding` operations | Alejandro Rodríguez | 2017-10-18 | 1 | -2/+5 |
| | | | | | | | They're costly. This will also avoid some edge cases where charlock_holmes assigns a weird encoding to a perfectly valid UTF-8 string. | ||||
| * | remove useless comment | micael.bergeron | 2017-09-06 | 1 | -2/+0 |
| | | |||||
| * | renames ambiguous methods and add spec | micael.bergeron | 2017-09-06 | 1 | -5/+5 |
| | | |||||
| * | fix refactoring error with Blob.binary? | micael.bergeron | 2017-09-06 | 1 | -4/+4 |
| | | | | | remove some lint | ||||
| * | revert to using a simple representation | micael.bergeron | 2017-09-06 | 1 | -5/+12 |
| | | |||||
| * | wip: fake its a binary diff | micael.bergeron | 2017-09-06 | 1 | -4/+12 |
| | | |||||
| * | Raise encoding confidence threshold to 50 | Lin Jen-Shin | 2017-08-08 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | It is recommended that we set this to 50: https://gitlab.com/gitlab-org/gitlab-ce/issues/35098#note_35036746 In this particular issue, the confidence was 42 for Shift JIS, but in fact that's encoded in UTF-8 just with a single bad character. In this case, we shouldn't try to treat it as Shift JIS, but just treat it as UTF-8 and remove invalid bytes. Treating it like Shift JIS would corrupt the whole data. Unfortunately, the diff which would cause this could not be disclosed therefore we can't use it as a test example. | ||||
| * | Fix binary encoding error on MR diffs | James Lopez | 2017-06-06 | 1 | -1/+1 |
| | | |||||
| * | Rename `Gitlab::Git::EncodingHelper` to `Gitlab::EncodingHelper` | Bob Van Landuyt | 2017-06-01 | 1 | -0/+62 |
 |
index : delta/gitlab/gitlab-ce.git | |
| gitlab.com: gitlab-org/gitlab-ce.git |
| summaryrefslogtreecommitdiff |