summaryrefslogtreecommitdiff
path: root/lib/gitlab/legacy_github_import
Commit message (Collapse)AuthorAgeFilesLines
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-10-101-1/+2
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-09-181-2/+0
|
* Do not allow localhost url redirection in GitHub Integrationmanojmj2019-07-051-1/+1
|
* Show upcoming status for releasesJason Goodman2019-07-031-0/+1
| | | | | | Add released_at field to releases API Add released_at column to releases table Return releases to the API sorted by released_at
* Don't import pull request comments from Gitea reposJohn Kristensen2019-06-121-1/+6
| | | | | | | | | | | | The Gitea API does not provide the following API endpoint for pull request comments: /api/v1/repos/{owner}/{repo}/pulls/comments When the importer attempts to request this endpoint it receives a '404 Not Found' error which causes the import to fail. By skipping any attempts to import pull requests comments from Gitea we can ensure that the import can complete successfully.
* Merge branch '47327-fix-github-project-import-visibility' into 'master'Douwe Maan2019-04-101-1/+1
|\ | | | | | | | | Fix GitHub project import visibility See merge request gitlab-org/gitlab-ce!27133
| * Fix GitHub project import visibilityDaniel Wyatt2019-04-081-1/+1
| |
* | Set release name when adding release notes to an existing tagJason Goodman2019-04-091-0/+1
|/ | | | Also set the release sha and author
* Run rubocop -aNick Thomas2019-03-131-32/+24
|
* Adds the Rubocop ReturnNil copAndrew Newdigate2019-03-062-3/+3
| | | | | This style change enforces `return if ...` instead of `return nil if ...` to save maintainers a few minor review points
* Refactor use of Shell.import_repository for WikisStan Hu2019-02-052-1/+5
| | | | | | The previous behavior would pass in a list of parameters to Shell, but we can improve this by using the WikiFormatter and Project models to give us the same information.
* Send project name with Gitaly repository requestsStan Hu2019-02-051-1/+1
| | | | | | | When hashed storage is in use, it's helpful to have the project name associated with the request. Closes https://gitlab.com/gitlab-org/gitaly/issues/1394
* Removes all the irrelevant import related code and columnsTiago Botelho2018-11-271-2/+1
| | | | | Clears the import related columns and code from the Project model over to the ProjectImportState model
* Enable even more frozen string for lib/gitlabgfyoung2018-11-1614-0/+28
| | | | | | | | | | | | | | | | Enables frozen string for the following: * lib/gitlab/hook_data/**/*.rb * lib/gitlab/i18n/**/*.rb * lib/gitlab/import/**/*.rb * lib/gitlab/import_export/**/*.rb * lib/gitlab/kubernetes/**/*.rb * lib/gitlab/legacy_github_import/**/*.rb * lib/gitlab/manifest_import/**/*.rb * lib/gitlab/metrics/**/*.rb * lib/gitlab/middleware/**/*.rb Partially addresses gitlab-org/gitlab-ce#47424.
* Disable existing offenses for the CodeReuse copsYorick Peterse2018-09-115-0/+14
| | | | | This whitelists all existing offenses for the various CodeReuse cops, of which most are triggered by the CodeReuse/ActiveRecord cop.
* Use Github repo visibility during import while respecting restricted ↵Imre Farkas2018-06-061-1/+4
| | | | visibility levels
* Backports every CE related change from ee-44542 to CETiago Botelho2018-05-041-1/+2
|
* Use shard name in Git::GitlabProjects instead of shard pathAhmad Sherif2018-04-031-1/+1
| | | | Closes gitaly#1110
* Fix provider server URL used when listing repos to importrd-fix-github-url-when-listing-repositories-at-importingRubén Dávila2018-03-121-1/+1
| | | | Also use Gitlab::Auth::OAuth::Provider.config_for to access OmniAuth config
* CE backport for creating CI/CD projects from GitHubRubén Dávila2018-03-071-4/+5
|
* use Gitlab::UserSettings directly as a singleton instead of ↵Mario de la Ossa2018-02-021-3/+1
| | | | including/extending it
* Rename fetch_refs to refmapDouwe Maan2017-11-231-2/+2
|
* Clean up repository fetch and mirror methodsDouwe Maan2017-11-231-0/+4
|
* Adds Rubocop rule for line break after guard clauseJacopo2017-11-161-0/+1
| | | | Adds a rubocop rule (with autocorrect) to ensure line break after guard clauses.
* Rewrite the GitHub importer from scratchYorick Peterse2017-11-0714-0/+1017
Prior to this MR there were two GitHub related importers: * Github::Import: the main importer used for GitHub projects * Gitlab::GithubImport: importer that's somewhat confusingly used for importing Gitea projects (apparently they have a compatible API) This MR renames the Gitea importer to Gitlab::LegacyGithubImport and introduces a new GitHub importer in the Gitlab::GithubImport namespace. This new GitHub importer uses Sidekiq for importing multiple resources in parallel, though it also has the ability to import data sequentially should this be necessary. The new code is spread across the following directories: * lib/gitlab/github_import: this directory contains most of the importer code such as the classes used for importing resources. * app/workers/gitlab/github_import: this directory contains the Sidekiq workers, most of which simply use the code from the directory above. * app/workers/concerns/gitlab/github_import: this directory provides a few modules that are included in every GitHub importer worker. == Stages The import work is divided into separate stages, with each stage importing a specific set of data. Stages will schedule the work that needs to be performed, followed by scheduling a job for the "AdvanceStageWorker" worker. This worker will periodically check if all work is completed and schedule the next stage if this is the case. If work is not yet completed this worker will reschedule itself. Using this approach we don't have to block threads by calling `sleep()`, as doing so for large projects could block the thread from doing any work for many hours. == Retrying Work Workers will reschedule themselves whenever necessary. For example, hitting the GitHub API's rate limit will result in jobs rescheduling themselves. These jobs are not processed until the rate limit has been reset. == User Lookups Part of the importing process involves looking up user details in the GitHub API so we can map them to GitLab users. The old importer used an in-memory cache, but this obviously doesn't work when the work is spread across different threads. The new importer uses a Redis cache and makes sure we only perform API/database calls if absolutely necessary. Frequently used keys are refreshed, and lookup misses are also cached; removing the need for performing API/database calls if we know we don't have the data we're looking for. == Performance & Models The new importer in various places uses raw INSERT statements (as generated by `Gitlab::Database.bulk_insert`) instead of using Rails models. This allows us to bypass any validations and callbacks, drastically reducing the number of SQL queries and Gitaly RPC calls necessary to import projects. To ensure the code produces valid data the corresponding tests check if the produced rows are valid according to the model validation rules.