Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Use Process::Status rather than an integer | Lin Jen-Shin | 2018-01-26 | 1 | -3/+3 |
| | | | | However keep backward compatibility | ||||
* | Fail static-analysis if there's output to stderr | Lin Jen-Shin | 2018-01-26 | 1 | -5/+18 |
| | | | | TODO: fix offenders | ||||
* | Accept environment variables from the `pre-receive` script. | Timothy Andrew | 2016-12-16 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. Starting version 2.11, git changed the way the pre-receive flow works. - Previously, the new potential objects would be added to the main repo. If the pre-receive passes, the new objects stay in the repo but are linked up. If the pre-receive fails, the new objects stay orphaned in the repo, and are cleaned up during the next `git gc`. - In 2.11, the new potential objects are added to a temporary "alternate object directory", that git creates for this purpose. If the pre-receive passes, the objects from the alternate object directory are migrated to the main repo. If the pre-receive fails the alternate object directory is simply deleted. 2. In our workflow, the pre-recieve script (in `gitlab-shell) calls the `/allowed` endpoint, which calls out directly to git to perform various checks. These direct calls to git do _not_ have the necessary environment variables set which allow access to the "alternate object directory" (explained above). Therefore these calls to git are not able to access any of the new potential objects to be added during this push. 3. We fix this by accepting the relevant environment variables (GIT_ALTERNATE_OBJECT_DIRECTORIES, GIT_OBJECT_DIRECTORY) on the `/allowed` endpoint, and then include these environment variables while calling out to git. 4. This commit includes (whitelisted) these environment variables while making the "force push" check. A `Gitlab::Git::RevList` module is extracted to prevent `ForcePush` from being littered with these checks. | ||||
* | Fix Gitlab::Popen.popen thread-safety issuefix/gitlab-popen-thread-safety | Ahmad Sherif | 2016-09-13 | 1 | -6/+6 |
| | | | | Fixes #21842 | ||||
* | Use 'git update-ref' for safer web commits | Jacob Vosmaer | 2016-09-02 | 1 | -2/+2 |
| | |||||
* | Enable Style/SpaceAroundEqualsInParameterDefault coprubocop/SpaceAroundEqualsInParameterDefault | Gabriel Mazetto | 2016-08-06 | 1 | -1/+1 |
| | |||||
* | Style/RedundantReturn enabledmore-rubocop-styles | Dmitriy Zaporozhets | 2015-03-24 | 1 | -1/+1 |
| | |||||
* | Close standard input in Gitlab::Popen.popen | Jacob Vosmaer | 2015-01-05 | 1 | -0/+3 |
| | |||||
* | Make it possible to call Gitlab::Popen.popen | Jacob Vosmaer | 2014-02-25 | 1 | -0/+2 |
| | |||||
* | Make the Gitlab::Popen path argument optional | Jacob Vosmaer | 2014-02-25 | 1 | -1/+2 |
| | |||||
* | Change Gitlab::Popen to use arrays for commands | Jacob Vosmaer | 2014-02-25 | 1 | -2/+7 |
| | |||||
* | Whitespace fixes to patch | Dale Hamel | 2013-10-08 | 1 | -2/+1 |
| | |||||
* | Ensure directory exists before changing in popen | Dale Hamel | 2013-10-08 | 1 | -0/+7 |
| | | | | | | If the directory does not exist, we want to ensure that it does. Forking repos will fail in some situations because of this issue. | ||||
* | Replace old hashes with new 1.9 ruby hashes (rebase) | Andrey Kumanyaev | 2013-05-05 | 1 | -1/+1 |
| | |||||
* | Do gitolite calls async. Remove satellite with project remove | Dmitriy Zaporozhets | 2013-01-28 | 1 | -0/+18 |