| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |\
| |
| |
| |
| |
| | |
'backstage/gb/use-persisted-stages-to-improve-pipelines-table'
# Conflicts:
# db/schema.rb
|
| | | |
|
| | |\
| | |
| | |
| | |
| | |
| | |
| | | |
Add background migrations to archive legacy job traces
Closes #46642
See merge request gitlab-org/gitlab-ce!19194
|
| | | | |
|
| | | | |
|
| | | | |
|
| | |\ \
| | | |
| | | |
| | | |
| | | | |
Also verify if extending would override a class method
See merge request gitlab-org/gitlab-ce!19377
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Since extending a class means including on the singleton class of the
class, this should now complain this:
``` ruby
module M
extend Gitlab::Utils::Override
override :f
def f
super.succ
end
end
class C
extend M
def self.f
0
end
end
```
It should complain because `C.f` wasn't calling `M#f`.
This should pass verification:
``` ruby
module M
extend Gitlab::Utils::Override
override :f
def f
super.succ
end
end
class B
def self.f
0
end
end
class C < B
extend M
end
```
Because `C.f` would now call `M#f`, and `M#f` does override something.
|
| | |\ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Perform pull request IO work outside a transaction
See merge request gitlab-org/gitlab-ce!19372
|
| | | |/ /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When importing a GitHub pull request we would perform all work in a
single database transaction. This is less than ideal, because we perform
various slow Git operations when creating a merge request. This in turn
can lead to many DB connections being used, while just waiting for an IO
operation to complete.
To work around this, we now move most of the heavy lifting out of the
database transaction. Some extra error handling is added to ensure we
can resume importing a partially imported pull request, instead of just
throwing an error.
This commit also changes the specs for IssueImporter so they don't rely
on deprecated RSpec methods.
|
| | |\ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Bring back the EE changes to CE to authentication of builds
See merge request gitlab-org/gitlab-ce!19391
|
| | | |/ / |
|
| |\ \ \ \
| |/ / /
| | | |
| | | |
| | | |
| | | | |
'backstage/gb/use-persisted-stages-to-improve-pipelines-table'
Conflicts:
app/models/ci/pipeline.rb
|
| | |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This currently causes 500's errors when loading the MR page
(Discussion) in a few scenarios.
We were not considering detailed diff headers such as
"--- a/doc/update/mysql_to_postgresql.md\n+++ b/doc/update/mysql_to_postgresql.md"
to crop the diff. In order to address it, we're now using
Gitlab::Diff::Parser, clean the diffs and builds Gitlab::Diff::Line objects
we can iterate and filter on.
|
| | | | |
|
| | |\ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Rails5 fix arel from
Closes #46281
See merge request gitlab-org/gitlab-ce!19340
|
| | | |/ |
|
| | | | |
|
| | | | |
|
| | |\ \
| | |/ |
|
| | | | |
|
| | | | |
|
| | | |\
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Resolve "A lot of constants redefinition warnings"
Closes #46481
See merge request gitlab-org/gitlab-ce!19286
|
| | | | |
| | | |
| | | |
| | | | |
Which could extend from EE
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
* Replace `require` or `require_relative` with `require_dependency`
* Remove unneeded `autoload`
|
| | | |/
| | |
| | |
| | | |
because of SSRF
|
| | |\ \
| | |/ |
|
| | | |\
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Make ActiveRecordSubscriber rails 5 compatible
Closes #44702
See merge request gitlab-org/gitlab-ce!19276
|
| | | | | |
|
| | | |\ \
| | | | |
| | | | |
| | | | |
| | | | | |
Take two for MR metrics population background migration
See merge request gitlab-org/gitlab-ce!19097
|
| | | | | | |
|
| | | | | | |
|
| | | |\ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Replace .having with .where in calendar query
Closes #46964
See merge request gitlab-org/gitlab-ce!19230
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
the current syntax doesn't work properly in Rails 5, the resulting query
looks like:
HAVING "events"."project_id" IN (0)
instead of:
HAVING "events"."project_id" IN (SELECT "projects"."id" FROM...
Also we should not use ActiveRecord internal methods. In this case we
can filter projects in WHERE clause instead of doing this in HAVING
clause. Usage of WHERE should be also more efficient because grouping
is then done on much smaller subset of records.
|
| | | |\ \ \ \
| | | |_|_|/
| | |/| | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fix encoding bug in Gitaly::Commit::TreeEntry
Closes #46445 and gitaly#1208
See merge request gitlab-org/gitlab-ce!19243
|
| | | | | |/
| | | |/| |
|
| | | |\ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Removal of API v3 from the codebase
Closes #36819
See merge request gitlab-org/gitlab-ce!18970
|
| | | | |/ / |
|
| | | |\ \ \
| | | |/ /
| | |/| |
| | | | |
| | | | | |
Fix various bugs related to relative_url_root in development
See merge request gitlab-org/gitlab-ce!19213
|
| | | | | | |
|
| | | |\ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Extracted auxiliary methods from storage.rake into specific RakeHelper
See merge request gitlab-org/gitlab-ce!18962
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | |\ \ \ \
| | | |_|_|/
| | |/| | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Import bitbucket issues that are reported by an anonymous user
Closes #44381
See merge request gitlab-org/gitlab-ce!18199
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
For these kind of issues, the "reporter" field is present but zero.
In such a case, "fetch" will not return the default value, but it will
return nil.
Hence, importing fails, because the "username" field of nil is referenced
Fixes issue #44381
|
| | | | | | | |
|
| | |\ \ \ \ \
| | |/ / / / |
|
| | | |\ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
[CE] Resolve "Extract EE specific files/lines for some controller specs"
Closes #6045
See merge request gitlab-org/gitlab-ce!19089
|
| | | | |/ / /
| | | | | |
| | | | | |
| | | | | | |
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
