summaryrefslogtreecommitdiff
path: root/lib
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Exempt `jwt/auth` for user `gitlab-ci-token` from rate limitingMarius Bobin2019-08-231-1/+5
| |/ |/|
* | Expose namespace storage statistics with GraphQLAlessio Caiazza2019-08-221-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Root namespaces have storage statistics. This commit allows namespace owners to get those stats via GraphQL queries like the following one { namespace(fullPath: "a_namespace_path") { rootStorageStatistics { storageSize repositorySize lfsObjectsSize buildArtifactsSize packagesSize wikiSize } } }
* | Log time spent on CPU to sidekiq.logBalakumar2019-08-221-10/+36
| |
* | Merge branch 'feat/smime-signed-notification-emails' into 'master'Sean McGivern2019-08-223-0/+115
|\ \ | |/ |/| | | | | feat: smime signed notification emails See merge request gitlab-org/gitlab-ce!30644
| * feat: SMIME signed notification emailsDiego Louzán2019-08-203-0/+115
| | | | | | | | | | | | - Add mail interceptor the signs outgoing email with SMIME - Add lib and helpers to work with SMIME data - New configuration params for setting up SMIME key and cert files
* | Merge branch ↵Kushal Pandya2019-08-221-0/+2
|\ \ | | | | | | | | | | | | | | | | | | 'ee-2502-refactor-ee-app-assets-javascripts-approvals-components-approvers_select-vue-to-remove-approverusers' into 'master' Add a new method to `Api.js`: `projectUsers` See merge request gitlab-org/gitlab-ce!31801
| * | Add a skip_users filter to the project users APINick Thomas2019-08-191-0/+2
| | | | | | | | | | | | | | | | | | This functionality is available in the /autocomplete users pseudo-API. We're attempting to replace that with the canonical API, so it needs support for this parameter too.
* | | Add Gitaly info-ref cache feature flagsPaul Okstad2019-08-221-2/+4
| | |
* | | Merge branch 'sidekiq-interrupt-running-jobs-deadset' into 'master'Stan Hu2019-08-211-1/+5
|\ \ \ | | | | | | | | | | | | | | | | Put cancelled job in DeadSet See merge request gitlab-org/gitlab-ce!32070
| * | | Put cancelled job in DeadSetsidekiq-interrupt-running-jobs-deadsetKamil Trzciński2019-08-211-1/+5
| | | | | | | | | | | | | | | | | | | | This replicates Sidekiq behavior of pushing dead job into DeadSet.
* | | | Merge branch 'uncomment_commit_signatures_feature_flag' into 'master'Stan Hu2019-08-211-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Upgrade to gitaly 1.60.0 and uncomment get_commit_signatures feature flag Closes #65991 See merge request gitlab-org/gitlab-ce!31981
| * | | | Uncomment get_commit_signatures feature flagFelipe Artur2019-08-191-1/+1
| | | | |
* | | | | Ensure CI matching operator receives an objectMarius Bobin2019-08-212-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | Ensure the evaluation of right-hand side expression always results in the returning of an object or an empty String
* | | | | Merge branch 'sidekiq-interrupt-running-jobs' into 'master'Stan Hu2019-08-213-1/+202
|\ \ \ \ \ | | |/ / / | |/| | | | | | | | | | | | | Allow to interrupt running sidekiq jobs See merge request gitlab-org/gitlab-ce!31818
| * | | | Properly handle `sidekiq` skipsidekiq-interrupt-running-jobsKamil Trzciński2019-08-212-6/+9
| | | | | | | | | | | | | | | | | | | | Transform `CancelledError` into `JobRetry::Skip`
| * | | | Improve resillency of monitorKamil Trzciński2019-08-212-26/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Retry connection when it fails - Properly shutdown daemon - Stop monitor if the Exception is raised - Properly guard exception handling
| * | | | Perform cheap thread findKamil Trzciński2019-08-211-9/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we process message that is not designated to us previously we would fire a separate Thread for that. We don't need to do it. We can cheaply check if thread is available, if it is, we can perform expensive operation then.
| * | | | Rework `Sidekiq::JobsThreads` into `Monitor`Kamil Trzciński2019-08-214-95/+166
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes: - very shallow `Middleware::Monitor` to only request tracking of sidekiq jobs, - `SidekiqStatus::Monitor` to be responsible to maintain persistent connection to receive messages, - `SidekiqStatus::Monitor` to always use structured logging and instance variables
| * | | | Allow to interrupt running jobsKamil Trzciński2019-08-212-0/+95
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds a middleware to track all threads for running jobs. This makes sidekiq to watch for redis-delivered notifications. This makes be able to send notification to interrupt running sidekiq jobs. This does not take into account any native code, as `Thread.raise` generates exception once the control gets back to Ruby. The separate measure should be taken to interrupt gRPC, shellouts, or anything else that escapes Ruby.
* | | | | Add service classes for mutating AwardEmojiLuke Duncalfe2019-08-211-4/+4
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adding, destroying and toggling emoji previously lacked services and instead were performed through methods called on Awardable models. This led to inconsistencies where relevant todos would be marked as done only when emoji were awarded through our controllers, but not through the API. Todos could also be marked as done when an emoji was being removed. Behaviour changes - Awarding emoji through the API will now mark a relevant Todo as done - Toggling an emoji off (destroying it) through our controllers will no longer mark a relevant Todo as done Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63372
* | | | Introducing new Syntax for Ci::Build inclusion rulesdrew2019-08-2011-24/+317
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Added Gitlab::Ci::Config::Entry::Rules and Gitlab::Ci::Config::Entry::Rules:Rule to handle lists of Rule objects to be evalauted for job inclusion - Added `if:` and `changes:` as available Rules::Rule::Clause classes - Added Rules handling logic to Seed::Build#included? with extra specs - Use DisallowedKeysValidator to mutually exclude rules: from only:/except: on job config
* | | | Standardize remote_ip and path keys for auth.log and api_json.logStan Hu2019-08-203-3/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Current `auth.log` uses `fullpath` and `ip`, while `api_json.log` uses `remote_ip` and `path` for the same fields. Let's standardize these namings to make it easier for people working with the data. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66167
* | | | Merge branch 'bvl-mr-commit-note-counter' into 'master'Douwe Maan2019-08-201-4/+4
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Count notes for commits and merge requests See merge request gitlab-org/gitlab-ce!31912
| * | | | Count comments on notes and merge requestsBob Van Landuyt2019-08-161-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | This extends our existing `Gitlab::UsageDataCounters::NoteCounter` to also count notes on commits and merge requests
* | | | | Allow measurement for Sidekiq jobs taking > 2.5sAndrew Newdigate2019-08-201-1/+5
| | | | | | | | | | | | | | | | | | | | Fix for https://gitlab.com/gitlab-org/gitlab-ce/issues/66319.
* | | | | Merge branch 'sh-fix-issues-api-gitaly-nplusone' into 'master'Sean McGivern2019-08-202-3/+8
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix Gitaly N+1 calls with listing issues/MRs via API Closes #66202 See merge request gitlab-org/gitlab-ce!31938
| * | | | | Fix Gitaly N+1 calls with listing issues/MRs via APIsh-fix-issues-api-gitaly-nplusoneStan Hu2019-08-172-3/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In GitLab 9.0, https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9661 removed the `subscribed` flag from the API when the user requested a list of issues or merge requests since calculating this value triggers extensive Markdown processing. In GitLab 12.0 via a4fbf39e, we accidentally reintroduced this performance regression by changing `IssueBasic` to `Issue` in `entities.rb`. This showed up as a Gitaly N+1 issue since the Markdown processing would attempt to extract a commit if it detected a regex that matched a commit. We restore the prior behavior by once again removing the `subscribed` flag for the bulk list of issues and merge requests and add a test to ensure they aren't reintroduced. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66202
* | | | | | Use ActiveModel's type instead of virtusPeter Leitzen2019-08-201-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The virtus project has been discontinued: https://github.com/solnic/virtus/commit/a6f896984
* | | | | | Add missing SAST environment variablesCameron Swords2019-08-201-0/+3
| | | | | |
* | | | | | Add support for sentry_extra_data in exceptionsAlex Kalderimis2019-08-191-1/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows exceptions to advertise their support for sentry and provide structured data.
* | | | | | Merge branch '64251-branch-name-set-cache' into 'master'Robert Speicher2019-08-192-0/+120
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | | | | | | | | | | | | | Cache branch and tag names as Redis sets See merge request gitlab-org/gitlab-ce!30476
| * | | | | Cache branch and tag names as Redis setsNick Thomas2019-08-162-0/+120
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows us to check inclusion for the *_exists? methods without downloading the full list of branch names, which is over 100KiB in size for gitlab-ce at the moment.
* | | | | | Merge branch '39-count-unique-users-for-more-accurate-smau-reporting' into ↵Nick Thomas2019-08-191-2/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'master' Allow UsageData.count to use count_by: See merge request gitlab-org/gitlab-ce!30770
| * | | | | | Allow UsageData.count to use count_by:Ash McKenzie2019-07-181-2/+2
| | | | | | |
* | | | | | | Clean Sidekiq metrics from multiproc dir on startAleksei Lipniagov2019-08-191-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After moving the multiproc dir cleanup into `config.ru`:`warmup`, we stopped cleaning Sidekiq metrics dir which is not correct. This MR intended to fix that. More details: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31668
* | | | | | | Fix pipelines not always being created after a pushsh-fix-pipelines-not-being-createdStan Hu2019-08-171-2/+0
| |_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31741 introduced a regression where not all the right parameters would be passed into `Ci::CreatePipelineService`. We fix this by breaking out the pipeline parameters and reusing a method from `Gitlab::DataBuilder::Push`. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66196
* | | | | | Merge branch 'legacy-attachments-migrate-fix' into 'master'Michael Kozono2019-08-164-0/+202
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Migrate legacy uploads rake tasks See merge request gitlab-org/gitlab-ce!29409
| * | | | | | Add rake tasks for migrating leacy uploadslegacy-attachments-migrate-fixJarka Košanová2019-08-164-0/+202
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - move uploads created by AttachmentUploader - handle also files created for legacy_diff_notes
* | | | | | | Expire project caches once per push instead of once per refStan Hu2019-08-161-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously `ProjectCacheWorker` would be scheduled once per ref, which would generate unnecessary I/O and load on Sidekiq, especially if many tags or branches were pushed at once. `ProjectCacheWorker` would expire three items: 1. Repository size: This only needs to be updated once per push. 2. Commit count: This only needs to be updated if the default branch is updated. 3. Project method caches: This only needs to be updated if the default branch changes, but only if certain files change (e.g. README, CHANGELOG, etc.). Because the third item requires looking at the actual changes in the commit deltas, we schedule one `ProjectCacheWorker` to handle the first two cases, and schedule a separate `ProjectCacheWorker` for the third case if it is needed. As a result, this brings down the number of `ProjectCacheWorker` jobs from N to 2. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52046
* | | | | | | Remove Security Dashboard feature flagrossfuhrman2019-08-161-3/+1
| |_|_|/ / / |/| | | | | | | | | | | | | | | | | This removes the group_overview_security_dashboard feature flag
* | | | | | Merge branch 'mc/feature/pipeline-tracking-config-ce' into 'master'Kamil Trzciński2019-08-162-2/+6
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add `needs:` CI config option CE Closes gitlab-ee#12334 See merge request gitlab-org/gitlab-ce!31346
| * | | | | | Port changes from EEmc/feature/pipeline-tracking-config-ceMatija Čupić2019-08-042-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ports changes from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/12343
* | | | | | | Merge branch 'fix/commits-api-empty-refname' into 'master'Nick Thomas2019-08-161-1/+1
|\ \ \ \ \ \ \ | |_|_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fix handling of empty ref_name parameter string in commits api Closes #64745 See merge request gitlab-org/gitlab-ce!31687
| * | | | | | fix handling of empty ref_name parameter string in commits apiArmin Hohenegger2019-08-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when params[:ref_name] is set to "" by passing an empty query parameter to the api it is evaluated as false by the || operator. The use of active support core extensions presence method fixes the original implemantation. https://guides.rubyonrails.org/active_support_core_extensions.html#presence
* | | | | | | Merge branch '24705-multi-selection-for-delete-on-registry-page' into 'master'Thong Kuah2019-08-151-0/+7
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolve "Multi selection for delete on registry page" Closes #24705 See merge request gitlab-org/gitlab-ce!30837
| * | | | | | | Validates tag names and tags#bulk_destroyGiorgenes Gelatti2019-07-301-0/+7
| | | | | | | |
* | | | | | | | Support query parameters in metrics embedsSarah Yasonik2019-08-152-13/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/issues/62971 Adds support for embedding specific charts from the metrics dashboard. Expected parameters are dashboard, title, group, and y_label.
* | | | | | | | Squash project templates on updateHordur Freyr Yngvason2019-08-152-14/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As per https://gitlab.com/gitlab-org/gitlab-ce/issues/46043, project templates should be squashed before updating, so that repositories created from these templates don't include the full history of the backing repository.
* | | | | | | | Removes db/fixtures from database filesMayra Cabrera2019-08-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will avoid Danger to suggest a database review for files inside db/fixtures
* | | | | | | | Allow disabling group/project email notificationsBrett Walker2019-08-151-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Adds UI to configure in group and project settings - Removes notification configuration for users when disabled at group or project level