| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
| |
This reverts commit 6c75bd015cba181f028bc87c396c3d8e43b5dc3e, reversing
changes made to 1be7f5aaa38aba79843eae8835be6c99c025e982.
|
| |
|
|
|
|
|
| |
Renamed UrlValidator to AddressableUrlValidator to avoid 'url:' naming collision with ActiveModel::Validations::UrlValidator in 'validates' statement.
Make use of the options attribute of the parent class ActiveModel::EachValidator.
Add more options: allow_nil, allow_blank, message.
Renamed 'protocols' option to 'schemes' to match the option naming from UrlValidator.
|
| | |
|
| |
|
|
| |
Reverts the loading of emojis and its images to move forward with RC
|
| |\
| |
| |
| |
| | |
Fix GitHub project import visibility
See merge request gitlab-org/gitlab-ce!27133
|
| | | |
|
| | |
| |
| |
| |
| | |
Log events so that it's easy to see
when different requests are starting.
|
| |\ \
| | |
| | |
| | |
| | | |
Update comments about N + 1 Gitaly calls
See merge request gitlab-org/gitlab-ce!27178
|
| | | |
| | |
| | |
| | |
| | | |
To make sure all known issues are linked to the correct epic, I've gone
through the code base, and updated the comments where required.
|
| | | |
| | |
| | |
| | | |
spec/features/groups/group_page_with_external_authorization_service_spec to EE
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
[Backport] Support multiple assignees for merge requests
See merge request gitlab-org/gitlab-ce!27089
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Backports https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10161
(code out of ee/ folder).
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Used to get the variables via the API endpoint
`/projects/:id/pipelines/:pipeline_id/variables`
Signed-off-by: Agustin Henze <tin@redhat.com>
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Git push options to create a merge request, set target_branch and set merge when pipeline succeeds
Closes #53198 and #43263
See merge request gitlab-org/gitlab-ce!26752
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
https://gitlab.com/gitlab-org/gitlab-ce/issues/43263
https://gitlab.com/gitlab-org/gitlab-ce/issues/53198
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Exceptions are no longer raised, instead all errors encountered are
added to the errors property.
MergeRequests::BuildService is used to generate attributes of a new
merge request.
Code moved from Api::Internal to Api::Helpers::InternalHelpers.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
MergeRequests::PushOptionsHandlerService has been updated to allow
creating and updating merge requests with the
`merge_when_pipeline_succeeds` set using git push options.
To create a new merge request and set it to merge when the pipeline
succeeds:
git push -u origin -o merge_request.create \
-o merge_request.merge_when_pipeline_succeeds
To update an existing merge request and set it to merge when the
pipeline succeeds:
git push -u origin -o merge_request.merge_when_pipeline_succeeds
Issue https://gitlab.com/gitlab-org/gitlab-ce/issues/53198
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Previously the raw push option Array was sent to Pipeline::Chain::Skip.
This commit updates this class (and the chain of classes that pass the
push option parameters from the API internal `post_receive` endpoint to
that class) to treat push options as a Hash of options parsed by
GitLab::PushOptions.
The GitLab::PushOptions class takes options like this:
-o ci.skip -o merge_request.create -o merge_request.target=branch
and turns them into a Hash like this:
{
ci: {
skip: true
},
merge_request: {
create: true,
target: 'branch'
}
}
This now how Pipeline::Chain::Skip is determining if the `ci.skip` push
option was used.
|
| | |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
To create a new merge request:
git push -u origin -o merge_request.create
To create a new merge request setting target branch:
git push -u origin -o merge_request.create \
-o merge_request.target=123
To update an existing merge request with a new target branch:
git push -u origin -o merge_request.target=123
A new Gitlab::PushOptions class handles parsing and validating the push
options array. This can be the start of the standard of GitLab accepting
push options that follow namespacing rules. Rules are discussed in issue
https://gitlab.com/gitlab-org/gitlab-ce/issues/43263.
E.g. these push options:
-o merge_request.create -o merge_request.target=123
Become parsed as:
{
merge_request: {
create: true,
target: '123',
}
}
And are fetched with the class via:
push_options.get(:merge_request)
push_options.get(:merge_request, :create)
push_options.get(:merge_request, :target)
A new MergeRequests::PushOptionsHandlerService takes the `merge_request`
namespaced push options and handles creating and updating
merge requests.
Any errors encountered are passed to the existing `output` Hash in
Api::Internal's `post_receive` endpoint, and passed to gitlab-shell
where they're output to the user.
Issue https://gitlab.com/gitlab-org/gitlab-ce/issues/43263
|
| |\ \ \ \
| |_|/ /
|/| | |
| | | |
| | | | |
Add methods to check dead and retrying jobs
See merge request gitlab-org/gitlab-ce!27149
|
| | |/ /
| | |
| | |
| | |
| | | |
It adds two methods for checking if a background job
(for a given class) has dead or retrying jobs.
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is resolving https://gitlab.com/gitlab-org/gitlab-ce/issues/30157.
Implement new API endpoint `/projects/:id/environments/:environment_id`
to expose single environment. Include information for environment's last
deployment if there is one.
|
| |/ /
| |
| |
| | |
Also set the release sha and author
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Fix stage index migration failing in PostgreSQL 10
Closes #59985
See merge request gitlab-org/gitlab-ce!26972
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
As discussed in
https://www.postgresql.org/message-id/9922.1353433645%40sss.pgh.pa.us,
the PostgreSQL window function last_value may not consider the
right rows:
Note that first_value, last_value, and nth_value consider only the rows
within the "window frame", which by default contains the rows from the
start of the partition through the last peer of the current row. This is
likely to give unhelpful results for last_value and sometimes also
nth_value. You can redefine the frame by adding a suitable frame
specification (RANGE or ROWS) to the OVER clause. See Section 4.2.8 for
more information about frame specifications.
This query could be fixed by adding `RANGE BETWEEN UNBOUNDED PRECEDING
AND UNBOUNDED FOLLOWING`, but that's quite verbose. It's simpler just to
use the first_value function.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/59985
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Improve performance of PR import
See merge request gitlab-org/gitlab-ce!27121
|
| | | |/
| |/|
| | |
| | |
| | |
| | | |
This removes unneeded `.reload` call which
makes AR to load ALL objects, and create its
in-memory representation.
|
| |/ / |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
After an initial fetch, the repository will have many loose objects
and refs. Running a `git gc` will compact refs into `packed-refs` and
objects into `.pack` files, which should make importing pull
requests faster.
Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/59477
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Prior this commit exceptions raised during a HTTP request
weren't caught by the Sentry client and were passed to the user.
In addition the Sentry client tried to catch a non-existent error
`Sentry::Client::SentryError`.
Now, the Sentry client catches all possible errors coming from
a HTTP request.
|
| | |
| |
| |
| |
| | |
Reverts https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26520
for Security/DAST.gitlab-ci.yml.
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Clean up `noteable_id` for notes on commits
Closes #58612
See merge request gitlab-org/gitlab-ce!26104
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
This was incorrectly set by a bug in:
https://gitlab.com/gitlab-org/gitlab-ce/issues/54924
Also adds a `batch_size` option to `update_column_in_batches`
|
| |/ / |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Fix real-time updates for projects that contain a reserved word
Closes #60113
See merge request gitlab-org/gitlab-ce!27060
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Projects that included reserved words (e.g. test-create) would fail to
generate a proper ETag key because of the name. To fix this, we add
forward slashes to match the exact name so that /test-create doesn't get
matched, but /create does.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60113
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
[CE-port] Fix Epic depth validation
See merge request gitlab-org/gitlab-ce!26390
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
CE-port of 10546-fix-epic-depth-validation
|
| | | | |
| | | |
| | | |
| | | | |
This reverts merge request !26991
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Remove duplicates from issue related merge requests
See merge request gitlab-org/gitlab-ce!27067
|
| | | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Remove duplicates returned by Issues#related_merge_requests API that
relies on ReferencedMergeRequestsService which returns 2 arrays one of
related MRs and one of related MRs that close the issue(i.e. a subset
of first one). We only need related MRs in this case so just pick the
first array.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Add columns to store project creation settings
Add project creation level column in groups
and default project creation column in application settings
Remove obsolete line from schema
Update migration with project_creation_level column existence check
Rename migrations to avoid conflicts
Update migration methods
Update migration method
|
| |\ \ \ \
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | | |
Serverless backend now uses `gitlabktl` tool
Closes #56252 and #58058
See merge request gitlab-org/gitlab-ce!26926
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Revert "Merge branch 'if-57131-external_auth_to_ce' into 'master'"
See merge request gitlab-org/gitlab-ce!27051
|
| | | | | |
| | | | |
| | | | | |
This reverts merge request !26823
|
| |/ / / /
| | | |
| | | |
| | | |
| | | | |
'master'"
This reverts merge request !26954
|
| | | | |
| | | |
| | | |
| | | | |
spec/features/groups/group_page_with_external_authorization_service_spec to EE
|
