| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
| |
This adds new metrics for monitoring unicorn. These metrics include
process_cpu_seconds_total, process_start_time_seconds, process_max_fds,
and unicorn_workers.
|
| |
|
|
|
|
|
|
|
| |
Users attempting to set merge requests to `remove_source_branch` to
`false` would encounter an Error 500 because the UpdateService and API
checked `present?`, which would always return `false`. We now just
use `has_key?` to decide whether the parameter is present.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60530
|
| |\
| |
| |
| |
| |
| |
| | |
Forbid the usage of reload
Closes #60218
See merge request gitlab-org/gitlab-ce!27125
|
| | |
| |
| |
| |
| |
| |
| | |
The `#reload` makes to load all objects into memory,
and the main purpose of `#reload` is to drop the association cache.
The `#reset` seems to solve exactly that case.
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Remove multi-line suggestions feature flag
Closes #59178
See merge request gitlab-org/gitlab-ce!27219
|
| | | |
| | |
| | |
| | | |
That's a straightforward feature flag code removal for 11.10
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Git FSCK has no timeout
Closes #53319
See merge request gitlab-org/gitlab-ce!27299
|
| | | |/
| |/|
| | |
| | |
| | |
| | |
| | | |
FSCK is usually called through sidekiq, but a rake task doesn't have a
mechanism to default to no timeout for this RPC.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53319
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Validate refs used in controllers don't have spaces
Closes #58572 and gitaly#1425
See merge request gitlab-org/gitlab-ce!24037
|
| | |/ /
| | |
| | |
| | |
| | |
| | |
| | | |
This avoids an unnecessary call to Gitaly and reduces gRPC errors.
* Closes https://gitlab.com/gitlab-org/gitaly/issues/1425
* Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/58572
|
| | | | |
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Require all templates to use default stages
Closes #59992
See merge request gitlab-org/gitlab-ce!26954
(cherry picked from commit 39eb16aab2dbac3347f61f83fb60f5448d44e965)
e0df05cf Require all templates to use default stages
|
| | |
| |
| |
| | |
Added changelog and rebased
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Add missing provider_unauthorized method to import_github.rb
Closes #60347
See merge request gitlab-org/gitlab-ce!27218
|
| | | | |
|
| | | | |
|
| | |/ |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Revert "Remove HipChat integration from GitLab"
Closes #60042
See merge request gitlab-org/gitlab-ce!27172
|
| | |/
| |
| |
| | |
This reverts commit a5378665a1dc0b9c8dc3a4fa279a0eb78aac5aac.
|
| |\ \
| | |
| | |
| | |
| | | |
Revert "Merge branch '24704-download-repository-path' into 'master'"
See merge request gitlab-org/gitlab-ce!27249
|
| | | |
| | |
| | |
| | |
| | | |
This reverts commit 6c75bd015cba181f028bc87c396c3d8e43b5dc3e, reversing
changes made to 1be7f5aaa38aba79843eae8835be6c99c025e982.
|
| |\ \ \
| |/ /
|/| |
| | |
| | |
| | |
| | | |
Guard against nil dereferenced_target
Closes #60076
See merge request gitlab-org/gitlab-ce!27192
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
Renamed UrlValidator to AddressableUrlValidator to avoid 'url:' naming collision with ActiveModel::Validations::UrlValidator in 'validates' statement.
Make use of the options attribute of the parent class ActiveModel::EachValidator.
Add more options: allow_nil, allow_blank, message.
Renamed 'protocols' option to 'schemes' to match the option naming from UrlValidator.
|
| | | | |
|
| | |/
|/|
| |
| | |
Reverts the loading of emojis and its images to move forward with RC
|
| |\ \
| | |
| | |
| | |
| | | |
Fix GitHub project import visibility
See merge request gitlab-org/gitlab-ce!27133
|
| | | | |
|
| | |/
|/|
| |
| |
| | |
Log events so that it's easy to see
when different requests are starting.
|
| |\ \
| | |
| | |
| | |
| | | |
Update comments about N + 1 Gitaly calls
See merge request gitlab-org/gitlab-ce!27178
|
| | | |
| | |
| | |
| | |
| | | |
To make sure all known issues are linked to the correct epic, I've gone
through the code base, and updated the comments where required.
|
| | | |
| | |
| | |
| | | |
spec/features/groups/group_page_with_external_authorization_service_spec to EE
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
[Backport] Support multiple assignees for merge requests
See merge request gitlab-org/gitlab-ce!27089
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Backports https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10161
(code out of ee/ folder).
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Used to get the variables via the API endpoint
`/projects/:id/pipelines/:pipeline_id/variables`
Signed-off-by: Agustin Henze <tin@redhat.com>
|
| |\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Git push options to create a merge request, set target_branch and set merge when pipeline succeeds
Closes #53198 and #43263
See merge request gitlab-org/gitlab-ce!26752
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
https://gitlab.com/gitlab-org/gitlab-ce/issues/43263
https://gitlab.com/gitlab-org/gitlab-ce/issues/53198
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Exceptions are no longer raised, instead all errors encountered are
added to the errors property.
MergeRequests::BuildService is used to generate attributes of a new
merge request.
Code moved from Api::Internal to Api::Helpers::InternalHelpers.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
MergeRequests::PushOptionsHandlerService has been updated to allow
creating and updating merge requests with the
`merge_when_pipeline_succeeds` set using git push options.
To create a new merge request and set it to merge when the pipeline
succeeds:
git push -u origin -o merge_request.create \
-o merge_request.merge_when_pipeline_succeeds
To update an existing merge request and set it to merge when the
pipeline succeeds:
git push -u origin -o merge_request.merge_when_pipeline_succeeds
Issue https://gitlab.com/gitlab-org/gitlab-ce/issues/53198
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Previously the raw push option Array was sent to Pipeline::Chain::Skip.
This commit updates this class (and the chain of classes that pass the
push option parameters from the API internal `post_receive` endpoint to
that class) to treat push options as a Hash of options parsed by
GitLab::PushOptions.
The GitLab::PushOptions class takes options like this:
-o ci.skip -o merge_request.create -o merge_request.target=branch
and turns them into a Hash like this:
{
ci: {
skip: true
},
merge_request: {
create: true,
target: 'branch'
}
}
This now how Pipeline::Chain::Skip is determining if the `ci.skip` push
option was used.
|
| | |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
To create a new merge request:
git push -u origin -o merge_request.create
To create a new merge request setting target branch:
git push -u origin -o merge_request.create \
-o merge_request.target=123
To update an existing merge request with a new target branch:
git push -u origin -o merge_request.target=123
A new Gitlab::PushOptions class handles parsing and validating the push
options array. This can be the start of the standard of GitLab accepting
push options that follow namespacing rules. Rules are discussed in issue
https://gitlab.com/gitlab-org/gitlab-ce/issues/43263.
E.g. these push options:
-o merge_request.create -o merge_request.target=123
Become parsed as:
{
merge_request: {
create: true,
target: '123',
}
}
And are fetched with the class via:
push_options.get(:merge_request)
push_options.get(:merge_request, :create)
push_options.get(:merge_request, :target)
A new MergeRequests::PushOptionsHandlerService takes the `merge_request`
namespaced push options and handles creating and updating
merge requests.
Any errors encountered are passed to the existing `output` Hash in
Api::Internal's `post_receive` endpoint, and passed to gitlab-shell
where they're output to the user.
Issue https://gitlab.com/gitlab-org/gitlab-ce/issues/43263
|
| |\ \ \ \
| |_|/ /
|/| | |
| | | |
| | | | |
Add methods to check dead and retrying jobs
See merge request gitlab-org/gitlab-ce!27149
|
| | |/ /
| | |
| | |
| | |
| | | |
It adds two methods for checking if a background job
(for a given class) has dead or retrying jobs.
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is resolving https://gitlab.com/gitlab-org/gitlab-ce/issues/30157.
Implement new API endpoint `/projects/:id/environments/:environment_id`
to expose single environment. Include information for environment's last
deployment if there is one.
|
| |/ /
| |
| |
| | |
Also set the release sha and author
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Fix stage index migration failing in PostgreSQL 10
Closes #59985
See merge request gitlab-org/gitlab-ce!26972
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
As discussed in
https://www.postgresql.org/message-id/9922.1353433645%40sss.pgh.pa.us,
the PostgreSQL window function last_value may not consider the
right rows:
Note that first_value, last_value, and nth_value consider only the rows
within the "window frame", which by default contains the rows from the
start of the partition through the last peer of the current row. This is
likely to give unhelpful results for last_value and sometimes also
nth_value. You can redefine the frame by adding a suitable frame
specification (RANGE or ROWS) to the OVER clause. See Section 4.2.8 for
more information about frame specifications.
This query could be fixed by adding `RANGE BETWEEN UNBOUNDED PRECEDING
AND UNBOUNDED FOLLOWING`, but that's quite verbose. It's simpler just to
use the first_value function.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/59985
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Improve performance of PR import
See merge request gitlab-org/gitlab-ce!27121
|
| | | |/
| |/|
| | |
| | |
| | |
| | | |
This removes unneeded `.reload` call which
makes AR to load ALL objects, and create its
in-memory representation.
|
