summaryrefslogtreecommitdiff
path: root/lib
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | | | | Merge branch '34141-allow-unauthenticated-access-to-the-users-api' into 'master'Rémy Coutable2017-07-041-6/+20
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow unauthenticated access to the `/api/v4/users` API Closes #34141 See merge request !12445
| | * | | | | | | | | Simplify authentication logic in the v4 users API for !12445.Timothy Andrew2017-07-042-7/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Rather than using an explicit check to turn off authentication for the `/users` endpoint, simply call `authenticate_non_get!`. - All `GET` endpoints we wish to restrict already call `authenticated_as_admin!`, and so remain inacessible to anonymous users. - This _does_ open up the `/users/:id` endpoint to anonymous access. It contains the same access check that `/users` users, and so is safe for use here. - More context: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12445#note_34031323
| | * | | | | | | | | Merge remote-tracking branch 'origin/master' into ↵Timothy Andrew2017-06-3044-190/+1672
| | |\ \ \ \ \ \ \ \ \ | | | | |_|_|_|/ / / / | | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 34141-allow-unauthenticated-access-to-the-users-api - Modify policy code to work with the `DeclarativePolicy` refactor in 37c401433b76170f0150d70865f1f4584db01fa8.
| | * | | | | | | | | Implement review comments for !12445 from @godfat and @rymai.Timothy Andrew2017-06-302-17/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Use `GlobalPolicy` to authorize the users that a non-authenticated user can fetch from `/api/v4/users`. We allow access if the `Gitlab::VisibilityLevel::PUBLIC` visibility level is not restricted. - Further, as before, `/api/v4/users` is only accessible to unauthenticated users if the `username` parameter is passed. - Turn off `authenticate!` for the `/api/v4/users` endpoint by matching on the actual route + method, rather than the description. - Change the type of `current_user` check in `UsersFinder` to be more compatible with EE.
| | * | | | | | | | | Allow unauthenticated access to the `/api/v4/users` API.Timothy Andrew2017-06-262-6/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - The issue filtering frontend code needs access to this API for non-logged-in users + public projects. It uses the API to fetch information for a user by username. - We don't authenticate this API anymore, but instead - if the `current_user` is not present: - Verify that the `username` parameter has been passed. This disallows an unauthenticated user from grabbing a list of all users on the instance. The `UsersFinder` class performs an exact match on the `username`, so we are guaranteed to get 0 or 1 users. - Verify that the resulting user (if any) is accessible to be viewed publicly by calling `can?(current_user, :read_user, user)`
| * | | | | | | | | | Merge branch 'gitaly-clean-up-tests' into 'master'Sean McGivern2017-07-041-1/+1
| |\ \ \ \ \ \ \ \ \ \ | | |_|_|_|/ / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clean up Gitaly tests See merge request !12526
| | * | | | | | | | | Add test for GitalyClient::Ref#find_ref_nameJacob Vosmaer2017-07-041-1/+1
| | | |/ / / / / / / | | |/| | | | | | |
| * | | | | | | | | Optimize creation of commit API by using Repository#commit instead of ↵sh-optimize-project-commit-apiStan Hu2017-07-031-1/+1
| | |_|_|_|_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Repository#commits Repository#commits is expensive because it has to use Rugged to walk the Git tree as opposed to doing a direct ref lookup. Improves performance in #34533
| * | | | | | | | Speed up operations performed by gitlab-shellStan Hu2017-07-031-21/+48
| | |_|_|/ / / / | |/| | | | | |
| * | | | | | | Merge branch 'change-extended-docker-configuration-syntax' into 'master'Grzegorz Bizon2017-07-022-3/+3
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make entrypoint and command keys to be array of strings See merge request !12536
| | * | | | | | | Make entrypoint and command keys to be array of stringsTomasz Maczukin2017-07-022-3/+3
| | | | | | | | |
| * | | | | | | | Merge branch 'enable-webpack-code-splitting' into 'master'Jacob Schatz2017-06-301-0/+3
| |\ \ \ \ \ \ \ \ | | |/ / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Enable webpack code splitting Closes #32989 See merge request !12032
| | * | | | | | | configure webpack publicPath dynamically to account for CDN or relative path ↵Mike Greiling2017-06-281-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | settings
| * | | | | | | | Improve support for external issue referencesadam-external-issue-references-spikeAdam Niedzielski2017-06-304-49/+5
| | |/ / / / / / | |/| | | | | |
| * | | | | | | Merge branch ↵Dmitriy Zaporozhets2017-06-301-3/+5
| |\ \ \ \ \ \ \ | | |_|_|/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | '34502-gitlab-git-hook-should-set-the-gl_repository-environment-variable' into 'master' Set the GL_REPOSITORY env variable on Gitlab::Git::Hook Closes #34502 See merge request !12572
| | * | | | | | Set the GL_REPOSITORY env variable on Gitlab::Git::Hook34502-gitlab-git-hook-should-set-the-gl_repository-environment-variableAlejandro Rodríguez2017-06-291-3/+5
| | | | | | | |
| * | | | | | | bugfix: use `require_dependency` to bring in DeclarativePolicybugfix/declarative-policy-reloadinghttp://jneen.net/2017-06-291-1/+1
| |/ / / / / /
| * | | | | | Merge branch '34078-allow-to-enable-feature-flags-with-more-granularity' ↵Robert Speicher2017-06-292-11/+50
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | into 'master' Allow the feature flags to be enabled/disabled with more granularity Closes #34078 See merge request !12357
| | * | | | | | Rename flipper_group to feature_group34078-allow-to-enable-feature-flags-with-more-granularityRémy Coutable2017-06-281-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
| | * | | | | | Rename FLippable to FeatureGate and make `flipper_group` and `user` mutually ↵Rémy Coutable2017-06-271-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | exclusive Signed-off-by: Rémy Coutable <remy@rymai.me>
| | * | | | | | Allow the feature flags to be enabled/disabled with more granularityRémy Coutable2017-06-272-11/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows to enable/disable a feature flag for a given user, or a given Flipper group (must be declared statically in the `flipper.rb` initializer beforehand). Signed-off-by: Rémy Coutable <remy@rymai.me>
| * | | | | | | Merge branch 'sha-attributes-for-postgresql-and-mysql' into 'master'Sean McGivern2017-06-291-0/+34
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added code for defining SHA attributes See merge request !12555
| | * | | | | | | Added code for defining SHA attributesYorick Peterse2017-06-291-0/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These attributes are stored in binary in the database, but exposed as strings. This allows one to query/create data using plain SHA1 hashes as Strings, while storing them more efficiently as binary.
| * | | | | | | | Merge branch 'zj-usage-ping-only-gl-pipelines' into 'master'Kamil Trzciński2017-06-291-1/+2
| |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Only count GL pipelines in usage data ping Closes #33172 See merge request !12277
| | * | | | | | | | Split pipelines by origin on usage datazj-usage-ping-only-gl-pipelinesZ.J. van de Weg2017-06-271-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When sending the usage data, it now includes all pipelines. This commit will split the pipelines in two; internal and external. This will lead to historical data being incorrectly marked this way. Fixes gitlab-org/gitlab-ce#33172
| * | | | | | | | | Merge branch 'refactor/declarative-policy' into 'master'Sean McGivern2017-06-2912-3/+1230
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactor/declarative policy See merge request !10515
| | * | | | | | | | | use subject scope in :id/usershttp://jneen.net/2017-06-271-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | since we're loading all the members anyways
| | * | | | | | | | | convert all the policies to DeclarativePolicyhttp://jneen.net/2017-06-271-2/+2
| | | | | | | | | | |
| | * | | | | | | | | implement Presenter::Base#declarative_policy_delegatehttp://jneen.net/2017-06-271-0/+5
| | | | | | | | | | |
| | * | | | | | | | | add a new DeclarativePolicy frameworkhttp://jneen.net/2017-06-279-0/+1220
| | | |_|/ / / / / / | | |/| | | | | | |
| * | | | | | | | | Merge branch 'add-members-count-and-parent-id-data-on-namespaces-api' into ↵Douwe Maan2017-06-292-2/+10
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'master' Add group members counting related data on namespaces API See merge request !12497
| | * | | | | | | | | Rename members_count to members_count_with_descendants and expose only to ↵Oswaldo Ferreira2017-06-282-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | group admins
| | * | | | | | | | | Add "members_count" and "parent_id" data on namespaces APIOswaldo Ferreira2017-06-281-1/+5
| | | | | | | | | | |
| * | | | | | | | | | Merge branch ↵Rémy Coutable2017-06-291-0/+2
| |\ \ \ \ \ \ \ \ \ \ | | |_|_|_|/ / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | '34280-gitalyclient-sort_by_param-invalid-sort_by-key-recently_updated' into 'master' Fix a bug where an invalid sort param value was passed to Gitaly Closes #34280 See merge request !12534
| | * | | | | | | | | Fix a bug where an invalid sort param value was passed to Gitaly34280-gitalyclient-sort_by_param-invalid-sort_by-key-recently_updatedAlejandro Rodríguez2017-06-281-0/+2
| | |/ / / / / / / /
| * | | | | | | | | Merge branch 'bvl-rename-all-reserved-paths' into 'master'Sean McGivern2017-06-294-20/+139
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rename all forbidden paths again Closes #32625 See merge request !11713
| | * | | | | | | | | Adjust for new static-analysis failuresbvl-rename-all-reserved-paths-mysqlBob Van Landuyt2017-06-271-2/+2
| | | | | | | | | | |
| | * | | | | | | | | Only do one query for updating routesBob Van Landuyt2017-06-271-5/+15
| | | | | | | | | | |
| | * | | | | | | | | Update routes directly by ID instead of filtering by pathBob Van Landuyt2017-06-261-4/+12
| | | | | | | | | | |
| | * | | | | | | | | Clear the cache for projects one-by-oneBob Van Landuyt2017-06-261-14/+16
| | | | | | | | | | |
| | * | | | | | | | | Add punctuation to log messagesBob Van Landuyt2017-06-263-4/+6
| | | | | | | | | | |
| | * | | | | | | | | Keep failed renames in redisBob Van Landuyt2017-06-261-1/+13
| | | | | | | | | | |
| | * | | | | | | | | Use the migration name as a key in redisBob Van Landuyt2017-06-261-1/+1
| | | | | | | | | | |
| | * | | | | | | | | Don't break rolling back when a namespace or project was renamedBob Van Landuyt2017-06-262-5/+7
| | | | | | | | | | |
| | * | | | | | | | | More logging so we know we have the rename in redisBob Van Landuyt2017-06-261-1/+5
| | | | | | | | | | |
| | * | | | | | | | | Revert renames from a migrationBob Van Landuyt2017-06-261-0/+5
| | | | | | | | | | |
| | * | | | | | | | | Revert namespace renamesBob Van Landuyt2017-06-262-1/+23
| | | | | | | | | | |
| | * | | | | | | | | Add methods to revert project renamesBob Van Landuyt2017-06-262-6/+49
| | | | | | | | | | |
| | * | | | | | | | | Track all renames in redisBob Van Landuyt2017-06-263-0/+9
| | | | | | | | | | |
| * | | | | | | | | | Merge branch '30708-stop-using-deleted-at-to-filter-namespaces' into 'master'Douwe Maan2017-06-292-2/+4
| |\ \ \ \ \ \ \ \ \ \ | | |_|/ / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | refactors Project#search namespace join Closes #30708 See merge request !12091
View Lorry Controller Status