| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |\
| |
| |
| |
| | |
Make Gitlab::GlRepository#types an instance method
See merge request gitlab-org/gitlab-ce!27902
|
| | |
| |
| |
| |
| |
| |
| |
| | |
Having this as an instance method makes it easier to override in the
prepended `EE` module.
If we try to override this method on the module itself, it would not
be overridden correctly, depending on the load order.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Updates the EnvironmentController#metrics_dashboard endpoint
to support a "dashboard" param, which can be used to specify
the filepath of a dashboard configuration from a project
repository. Dashboard configurations are expected to be
stored in .gitlab/dashboards/.
Updates dashboard post-processing steps to exclude custom
metrics, which should only display on the system dashboard.
|
| |\ \
| | |
| | |
| | |
| | | |
feat: add option to define the Sentry Environment
See merge request gitlab-org/gitlab-ce!27091
|
| | |/ |
|
| |\ \
| |/
|/|
| |
| | |
Add client methods for FetchIntoObjectPool RPC
See merge request gitlab-org/gitlab-ce!27767
|
| | |
| |
| |
| |
| |
| |
| | |
Gitaly's FetchIntoObjectPool RPC will idempotently fetch objects into an
object pool. If the pool doesn't exist, it will create an empty pool
before attempting the fetch. This change adds client code as well as
specs to cover this behavior.
|
| |\ \
| | |
| | |
| | |
| | | |
Use correct k8s namespace in Prometheus queries
See merge request gitlab-org/gitlab-ce!27812
|
| | | |
| | |
| | |
| | |
| | | |
Before this commit the wrong namespace could have been used in
Prometheus queries for group-level installations.
|
| | | | |
|
| | | | |
|
| |\ \ \
| |_|/
|/| |
| | |
| | | |
Change comments to point to the new path of sidekiq-cluster
See merge request gitlab-org/gitlab-ce!27707
|
| | | |
| | |
| | |
| | |
| | | |
`sidekiq-cluster` is moved from `bin/` to `ee/bin` in EE code. This
is a corresponding change in CE.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
Use keyword args for databuilder push
See merge request gitlab-org/gitlab-ce!24088
|
| | |/ / |
|
| |\ \ \ |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In Rails 5, including `ActionView::Context` can have a significant and
hidden performance penalty because this module also includes
`ActionView::CompiledTemplates`. This means that any module that
includes ActionView::Context becomes a descendant of
`CompiledTemplates`.
When a partial is rendered for the first time, it runs
`ActionView::CompiledTemplates#module_eval`, which will evaluate a
string that defines a new method for that partial. For example, the
source of partial might be this string:
```
def _app_views_project_show_html_haml___12345(local_assigns, output)
"hello world"
end
```
When this string is evaluated, the Ruby interpreter will define the
method and clear the global method cache for all descendants of
`ActionView::CompiledTemplates`. Previous to this change, we
inadvertently made a number of modules fall into this category:
* GroupChildEntity
* NoteUserEntity
* Notify
* MergeRequestUserEntity
* AnalyticsCommitEntity
* CommitEntity
* UserEntity
* Kaminari::Helpers::Paginator
* CurrentUserEntity
* ActionView::Base
* ActionDispatch::DebugExceptions::DebugView
* MarkupHelper
* MergeRequestPresenter
After this change:
* Kaminari::Helpers::Paginator
* ActionView::Base
* ActionDispatch::DebugExceptions::DebugView
Each time a partial is rendered for the first time, all methods for
those modules will have to be redefined. This can exact a significant
performance penalty.
How bad is this penalty? Using the following benchmark script, we can
use DTrace to sample the Ruby interpreter:
```
Benchmark.bm do |x|
x.report do
1000.times do
ActionView::CompiledTemplates.module_eval("def testme\nend")
end
end
end
```
This revealed a 11x jump in the time spent in `core#define_method`
alone.
Rails 6 fixes this behavior by moving the `include CompiledTemplates`
into ActionView::Base so that including `ActionView::Context` doesn't
quietly affect other modules in this way.
Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11198
|
| | |\ \ \
| | |_|/
| |/| |
| | | |
| | | | |
Port changes for design management to CE
See merge request gitlab-org/gitlab-ce!27555
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This ports the changes from
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10462/
to CE
|
| | |\ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fix Profiler to work with Rails 5.1
Closes #61051
See merge request gitlab-org/gitlab-ce!27774
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Ruby 5.1 now requires keyword arguments to pass along parameters and
headers for ActionDispatch::Integration::RequestHelpers.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/61051
|
| | | |/ /
| |/| | |
|
| | |\ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
'60945-masked-variable-still-printed-in-log-output-on-gitlab-com' into 'master'
Resolve "Masked Variable still printed in log output on gitlab.com"
Closes #60945
See merge request gitlab-org/gitlab-ce!27768
|
| | | |/ / |
|
| | |\ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Create dashboards endpoint & setup dashboard post-processing
Closes #60383
See merge request gitlab-org/gitlab-ce!27405
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Change MetricsDashboard::Service to inherit from BaseService so that
it can reuse methods like initialize, success, error.
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Order groups by descending order of priority.
- Order panels by descending order of weight.
- Perform sorting after adding project/custom metrics.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Add 3 functions called find_or_create_panel,
find_or_create_panel_group, and find_or_create_metric to avoid having
to use 'send'.
- Remove an unused variable.
- Freeze a constant array.
|
| | | | | | |
|
| | | |/ /
| |/| |
| | | |
| | | |
| | | | |
This enables sending a chat message to Slack or Mattermost
upon a successful, failed, or canceled deployment
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This new table will be used to store the external_dashboard_url which
allows users to add a link to their external dashboards (ex Grafana)
to the Metrics dashboard.
|
| | | | | |
|
| | |\ \ \
| | |_|/
| |/| |
| | | |
| | | |
| | | |
| | | | |
Fix #57351 - Add .NET Core YAML template
Closes #57351
See merge request gitlab-org/gitlab-ce!25604
|
| | | | |
| | | |
| | | |
| | | | |
Improve indent for cache paths
|
| | | | |
| | | |
| | | |
| | | | |
Improve indent and remove empty lines
|
| | | | |
| | | |
| | | |
| | | | |
Revise logic of dependency caching, add cache key, make before script global.
|
| | | | |
| | | |
| | | |
| | | | |
Update the template showing how to cache restored dependencies, add few variables, reduce before_script part, add and improve descriptions.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| |\ \ \ \
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | | |
'master'
Disallow read user scope to read project events
See merge request gitlab/gitlabhq!3067
|
