summaryrefslogtreecommitdiff
path: root/lib
Commit message (Collapse)AuthorAgeFilesLines
* Prepend entity descendant where necessarywinh-prepend-entityWinnie Hellmann2019-08-271-6/+6
| | | | (cherry picked from commit b87526e8c47b7a3938ab12842bbac99a17fcb750)
* Disable InjectEnterpriseEditionModule for lib/api/entities.rbWinnie Hellmann2019-08-271-1/+2
| | | | (cherry picked from commit a9454734d851ecc6d9e4a86cd667a33a492fdef9)
* Replace prepend_entity with prepend_if_eeWinnie Hellmann2019-08-271-0/+17
| | | | (cherry picked from commit 897a9d308db46b620b738b98f2b0e5630ac7d2dd)
* Danger: Map .rubocop{,_todo}.yml to ~backendPeter Leitzen2019-08-261-0/+1
|
* Merge branch 'db_load_balancing_service_discovery_srv' into 'master'Kamil Trzciński2019-08-261-1/+2
|\ | | | | | | | | DB Load Balancing: Support SRV lookups See merge request gitlab-org/gitlab-ce!32135
| * CE port: allow SRV records in DB service discoverydb_load_balancing_service_discovery_srvTiger2019-08-231-1/+2
| |
* | Add helper to exactly undo cleanup_concurrent_column_renameReuben Pereira2019-08-251-1/+40
| | | | | | | | - Also add helper to undo rename_column_concurrently.
* | Drop existing trigger before creating new oneReuben Pereira2019-08-241-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | - When renaming a column concurrently, drop any existing trigger before attempting to create a new one. When running migration specs multiple times (as it happens during local development), the down method of previous migrations are called. If any of the called methods contains a call to rename_column_concurrently, a trigger will be created and not removed. So, the next time a migration spec is run, if the same down method is executed again, it will cause an error when attempting to create the trigger (since it already exists). Dropping the trigger if it already exists will prevent this problem.
* | Add a link to docs in project descriptionReuben Pereira2019-08-231-0/+251
| | | | | | | | Add to the service and migration both.
* | Merge branch '66402-use-visual-review-tools-npm-package' into 'master'Mike Greiling2019-08-231-6/+0
|\ \ | | | | | | | | | | | | Resolve "Use Visual Review Tools NPM package" See merge request gitlab-org/gitlab-ce!32159
| * | Move visual review toolbar to NPMshampton2019-08-231-6/+0
| | | | | | | | | | | | | | | Remove the visual review toolbar code in favor of using the NPM package.
* | | Read pipelines from public projects though APIMarius Bobin2019-08-231-1/+2
| | | | | | | | | | | | | | | Allow users to read pipelines for public projects with public builds enabled without providing an access token.
* | | Implement validation logic to ProjectStageAdam Hegyi2019-08-2314-0/+440
| | | | | | | | | | | | | | | | | | - Introducting StageEvents to define the available events - Define the event pairing rules, since some events are not compatible - Express default Cycle Analytics stages with the event structure
* | | Merge branch 'jc-add-ff-for-all-lfs-pointers-go' into 'master'Stan Hu2019-08-231-0/+1
|\ \ \ | | | | | | | | | | | | | | | | Adding gitaly feature flag for go implementation of get all lfs pointers See merge request gitlab-org/gitlab-ce!31696
| * | | Adding gitaly feature flag for go implementation of get all lfs pointersjc-add-ff-for-all-lfs-pointers-goJohn Cai2019-08-231-0/+1
| |/ /
* | | Add label_id parameter to label API for PUT and DELETEPatrick Derichs2019-08-232-12/+28
| | | | | | | | | | | | Add specs for new parameter and updated documentation as well.
* | | Merge branch 'jc-fix-auto-rugged-detection' into 'master'Lin Jen-Shin2019-08-231-1/+2
|\ \ \ | | | | | | | | | | | | | | | | Handle when server info doesn't have the storage in question See merge request gitlab-org/gitlab-ce!32023
| * | | Handle when server info doesn't have the storage in questionJohn Cai2019-08-231-1/+2
| |/ /
* | | Merge branch 'sh-eliminate-gitaly-nplus-one-notes' into 'master'Kamil Trzciński2019-08-232-6/+9
|\ \ \ | |/ / |/| | | | | | | | Eliminate Gitaly N+1 queries with notes API See merge request gitlab-org/gitlab-ce!32089
| * | Eliminate Gitaly N+1 queries with notes APIsh-eliminate-gitaly-nplus-one-notesStan Hu2019-08-222-6/+9
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Similar to https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31834, we see that in https://gitlab.com/gitlab-org/gitlab-ce/issues/65957 there can be hundreds, even thousands, of Gitaly requests in the `/api/:version/projects/:id/merge_requests/:noteable_id/notes` endpoint. Previously, the API to retrieve notes generated hundreds of Gitaly calls to determine whether a system note should be shown to the user. It did this by: 1. Rendering the Markdown 2. Extracting cross-references from the Markdown 3. Issuing a Gitaly `FindCommit` RPC for every reference to validate that the commit exists. The last step is unnecessary because we don't need to display a commit if the user doesn't have access to the project in the first place. `RendersNotes#prepare_notes_for_rendering` is already used in `MergeRequestsController`, which is why we don't see N+1 Gitaly calls there. We use it here to optimize the note redaction process.
* | Merge branch '57402-upate-issues-list-sort-options-ce' into 'master'Jan Provaznik2019-08-232-4/+7
|\ \ | | | | | | | | | | | | CE: Update sort options for issues list See merge request gitlab-org/gitlab-ce!31849
| * | Update sort options for issues list57402-upate-issues-list-sort-options-ceAlexandru Croitor2019-08-232-4/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Increase sort options for issues list from updated_at and create_at, to include more options close to what is required in actual issue list UI. This helps us to use REST API for issues list with sorting capabilities https://gitlab.com/gitlab-org/gitlab-ce/issues/57402
* | | Merge branch 'frozen_string_lib_2' into 'master'Nick Thomas2019-08-232-2/+3
|\ \ \ | |/ / |/| | | | | | | | Add frozen_string_literal to lib part 2 See merge request gitlab-org/gitlab-ce!32094
| * | Fix frozen string errorfrozen_string_lib_2Thong Kuah2019-08-231-1/+2
| | |
| * | Fix frozen string errorsThong Kuah2019-08-231-1/+1
| | |
* | | Exempt `jwt/auth` for user `gitlab-ci-token` from rate limitingMarius Bobin2019-08-231-1/+5
| |/ |/|
* | Expose namespace storage statistics with GraphQLAlessio Caiazza2019-08-221-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Root namespaces have storage statistics. This commit allows namespace owners to get those stats via GraphQL queries like the following one { namespace(fullPath: "a_namespace_path") { rootStorageStatistics { storageSize repositorySize lfsObjectsSize buildArtifactsSize packagesSize wikiSize } } }
* | Log time spent on CPU to sidekiq.logBalakumar2019-08-221-10/+36
| |
* | Merge branch 'feat/smime-signed-notification-emails' into 'master'Sean McGivern2019-08-223-0/+115
|\ \ | |/ |/| | | | | feat: smime signed notification emails See merge request gitlab-org/gitlab-ce!30644
| * feat: SMIME signed notification emailsDiego Louzán2019-08-203-0/+115
| | | | | | | | | | | | - Add mail interceptor the signs outgoing email with SMIME - Add lib and helpers to work with SMIME data - New configuration params for setting up SMIME key and cert files
* | Merge branch ↵Kushal Pandya2019-08-221-0/+2
|\ \ | | | | | | | | | | | | | | | | | | 'ee-2502-refactor-ee-app-assets-javascripts-approvals-components-approvers_select-vue-to-remove-approverusers' into 'master' Add a new method to `Api.js`: `projectUsers` See merge request gitlab-org/gitlab-ce!31801
| * | Add a skip_users filter to the project users APINick Thomas2019-08-191-0/+2
| | | | | | | | | | | | | | | | | | This functionality is available in the /autocomplete users pseudo-API. We're attempting to replace that with the canonical API, so it needs support for this parameter too.
* | | Add Gitaly info-ref cache feature flagsPaul Okstad2019-08-221-2/+4
| | |
* | | Merge branch 'sidekiq-interrupt-running-jobs-deadset' into 'master'Stan Hu2019-08-211-1/+5
|\ \ \ | | | | | | | | | | | | | | | | Put cancelled job in DeadSet See merge request gitlab-org/gitlab-ce!32070
| * | | Put cancelled job in DeadSetsidekiq-interrupt-running-jobs-deadsetKamil Trzciński2019-08-211-1/+5
| | | | | | | | | | | | | | | | | | | | This replicates Sidekiq behavior of pushing dead job into DeadSet.
* | | | Merge branch 'uncomment_commit_signatures_feature_flag' into 'master'Stan Hu2019-08-211-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Upgrade to gitaly 1.60.0 and uncomment get_commit_signatures feature flag Closes #65991 See merge request gitlab-org/gitlab-ce!31981
| * | | | Uncomment get_commit_signatures feature flagFelipe Artur2019-08-191-1/+1
| | | | |
* | | | | Ensure CI matching operator receives an objectMarius Bobin2019-08-212-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | Ensure the evaluation of right-hand side expression always results in the returning of an object or an empty String
* | | | | Merge branch 'sidekiq-interrupt-running-jobs' into 'master'Stan Hu2019-08-213-1/+202
|\ \ \ \ \ | | |/ / / | |/| | | | | | | | | | | | | Allow to interrupt running sidekiq jobs See merge request gitlab-org/gitlab-ce!31818
| * | | | Properly handle `sidekiq` skipsidekiq-interrupt-running-jobsKamil Trzciński2019-08-212-6/+9
| | | | | | | | | | | | | | | | | | | | Transform `CancelledError` into `JobRetry::Skip`
| * | | | Improve resillency of monitorKamil Trzciński2019-08-212-26/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Retry connection when it fails - Properly shutdown daemon - Stop monitor if the Exception is raised - Properly guard exception handling
| * | | | Perform cheap thread findKamil Trzciński2019-08-211-9/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we process message that is not designated to us previously we would fire a separate Thread for that. We don't need to do it. We can cheaply check if thread is available, if it is, we can perform expensive operation then.
| * | | | Rework `Sidekiq::JobsThreads` into `Monitor`Kamil Trzciński2019-08-214-95/+166
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes: - very shallow `Middleware::Monitor` to only request tracking of sidekiq jobs, - `SidekiqStatus::Monitor` to be responsible to maintain persistent connection to receive messages, - `SidekiqStatus::Monitor` to always use structured logging and instance variables
| * | | | Allow to interrupt running jobsKamil Trzciński2019-08-212-0/+95
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds a middleware to track all threads for running jobs. This makes sidekiq to watch for redis-delivered notifications. This makes be able to send notification to interrupt running sidekiq jobs. This does not take into account any native code, as `Thread.raise` generates exception once the control gets back to Ruby. The separate measure should be taken to interrupt gRPC, shellouts, or anything else that escapes Ruby.
* | | | | Add service classes for mutating AwardEmojiLuke Duncalfe2019-08-211-4/+4
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adding, destroying and toggling emoji previously lacked services and instead were performed through methods called on Awardable models. This led to inconsistencies where relevant todos would be marked as done only when emoji were awarded through our controllers, but not through the API. Todos could also be marked as done when an emoji was being removed. Behaviour changes - Awarding emoji through the API will now mark a relevant Todo as done - Toggling an emoji off (destroying it) through our controllers will no longer mark a relevant Todo as done Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63372
* | | | Introducing new Syntax for Ci::Build inclusion rulesdrew2019-08-2011-24/+317
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Added Gitlab::Ci::Config::Entry::Rules and Gitlab::Ci::Config::Entry::Rules:Rule to handle lists of Rule objects to be evalauted for job inclusion - Added `if:` and `changes:` as available Rules::Rule::Clause classes - Added Rules handling logic to Seed::Build#included? with extra specs - Use DisallowedKeysValidator to mutually exclude rules: from only:/except: on job config
* | | | Standardize remote_ip and path keys for auth.log and api_json.logStan Hu2019-08-203-3/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Current `auth.log` uses `fullpath` and `ip`, while `api_json.log` uses `remote_ip` and `path` for the same fields. Let's standardize these namings to make it easier for people working with the data. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66167
* | | | Merge branch 'bvl-mr-commit-note-counter' into 'master'Douwe Maan2019-08-201-4/+4
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Count notes for commits and merge requests See merge request gitlab-org/gitlab-ce!31912
| * | | | Count comments on notes and merge requestsBob Van Landuyt2019-08-161-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | This extends our existing `Gitlab::UsageDataCounters::NoteCounter` to also count notes on commits and merge requests
* | | | | Allow measurement for Sidekiq jobs taking > 2.5sAndrew Newdigate2019-08-201-1/+5
| | | | | | | | | | | | | | | | | | | | Fix for https://gitlab.com/gitlab-org/gitlab-ce/issues/66319.